* [PATCH -next] drm/msm: Remove unused variables 'top'
@ 2022-10-10 2:40 Chen Zhongjin
2022-10-04 16:27 ` Abhinav Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhongjin @ 2022-10-10 2:40 UTC (permalink / raw)
To: linux-kernel, linux-arm-msm, dri-devel, freedreno
Cc: robdclark, quic_abhinavk, dmitry.baryshkov, sean, airlied,
daniel, swboyd, dianders, andersson, chenzhongjin
'commit 1e5df24b996c ("drm/msm/dpu: drop length from struct dpu_hw_blk_reg_map")'
'commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map")'
These commits had merged hw.blk_off and hw.blk_off to mdp.
So we don't need to get dpu_hw_mdp in dpu_kms_mdp_snapshot() now.
Since there is no code using 'top' in this function. Remove it.
Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index 008e1420e6e5..79e81f1443be 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -902,13 +902,9 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
int i;
struct dpu_kms *dpu_kms;
const struct dpu_mdss_cfg *cat;
- struct dpu_hw_mdp *top;
dpu_kms = to_dpu_kms(kms);
-
cat = dpu_kms->catalog;
- top = dpu_kms->hw_mdp;
-
pm_runtime_get_sync(&dpu_kms->pdev->dev);
/* dump CTL sub-blocks HW regs info */
--
2.33.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] drm/msm: Remove unused variables 'top'
2022-10-10 2:40 [PATCH -next] drm/msm: Remove unused variables 'top' Chen Zhongjin
@ 2022-10-04 16:27 ` Abhinav Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Abhinav Kumar @ 2022-10-04 16:27 UTC (permalink / raw)
To: Chen Zhongjin, linux-kernel, linux-arm-msm, dri-devel, freedreno
Cc: dianders, sean, andersson, swboyd, dmitry.baryshkov
On 10/9/2022 7:40 PM, Chen Zhongjin wrote:
> 'commit 1e5df24b996c ("drm/msm/dpu: drop length from struct dpu_hw_blk_reg_map")'
> 'commit 9403f9a42c88 ("drm/msm/dpu: merge base_off with blk_off in struct dpu_hw_blk_reg_map")'
> These commits had merged hw.blk_off and hw.blk_off to mdp.
> So we don't need to get dpu_hw_mdp in dpu_kms_mdp_snapshot() now.
>
> Since there is no code using 'top' in this function. Remove it.
>
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
This has already been fixed with:
https://gitlab.freedesktop.org/drm/msm/-/commit/4bca876458caf7c105ab2ae9d80ff2cc9c60388d
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> index 008e1420e6e5..79e81f1443be 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
> @@ -902,13 +902,9 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k
> int i;
> struct dpu_kms *dpu_kms;
> const struct dpu_mdss_cfg *cat;
> - struct dpu_hw_mdp *top;
>
> dpu_kms = to_dpu_kms(kms);
> -
> cat = dpu_kms->catalog;
> - top = dpu_kms->hw_mdp;
> -
> pm_runtime_get_sync(&dpu_kms->pdev->dev);
>
> /* dump CTL sub-blocks HW regs info */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-04 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 2:40 [PATCH -next] drm/msm: Remove unused variables 'top' Chen Zhongjin
2022-10-04 16:27 ` Abhinav Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®