mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Jonathan Corbet <corbet@lwn.net>, Joe Perches <joe@perches.com>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CodingStyle: Remove "Don't use C99-style comments"
Date: Sun, 14 Aug 2016 12:09:36 -0700	[thread overview]
Message-ID: <fa9279c5-8139-e548-bb9c-a4fa35c47e64@infradead.org> (raw)
In-Reply-To: <20160814123523.26ae4b40@lwn.net>

On 08/14/16 11:35, Jonathan Corbet wrote:
> On Thu, 04 Aug 2016 10:55:14 -0700
> Joe Perches <joe@perches.com> wrote:
> 
>>> Because Linus may still be reading source code on greenbar paper
>>> instead of color terminals with code syntax highlighting and
>>> appropriate font decorations.
>>>
>>> Link: http://lkml.kernel.org/r/CA+55aFyQYJerovMsSoSKS7PessZBr4vNp-3QUUwhqk4A4_jcbg@mail.gmail.com
>>>
>>> Signed-off-by: Joe Perches <joe@perches.com>
>>> ---
>>>  Documentation/CodingStyle | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>
>>> diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
>>> index 9a70ddd..19b2e9c 100644
>>> --- a/Documentation/CodingStyle
>>> +++ b/Documentation/CodingStyle
>>> @@ -461,9 +461,6 @@ When commenting the kernel API functions, please use the kernel-doc format.
>>>  See the files Documentation/kernel-doc-nano-HOWTO.txt and scripts/kernel-doc
>>>  for details.
>>>  
>>> -Linux style for comments is the C89 "/* ... */" style.
>>> -Don't use C99-style "// ..." comments.
>>> -
>>>  The preferred style for long (multi-line) comments is:
>>>  
>>>  	/*  
>>
>> ping?
> 
> Sorry, I've not been ignoring this, I've just not yet worked up the
> courage to apply it.  Yes, Linus said he's fine with C++-style comments,
> but I still expect some pushback when people start actually sending them.
> I don't quite feel a sense of community consensus on this one.
> 
> Still, what the heck, I'll go ahead and apply it.  We can always revert it
> when people start screaming :)

I like it, but like Linus said, we don't want people to send
patches just to "fix" the comment style.

-- 
~Randy

  parent reply	other threads:[~2016-08-14 19:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  0:18 Joe Perches
2016-08-04 17:55 ` Joe Perches
2016-08-14 18:35   ` Jonathan Corbet
2016-08-14 18:43     ` Joe Perches
2016-08-14 19:09     ` Randy Dunlap [this message]
2016-08-14 19:19       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa9279c5-8139-e548-bb9c-a4fa35c47e64@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=joe@perches.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®