From: Keerthy <j-keerthy@ti.com>
To: Colin King <colin.king@canonical.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
<linux-pm@vger.kernel.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] thermal: core: make thermal_emergency_poweroff static
Date: Tue, 9 May 2017 09:05:31 +0530 [thread overview]
Message-ID: <fa978f44-732b-c7bb-33d6-8d4df8e31155@ti.com> (raw)
In-Reply-To: <20170508103643.10748-1-colin.king@canonical.com>
On Monday 08 May 2017 04:06 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Making thermal_emergency_poweroff static fixes sparse warning:
>
> drivers/thermal/thermal_core.c:6: warning: symbol
> 'thermal_emergency_poweroff' was not declared. Should it be static?
Acked-by: Keerthy <j-keerthy@ti.com>
>
> Fixes: ef1d87e06ab4 ("thermal: core: Add a back up thermal shutdown mechanism")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/thermal/thermal_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index b21b9cc2c8d6..5a51c740e372 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -359,7 +359,7 @@ static DECLARE_DELAYED_WORK(thermal_emergency_poweroff_work,
> * This may be called from any critical situation to trigger a system shutdown
> * after a known period of time. By default this is not scheduled.
> */
> -void thermal_emergency_poweroff(void)
> +static void thermal_emergency_poweroff(void)
> {
> int poweroff_delay_ms = CONFIG_THERMAL_EMERGENCY_POWEROFF_DELAY_MS;
> /*
>
prev parent reply other threads:[~2017-05-09 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 10:36 Colin King
2017-05-09 3:35 ` Keerthy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa978f44-732b-c7bb-33d6-8d4df8e31155@ti.com \
--to=j-keerthy@ti.com \
--cc=colin.king@canonical.com \
--cc=edubezval@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®