From: Andrew Lunn <andrew@lunn.ch>
To: "Kamil Horák - 2N" <kamilh@axis.com>
Cc: florian.fainelli@broadcom.com,
bcm-kernel-feedback-list@broadcom.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
conor+dt@kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, robh@kernel.org
Subject: Re: [PATCH net-next v3 1/3] net: phy: MII-Lite PHY interface mode
Date: Wed, 25 Jun 2025 18:48:24 +0200 [thread overview]
Message-ID: <fab0b3e5-9860-43c2-8c02-70d855b598a1@lunn.ch> (raw)
In-Reply-To: <20250625163453.2567869-2-kamilh@axis.com>
On Wed, Jun 25, 2025 at 06:34:51PM +0200, Kamil Horák - 2N wrote:
> From: Kamil Horák (2N) <kamilh@axis.com>
>
> Some Broadcom PHYs are capable to operate in simplified MII mode,
> without TXER, RXER, CRS and COL signals as defined for the MII.
> The MII-Lite mode can be used on most Ethernet controllers with full
> MII interface by just leaving the input signals (RXER, CRS, COL)
> inactive. The absence of COL signal makes half-duplex link modes
> impossible but does not interfere with BroadR-Reach link modes on
> Broadcom PHYs, because they are all full-duplex only.
>
> Add MII-Lite interface mode, especially for Broadcom two-wire PHYs.
> Add MII-Lite activation for bcm5481x PHYs.
Please split this patch into two. Add PHY_INTERFACE_MODE_MIILITE to
the core first. Then add support for it to the broadcom PHY.
Splitting it allows you to make the commit message more detailed.
>
> + case PHY_INTERFACE_MODE_MIILITE:
> + link_caps |= BIT(LINK_CAPA_10FD) | BIT(LINK_CAPA_100FD);
> + break;
> +
You could call this out in the commit message.
> * Describes the interface between the MAC and PHY.
> @@ -150,6 +151,7 @@ typedef enum {
> PHY_INTERFACE_MODE_50GBASER,
> PHY_INTERFACE_MODE_LAUI,
> PHY_INTERFACE_MODE_100GBASEP,
> + PHY_INTERFACE_MODE_MIILITE,
> PHY_INTERFACE_MODE_MAX,
> } phy_interface_t;
This enum is not part of the ABI. So you can insert MIILITE directly
after MII.
Andrew
next prev parent reply other threads:[~2025-06-25 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 16:34 [PATCH net-next v3 0/3] net: phy: bcm54811: Fix the PHY initialization Kamil Horák - 2N
2025-06-25 16:34 ` [PATCH net-next v3 1/3] net: phy: MII-Lite PHY interface mode Kamil Horák - 2N
2025-06-25 16:48 ` Andrew Lunn [this message]
2025-06-25 16:34 ` [PATCH net-next v3 2/3] dt-bindings: ethernet-phy: add MII-Lite phy interface type Kamil Horák - 2N
2025-06-25 16:34 ` [PATCH net-next v3 3/3] net: phy: bcm54811: Fix the PHY initialization Kamil Horák - 2N
2025-06-25 16:49 ` Andrew Lunn
2025-06-26 11:16 [PATCH net-next v3 0/3] " Kamil Horák - 2N
2025-06-26 11:16 ` [PATCH net-next v3 1/3] net: phy: MII-Lite PHY interface mode Kamil Horák - 2N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fab0b3e5-9860-43c2-8c02-70d855b598a1@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kamilh@axis.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®