From: Timur Tabi <ttabi@nvidia.com>
To: Alexandre Courbot <acourbot@nvidia.com>,
"dakr@kernel.org" <dakr@kernel.org>,
John Hubbard <jhubbard@nvidia.com>
Cc: "lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"boqun.feng@gmail.com" <boqun.feng@gmail.com>,
Zhi Wang <zhiw@nvidia.com>, "simona@ffwll.ch" <simona@ffwll.ch>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"alex.gaynor@gmail.com" <alex.gaynor@gmail.com>,
"nova-gpu@lists.linux.dev" <nova-gpu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
Eliot Courtney <ecourtney@nvidia.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"gary@garyguo.net" <gary@garyguo.net>,
Alistair Popple <apopple@nvidia.com>
Subject: Re: [PATCH v3 27/33] gpu: nova-core: switch to the r000 GSP firmware
Date: Thu, 1 Oct 2026 20:39:42 +0000 [thread overview]
Message-ID: <facca1b8335c9ee718fb6e03d477c46e9e0ffb05.camel@nvidia.com> (raw)
In-Reply-To: <7ea2771e-e2de-487c-aebb-317d4cffaf2a@nvidia.com>
On Mon, 2026-09-21 at 19:44 -0700, John Hubbard wrote:
> On 9/18/26 3:48 PM, Timur Tabi wrote:
> > On Thu, 2026-09-17 at 18:07 -0700, John Hubbard wrote:
> > >
> > > --- a/drivers/gpu/nova-core/fb/hal/gb100.rs
> > > +++ b/drivers/gpu/nova-core/fb/hal/gb100.rs
> > > @@ -79,10 +79,28 @@ fn write_sysmem_flush_page_gb100(hshub0: Mmio<'_, regs::Hshub0Registers>, addr:
> > > hshub0.write_reg(regs::NV_PFB_HSHUB_EG_PCIE_FLUSH_SYSMEM_ADDR_LO::zeroed().with_adr(addr_lo));
> > > }
> > >
> > > -// This PMU reservation size is r570-specific.
> > > +/// PMU backing store.
> > > +const PMU_BACKING_STORE_SIZE: usize = 9 * SZ_1M;
> >
> > I don't see this comment or value removed/changed in this patchset, so is it really 570-
> > specific?
>
> Yes, it was r570-specific, and this patch is where it changes: the
> hunk removes the comment and replaces the value.
>
> In 570.144 the PMU region is:
>
> * 8 MiB of backing store
> * 16 MiB of surfaces
> * 4 KiB of miscellaneous memory
> * all aligned to 128 KiB.
>
> In 615.71.09 the backing store is 9 MiB and the surfaces are 16 MiB + 256 KiB.
On 615, the backing store is 0x950000, not 9 MiB:
NvU32
kpmuReservedMemoryBackingStoreSizeGet_IMPL
(
KernelPmu *pKernelPmu
)
{
if (kpmuGetIsSelfInit(pKernelPmu))
{
//
// MMINTS-TODO: cross-reference with this when reserving memory
// in pmu_20.c
//
return 0x950000;
}
if (kpmuGetIsSelfInit(pKernelPmu))
{
//
// MMINTS-TODO: cross-reference with this when reserving memory
// in pmu_20.c
//
return 0x900000;
}
return 0U;
}
kpmuGetIsSelfInit() returns True on GB100 and later, and False otherwise. The second if-
statement is never entered, because this is just some #ifdef weirdness when OpenRM was
generated.
next prev parent reply other threads:[~2026-10-01 20:39 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 1:06 [PATCH v3 00/33] gpu: nova-core: boot on " John Hubbard
2026-09-18 1:06 ` [PATCH v3 01/33] rust: pci: add domain_nr() accessor John Hubbard
2026-09-18 1:06 ` [PATCH v3 02/33] gpu: nova-core: set MCTP transport header version to 1 John Hubbard
2026-09-22 13:23 ` Alexandre Courbot
2026-09-18 1:06 ` [PATCH v3 03/33] gpu: nova-core: gsp: give the command queue its own BAR0 mapping John Hubbard
2026-09-22 13:24 ` Alexandre Courbot
2026-09-18 1:06 ` [PATCH v3 04/33] gpu: nova-core: firmware: add r000 bindings John Hubbard
2026-09-18 17:42 ` Timur Tabi
2026-09-22 1:51 ` John Hubbard
2026-09-23 1:34 ` John Hubbard
2026-09-18 1:06 ` [PATCH v3 05/33] gpu: nova-core: regs: add msgq v2 BAR0 register declarations John Hubbard
2026-09-23 12:20 ` Alexandre Courbot
2026-09-18 1:06 ` [PATCH v3 06/33] gpu: nova-core: gsp: ring the GSP doorbell from the queue memory John Hubbard
2026-09-18 1:06 ` [PATCH v3 07/33] gpu: nova-core: gsp: make command allocation generic over the header John Hubbard
2026-09-18 1:06 ` [PATCH v3 08/33] gpu: nova-core: gsp: compute the queue regions from a count and a slot John Hubbard
2026-09-23 4:55 ` Alexandre Courbot
2026-09-23 11:30 ` Gary Guo
2026-09-23 13:20 ` Alexandre Courbot
2026-09-23 16:47 ` Gary Guo
2026-09-23 20:36 ` John Hubbard
2026-09-18 1:06 ` [PATCH v3 09/33] gpu: nova-core: add GMC API message types John Hubbard
2026-09-18 21:45 ` Timur Tabi
2026-09-22 2:18 ` John Hubbard
2026-09-23 11:18 ` Alexandre Courbot
2026-09-18 1:06 ` [PATCH v3 10/33] gpu: nova-core: add GMC send path John Hubbard
2026-09-23 14:12 ` Alexandre Courbot
2026-09-18 1:06 ` [PATCH v3 11/33] gpu: nova-core: add GMC transport receive path John Hubbard
2026-09-18 21:57 ` Timur Tabi
2026-09-22 2:28 ` John Hubbard
2026-09-18 1:06 ` [PATCH v3 12/33] gpu: nova-core: gsp: add GMC dispatch on receive John Hubbard
2026-09-18 22:01 ` Timur Tabi
2026-09-22 2:50 ` John Hubbard
2026-09-22 20:11 ` Timur Tabi
2026-09-18 1:06 ` [PATCH v3 13/33] gpu: nova-core: separate the generic falcon bootloader from FWSEC John Hubbard
2026-09-18 22:04 ` Timur Tabi
2026-09-22 2:39 ` John Hubbard
2026-09-28 12:06 ` Alexandre Courbot
2026-09-18 1:07 ` [PATCH v3 14/33] gpu: nova-core: add the falcon DMA and suspend helpers for r000 boot John Hubbard
2026-09-18 22:07 ` Timur Tabi
2026-09-22 2:39 ` John Hubbard
2026-09-28 14:02 ` Alexandre Courbot
2026-09-18 1:07 ` [PATCH v3 15/33] gpu: nova-core: add the r000 load-and-execute HS binary handler John Hubbard
2026-09-18 1:07 ` [PATCH v3 16/33] gpu: nova-core: move the bootloader DMEM descriptor out of FWSEC John Hubbard
2026-09-28 12:37 ` Alexandre Courbot
2026-09-18 1:07 ` [PATCH v3 17/33] gpu: nova-core: add the r000 load-and-execute bootloader handler John Hubbard
2026-09-18 3:32 ` Timur Tabi
2026-09-22 2:05 ` John Hubbard
2026-09-28 14:51 ` Alexandre Courbot
2026-09-18 1:07 ` [PATCH v3 18/33] gpu: nova-core: gsp: add the GMC boot event dispatcher John Hubbard
2026-09-18 1:07 ` [PATCH v3 19/33] gpu: nova-core: gsp: rename the static configuration type John Hubbard
2026-09-18 1:07 ` [PATCH v3 20/33] gpu: nova-core: gsp: return the static GPU configuration from boot John Hubbard
2026-09-18 1:07 ` [PATCH v3 21/33] gpu: nova-core: gsp: add the GSP_INIT request builder John Hubbard
2026-09-18 22:26 ` Timur Tabi
2026-09-22 2:42 ` John Hubbard
2026-09-22 20:05 ` Timur Tabi
2026-09-23 1:51 ` Alexandre Courbot
2026-09-18 1:07 ` [PATCH v3 22/33] gpu: nova-core: gsp: send GSP_INIT and decode its reply John Hubbard
2026-09-18 1:07 ` [PATCH v3 23/33] gpu: nova-core: add LIBOS3 log buffers and state monitor buffer John Hubbard
2026-09-18 22:34 ` Timur Tabi
2026-09-22 2:34 ` John Hubbard
2026-09-18 1:07 ` [PATCH v3 24/33] gpu: nova-core: add the ucodes firmware loader John Hubbard
2026-09-18 1:07 ` [PATCH v3 25/33] gpu: nova-core: gsp: let the GSP HAL load the generic bootloader John Hubbard
2026-09-18 1:07 ` [PATCH v3 26/33] gpu: nova-core: gsp: add the GSP_SUSPEND request John Hubbard
2026-09-18 1:07 ` [PATCH v3 27/33] gpu: nova-core: switch to the r000 GSP firmware John Hubbard
2026-09-18 22:48 ` Timur Tabi
2026-09-22 2:44 ` John Hubbard
2026-10-01 20:39 ` Timur Tabi [this message]
2026-09-18 1:07 ` [PATCH v3 28/33] gpu: nova-core: gsp: make the GSP_INIT reply the static configuration John Hubbard
2026-09-18 1:07 ` [PATCH v3 29/33] gpu: nova-core: firmware: delete the r570 bindings John Hubbard
2026-09-18 1:07 ` [PATCH v3 30/33] gpu: nova-core: match GSP RPC replies by sequence, not just function John Hubbard
2026-09-23 14:20 ` Alexandre Courbot
2026-09-18 1:07 ` [PATCH v3 31/33] gpu: nova-core: gsp: split the reply match out of the RPC receive path John Hubbard
2026-09-18 1:07 ` [PATCH v3 32/33] gpu: nova-core: gsp: decode queue elements by their NVDM type John Hubbard
2026-09-18 1:07 ` [PATCH v3 33/33] gpu: nova-core: gsp: match a GMC response by flag, id and sequence John Hubbard
2026-09-23 14:10 ` Alexandre Courbot
2026-09-18 23:08 ` [PATCH v3 00/33] gpu: nova-core: boot on the r000 GSP firmware Timur Tabi
2026-09-22 2:45 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=facca1b8335c9ee718fb6e03d477c46e9e0ffb05.camel@nvidia.com \
--to=ttabi@nvidia.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apopple@nvidia.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=ecourtney@nvidia.com \
--cc=gary@garyguo.net \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=nova-gpu@lists.linux.dev \
--cc=ojeda@kernel.org \
--cc=simona@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®