From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>,
mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, hverkuil@xs4all.nl,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com
Cc: hansg@kernel.org, mehdi.djait@linux.intel.com,
ribalda@chromium.org, git@apitzsch.eu,
vladimir.zapolskiy@linaro.org, benjamin.mugnier@foss.st.com,
dongcheng.yan@intel.com, u-kumar1@ti.com, jai.luthra@linux.dev,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 2/4] media: i2c: ds90ub960: Use enums for chip type and chip family
Date: Mon, 22 Dec 2025 12:46:03 +0200 [thread overview]
Message-ID: <fb0b0f13-0d0b-47f9-b8df-5e5551a61d1b@ideasonboard.com> (raw)
In-Reply-To: <20251219122955.2078270-3-y-abhilashchandra@ti.com>
Hi,
On 19/12/2025 14:29, Yemike Abhilash Chandra wrote:
> Replace chip-specific boolean flags with chip_type and chip_family enums.
> This simplifies the process of adding support for newer devices and also
> improves code readability.
>
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> Changelog:
> Changes in v3:
> - Change conditional checks to check for applicable chips over negated checks. (Tomi)
> - Keep the model name in the ub960_hw_data structure and remove the switch-case from the probe function. (Tomi)
>
> drivers/media/i2c/ds90ub960.c | 38 +++++++++++++++++++++++------------
> 1 file changed, 25 insertions(+), 13 deletions(-)
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
next prev parent reply other threads:[~2025-12-22 10:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 12:29 [PATCH V3 0/4] Add support for DS90UB954-Q1 Yemike Abhilash Chandra
2025-12-19 12:29 ` [PATCH V3 1/4] media: dt-bindings: ti,ds90ub960: Refactor port definitions Yemike Abhilash Chandra
2025-12-22 10:55 ` Tomi Valkeinen
2025-12-29 23:54 ` Rob Herring (Arm)
2025-12-19 12:29 ` [PATCH V3 2/4] media: i2c: ds90ub960: Use enums for chip type and chip family Yemike Abhilash Chandra
2025-12-22 10:46 ` Tomi Valkeinen [this message]
2026-01-06 11:26 ` Jai Luthra
2025-12-19 12:29 ` [PATCH V3 3/4] media: dt-bindings: ti,ds90ub960: Add support for DS90UB954-Q1 Yemike Abhilash Chandra
2025-12-22 11:29 ` Tomi Valkeinen
2026-01-06 10:06 ` Yemike Abhilash Chandra
2026-01-23 9:54 ` Tomi Valkeinen
2025-12-29 23:58 ` Rob Herring (Arm)
2025-12-19 12:29 ` [PATCH V3 4/4] media: i2c: ds90ub960: " Yemike Abhilash Chandra
2025-12-22 10:46 ` Tomi Valkeinen
2026-01-06 11:34 ` Jai Luthra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb0b0f13-0d0b-47f9-b8df-5e5551a61d1b@ideasonboard.com \
--to=tomi.valkeinen@ideasonboard.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongcheng.yan@intel.com \
--cc=git@apitzsch.eu \
--cc=hansg@kernel.org \
--cc=hverkuil@xs4all.nl \
--cc=jai.luthra@linux.dev \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=ribalda@chromium.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=u-kumar1@ti.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=y-abhilashchandra@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®