Re: [PATCH net-next v2] net: mctp: Make KUnit tests depend on flow support

[Jeremy Kerr <jk@codeconstruct.com.au>]

Hi Karl,

> MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no
> transport requires them. Enabling tests should not silently enable
> additional kernel functionality.
> 
> Make the tests depend on MCTP_FLOWS instead, following the dependency
> rule in Documentation/dev-tools/kunit/style.rst.

[...]

> index d8d3413a37f7..e64d4f7ef6aa 100644
> --- a/net/mctp/Kconfig
> +++ b/net/mctp/Kconfig
> @@ -14,7 +14,7 @@ menuconfig MCTP
>  
>  config MCTP_TEST
>          bool "MCTP core tests" if !KUNIT_ALL_TESTS
> -        select MCTP_FLOWS
> +        depends on MCTP_FLOWS
>          depends on MCTP=y && KUNIT=y
>          default KUNIT_ALL_TESTS
>  

Now _the whole suite_ is not going to get enabled for the usual kunit
testing, since flows isn't individually selectable.

> This keeps the full flow-test coverage: the suite is available only
> when flow support is enabled, for example by the I2C transport.

Hardware transports are typically not enabled for kunit test kernels.

Are you attempting to fix an actual problem you're encountering? What's
the aim with this change?

Cheers,


Jeremy