[PATCH] ASoC: Intel: catpt: remove unneeded semicolon

[PATCH] ASoC: Intel: catpt: remove unneeded semicolon

[Yang Li]

Eliminate the following coccicheck warning:
./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 sound/soc/intel/catpt/pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
index e5d54bb..88a0879 100644
--- a/sound/soc/intel/catpt/pcm.c
+++ b/sound/soc/intel/catpt/pcm.c
@@ -352,7 +352,7 @@ static int catpt_dai_apply_usettings(struct snd_soc_dai *dai,
 		break;
 	default:
 		return 0;
-	};
+	}
 
 	list_for_each_entry(pos, &component->card->snd_card->controls, list) {
 		if (pos->private_data == component &&
-- 
1.8.3.1

Re: [PATCH] ASoC: Intel: catpt: remove unneeded semicolon

[Cezary Rojewski]

On 2021-02-01 9:01 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   sound/soc/intel/catpt/pcm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
> index e5d54bb..88a0879 100644
> --- a/sound/soc/intel/catpt/pcm.c
> +++ b/sound/soc/intel/catpt/pcm.c
> @@ -352,7 +352,7 @@ static int catpt_dai_apply_usettings(struct snd_soc_dai *dai,
>   		break;
>   	default:
>   		return 0;
> -	};
> +	}
>   
>   	list_for_each_entry(pos, &component->card->snd_card->controls, list) {
>   		if (pos->private_data == component &&
> 

Hello Yang,

Your patch is much appreciated.

I noticed that more mistakes such as this have been made in the code. 
Could you please also update switch-statements in other parts of catpt 
(from what I've found, pcm.c has 2 occurrences while loader.c has 1)?

Regards,
Czarek

Re: [PATCH] ASoC: Intel: catpt: remove unneeded semicolon

[Cezary Rojewski]

On 2021-02-01 10:03 PM, Cezary Rojewski wrote:
> On 2021-02-01 9:01 AM, Yang Li wrote:
>> Eliminate the following coccicheck warning:
>> ./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon
>>
>> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>> ---
>>   sound/soc/intel/catpt/pcm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
>> index e5d54bb..88a0879 100644
>> --- a/sound/soc/intel/catpt/pcm.c
>> +++ b/sound/soc/intel/catpt/pcm.c
>> @@ -352,7 +352,7 @@ static int catpt_dai_apply_usettings(struct 
>> snd_soc_dai *dai,
>>           break;
>>       default:
>>           return 0;
>> -    };
>> +    }
>>       list_for_each_entry(pos, &component->card->snd_card->controls, 
>> list) {
>>           if (pos->private_data == component &&
>>
> 
> Hello Yang,
> 
> Your patch is much appreciated.
> 
> I noticed that more mistakes such as this have been made in the code. 
> Could you please also update switch-statements in other parts of catpt 
> (from what I've found, pcm.c has 2 occurrences while loader.c has 1)?
> 

I see now. Patch [1] provided the fixes already but optimization of mine 
[2] done later, overridden part of it. In that case, there's nothing 
else to be done.

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

Regards,
Czarek


[1]: https://lore.kernel.org/r/20201101171943.2305030-1-trix@redhat.com
[2]: 
https://lore.kernel.org/r/20201116133332.8530-4-cezary.rojewski@intel.com

Re: [PATCH] ASoC: Intel: catpt: remove unneeded semicolon

[Mark Brown]

On Mon, 1 Feb 2021 16:01:21 +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: catpt: remove unneeded semicolon
      commit: e01a03db74a88084fb91a4ff18bb8d47a1e12f62

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark