mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Harry Wentland <hwentlan@amd.com>
To: YueHaibing <yuehaibing@huawei.com>,
	"Wentland, Harry" <Harry.Wentland@amd.com>,
	"Li, Sun peng (Leo)" <Sunpeng.Li@amd.com>,
	"Deucher, Alexander" <Alexander.Deucher@amd.com>,
	"Koenig, Christian" <Christian.Koenig@amd.com>,
	"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
	"airlied@linux.ie" <airlied@linux.ie>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>,
	"Lakha, Bhawanpreet" <Bhawanpreet.Lakha@amd.com>,
	"Koo, Anthony" <Anthony.Koo@amd.com>,
	"Othman, Ahmad" <Ahmad.Othman@amd.com>,
	"Bernstein, Eric" <Eric.Bernstein@amd.com>,
	"Cyr, Aric" <Aric.Cyr@amd.com>,
	"alvin.lee3@amd.com" <alvin.lee3@amd.com>,
	"Tatla, Harmanprit" <Harmanprit.Tatla@amd.com>
Cc: "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask
Date: Tue, 27 Aug 2019 14:01:24 +0000	[thread overview]
Message-ID: <fb49a1d9-8405-4f88-6f9a-af863bd0f657@amd.com> (raw)
In-Reply-To: <20190827070925.16080-1-yuehaibing@huawei.com>

On 2019-08-27 3:09 a.m., YueHaibing wrote:
> After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> there is no caller in tree.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  .../drm/amd/display/modules/info_packet/info_packet.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> index 5f4b98d..d885d64 100644
> --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
>  	ColorimetryYCC_DP_ITU2020YCbCr  = 7,
>  };
>  
> -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value)
> -{
> -	unsigned int shift = 0;
> -
> -	if (!mask || !dest)
> -		return;
> -
> -	while (!((mask >> shift) & 1))
> -		shift++;
> -
> -	//reset
> -	*dest = *dest & ~mask;
> -	//set
> -	//dont let value span past mask
> -	value = value & (mask >> shift);
> -	//insert value
> -	*dest = *dest | (value << shift);
> -}
> -
>  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
>  		struct dc_info_packet *info_packet)
>  {
> 

  reply	other threads:[~2019-08-27 14:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27  7:09 YueHaibing
2019-08-27 14:01 ` Harry Wentland [this message]
2019-08-27 14:20   ` Alex Deucher
2019-08-27 15:09     ` Othman, Ahmad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb49a1d9-8405-4f88-6f9a-af863bd0f657@amd.com \
    --to=hwentlan@amd.com \
    --cc=Ahmad.Othman@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Anthony.Koo@amd.com \
    --cc=Aric.Cyr@amd.com \
    --cc=Bhawanpreet.Lakha@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=Eric.Bernstein@amd.com \
    --cc=Harmanprit.Tatla@amd.com \
    --cc=Harry.Wentland@amd.com \
    --cc=Sunpeng.Li@amd.com \
    --cc=airlied@linux.ie \
    --cc=alvin.lee3@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®