[PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask
@ 2019-08-27  7:09 YueHaibing
  2019-08-27 14:01 ` Harry Wentland
  0 siblings, 1 reply; 4+ messages in thread
From: YueHaibing @ 2019-08-27  7:09 UTC (permalink / raw)
  To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
	David1.Zhou, airlied, daniel, Bhawanpreet.Lakha, Anthony.Koo,
	ahmad.othman, eric.bernstein, yuehaibing, aric.cyr, alvin.lee3,
	Harmanprit.Tatla
  Cc: amd-gfx, dri-devel, linux-kernel

After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
there is no caller in tree.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 .../drm/amd/display/modules/info_packet/info_packet.c | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
index 5f4b98d..d885d64 100644
--- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
+++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
@@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
 	ColorimetryYCC_DP_ITU2020YCbCr  = 7,
 };
 
-void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value)
-{
-	unsigned int shift = 0;
-
-	if (!mask || !dest)
-		return;
-
-	while (!((mask >> shift) & 1))
-		shift++;
-
-	//reset
-	*dest = *dest & ~mask;
-	//set
-	//dont let value span past mask
-	value = value & (mask >> shift);
-	//insert value
-	*dest = *dest | (value << shift);
-}
-
 void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
 		struct dc_info_packet *info_packet)
 {
-- 
2.7.4



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask
  2019-08-27  7:09 [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask YueHaibing
@ 2019-08-27 14:01 ` Harry Wentland
  2019-08-27 14:20   ` Alex Deucher
  0 siblings, 1 reply; 4+ messages in thread
From: Harry Wentland @ 2019-08-27 14:01 UTC (permalink / raw)
  To: YueHaibing, Wentland, Harry, Li, Sun peng (Leo),
	Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing),
	airlied, daniel, Lakha, Bhawanpreet, Koo, Anthony, Othman, Ahmad,
	Bernstein, Eric, Cyr, Aric, alvin.lee3, Tatla, Harmanprit
  Cc: amd-gfx, dri-devel, linux-kernel

On 2019-08-27 3:09 a.m., YueHaibing wrote:
> After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> there is no caller in tree.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  .../drm/amd/display/modules/info_packet/info_packet.c | 19 -------------------
>  1 file changed, 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> index 5f4b98d..d885d64 100644
> --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
>  	ColorimetryYCC_DP_ITU2020YCbCr  = 7,
>  };
>  
> -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value)
> -{
> -	unsigned int shift = 0;
> -
> -	if (!mask || !dest)
> -		return;
> -
> -	while (!((mask >> shift) & 1))
> -		shift++;
> -
> -	//reset
> -	*dest = *dest & ~mask;
> -	//set
> -	//dont let value span past mask
> -	value = value & (mask >> shift);
> -	//insert value
> -	*dest = *dest | (value << shift);
> -}
> -
>  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
>  		struct dc_info_packet *info_packet)
>  {
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask
  2019-08-27 14:01 ` Harry Wentland
@ 2019-08-27 14:20   ` Alex Deucher
  2019-08-27 15:09     ` Othman, Ahmad
  0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2019-08-27 14:20 UTC (permalink / raw)
  To: Harry Wentland
  Cc: YueHaibing, Wentland, Harry, Li, Sun peng (Leo),
	Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing),
	airlied, daniel, Lakha, Bhawanpreet, Koo, Anthony, Othman, Ahmad,
	Bernstein, Eric, Cyr, Aric, alvin.lee3, Tatla, Harmanprit,
	dri-devel, amd-gfx, linux-kernel

On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2019-08-27 3:09 a.m., YueHaibing wrote:
> > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"),
> > there is no caller in tree.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>

Applied.  Thanks!

Alex

> Harry
>
> > ---
> >  .../drm/amd/display/modules/info_packet/info_packet.c | 19 -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > index 5f4b98d..d885d64 100644
> > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> >       ColorimetryYCC_DP_ITU2020YCbCr  = 7,
> >  };
> >
> > -void setFieldWithMask(unsigned char *dest, unsigned int mask, unsigned int value)
> > -{
> > -     unsigned int shift = 0;
> > -
> > -     if (!mask || !dest)
> > -             return;
> > -
> > -     while (!((mask >> shift) & 1))
> > -             shift++;
> > -
> > -     //reset
> > -     *dest = *dest & ~mask;
> > -     //set
> > -     //dont let value span past mask
> > -     value = value & (mask >> shift);
> > -     //insert value
> > -     *dest = *dest | (value << shift);
> > -}
> > -
> >  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> >               struct dc_info_packet *info_packet)
> >  {
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask
  2019-08-27 14:20   ` Alex Deucher
@ 2019-08-27 15:09     ` Othman, Ahmad
  0 siblings, 0 replies; 4+ messages in thread
From: Othman, Ahmad @ 2019-08-27 15:09 UTC (permalink / raw)
  To: Alex Deucher, Wentland, Harry
  Cc: YueHaibing, Wentland, Harry, Li, Sun peng (Leo),
	Deucher, Alexander, Koenig, Christian, Zhou, David(ChunMing),
	airlied, daniel, Lakha, Bhawanpreet, Koo, Anthony, Bernstein,
	Eric, Cyr, Aric, alvin.lee3, Tatla, Harmanprit, dri-devel,
	amd-gfx, linux-kernel

Hi Alex,

There are callers in the same file "info_packet.c" 

-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com> 
Sent: August 27, 2019 10:20
To: Wentland, Harry <Harry.Wentland@amd.com>
Cc: YueHaibing <yuehaibing@huawei.com>; Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; airlied@linux.ie; daniel@ffwll.ch; Lakha, Bhawanpreet <Bhawanpreet.Lakha@amd.com>; Koo, Anthony <Anthony.Koo@amd.com>; Othman, Ahmad <Ahmad.Othman@amd.com>; Bernstein, Eric <Eric.Bernstein@amd.com>; Cyr, Aric <Aric.Cyr@amd.com>; alvin.lee3@amd.com; Tatla, Harmanprit <Harmanprit.Tatla@amd.com>; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask

On Tue, Aug 27, 2019 at 10:01 AM Harry Wentland <hwentlan@amd.com> wrote:
>
> On 2019-08-27 3:09 a.m., YueHaibing wrote:
> > After commit a9f54ce3c603 ("drm/amd/display: Refactoring VTEM"), 
> > there is no caller in tree.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: 
> > YueHaibing <yuehaibing@huawei.com>
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>

Applied.  Thanks!

Alex

> Harry
>
> > ---
> >  .../drm/amd/display/modules/info_packet/info_packet.c | 19 
> > -------------------
> >  1 file changed, 19 deletions(-)
> >
> > diff --git 
> > a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c 
> > b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > index 5f4b98d..d885d64 100644
> > --- a/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > +++ b/drivers/gpu/drm/amd/display/modules/info_packet/info_packet.c
> > @@ -114,25 +114,6 @@ enum ColorimetryYCCDP {
> >       ColorimetryYCC_DP_ITU2020YCbCr  = 7,  };
> >
> > -void setFieldWithMask(unsigned char *dest, unsigned int mask, 
> > unsigned int value) -{
> > -     unsigned int shift = 0;
> > -
> > -     if (!mask || !dest)
> > -             return;
> > -
> > -     while (!((mask >> shift) & 1))
> > -             shift++;
> > -
> > -     //reset
> > -     *dest = *dest & ~mask;
> > -     //set
> > -     //dont let value span past mask
> > -     value = value & (mask >> shift);
> > -     //insert value
> > -     *dest = *dest | (value << shift);
> > -}
> > -
> >  void mod_build_vsc_infopacket(const struct dc_stream_state *stream,
> >               struct dc_info_packet *info_packet)  {
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-08-27 15:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27  7:09 [PATCH 2/3] drm/amd/display: remove unused function setFieldWithMask YueHaibing
2019-08-27 14:01 ` Harry Wentland
2019-08-27 14:20   ` Alex Deucher
2019-08-27 15:09     ` Othman, Ahmad

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®