mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: pd_mapper: Add SM7225 compatible
Date: Fri, 20 Dec 2024 14:20:04 +0100	[thread overview]
Message-ID: <fb4ddc73-545c-48b6-aefd-fdc83005ec07@oss.qualcomm.com> (raw)
In-Reply-To: <D6GG70FQ29ZB.PEJZ4TE4HWQV@fairphone.com>

On 20.12.2024 11:15 AM, Luca Weiss wrote:
> On Fri Dec 20, 2024 at 10:39 AM CET, Konrad Dybcio wrote:
>> On 20.12.2024 9:39 AM, Luca Weiss wrote:
>>> The Qualcomm SM7225 is practically identical to SM6350, so add an entry
>>> using that data.
>>>
>>> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
>>> ---
>>
>> I think we should instead add the fallback compatible, like
>>
>> - enum:
>>       - asdf,asdf
>> - const: qcom,sm7225
>> - const: qcom,sm6350
>>
>> as we've done for speedbin/rename variants of SoCs lately, with separate
>> entries being added for "actually different" sillicon.
> 
> We also have currently for example sm7325=sc7280=qcm6490, would that
> fall into this category as well for you, or are they more different?
> 
> But do you think it's worth trying to also change existing platforms
> like that? We also have basically the same list in
> drivers/cpufreq/cpufreq-dt-platdev.c where we have both sm6350 and
> sm7225 right now.

Hm, with existing boards, I guess that's a question for dt-bindings folks

Konrad

  reply	other threads:[~2024-12-20 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20  8:39 Luca Weiss
2024-12-20  9:39 ` Konrad Dybcio
2024-12-20 10:15   ` Luca Weiss
2024-12-20 13:20     ` Konrad Dybcio [this message]
2025-01-08 22:51 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fb4ddc73-545c-48b6-aefd-fdc83005ec07@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konradybcio@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.weiss@fairphone.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®