* [PATCH 1/3] x86: apuv2: remove unused variable
@ 2019-03-04 20:09 Arnd Bergmann
2019-03-08 9:11 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2019-03-04 20:09 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult, Darren Hart, Andy Shevchenko
Cc: Arnd Bergmann, Linus Walleij, platform-driver-x86, linux-kernel
The driver was newly introduced but the version that got merged
produces a harmless compiler warning:
drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init':
drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable]
Remove the evidently useless variable.
Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/pcengines-apuv2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index dcb084f6b892..c1ca931e1fab 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev(
static int __init apu_board_init(void)
{
- int rc;
const struct dmi_system_id *id;
id = dmi_first_match(apu_gpio_dmi_table);
--
2.20.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] x86: apuv2: remove unused variable
2019-03-04 20:09 [PATCH 1/3] x86: apuv2: remove unused variable Arnd Bergmann
@ 2019-03-08 9:11 ` Linus Walleij
2019-03-08 10:42 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 7+ messages in thread
From: Linus Walleij @ 2019-03-08 9:11 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Enrico Weigelt, metux IT consult, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel
On Mon, Mar 4, 2019 at 9:09 PM Arnd Bergmann <arnd@arndb.de> wrote:
> The driver was newly introduced but the version that got merged
> produces a harmless compiler warning:
>
> drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init':
> drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable]
>
> Remove the evidently useless variable.
>
> Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
As Torvalds did not yet pull the GPIO tree (maybe because of this
and other bugs, who knows) I applied this to my GPIO tree for
now.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] x86: apuv2: remove unused variable
2019-03-08 9:11 ` Linus Walleij
@ 2019-03-08 10:42 ` Enrico Weigelt, metux IT consult
2019-03-08 12:14 ` Linus Walleij
0 siblings, 1 reply; 7+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-08 10:42 UTC (permalink / raw)
To: Linus Walleij, Arnd Bergmann
Cc: Enrico Weigelt, metux IT consult, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel
On 08.03.19 10:11, Linus Walleij wrote:
> As Torvalds did not yet pull the GPIO tree (maybe because of this
> and other bugs, who knows) I applied this to my GPIO tree for
> now.
Great. I actually like it better this way, so his pull will be clean
and consistent.
Did you also apply the kconfig fixes ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] x86: apuv2: remove unused variable
2019-03-08 10:42 ` Enrico Weigelt, metux IT consult
@ 2019-03-08 12:14 ` Linus Walleij
0 siblings, 0 replies; 7+ messages in thread
From: Linus Walleij @ 2019-03-08 12:14 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Arnd Bergmann, Enrico Weigelt, metux IT consult, Darren Hart,
Andy Shevchenko, platform-driver-x86, linux-kernel
On Fri, Mar 8, 2019 at 11:42 AM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
> On 08.03.19 10:11, Linus Walleij wrote:
>
> > As Torvalds did not yet pull the GPIO tree (maybe because of this
> > and other bugs, who knows) I applied this to my GPIO tree for
> > now.
>
> Great. I actually like it better this way, so his pull will be clean
> and consistent.
>
> Did you also apply the kconfig fixes ?
Yep!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/3] x86: apuv2: remove unused variable
@ 2019-03-04 20:19 Arnd Bergmann
2019-03-05 0:04 ` Enrico Weigelt, metux IT consult
0 siblings, 1 reply; 7+ messages in thread
From: Arnd Bergmann @ 2019-03-04 20:19 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult, Darren Hart, Andy Shevchenko
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, Arnd Bergmann,
Linus Walleij, platform-driver-x86, linux-kernel
The driver was newly introduced but the version that got merged
produces a harmless compiler warning:
drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init':
drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable]
Remove the evidently useless variable.
Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/platform/x86/pcengines-apuv2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
index dcb084f6b892..c1ca931e1fab 100644
--- a/drivers/platform/x86/pcengines-apuv2.c
+++ b/drivers/platform/x86/pcengines-apuv2.c
@@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev(
static int __init apu_board_init(void)
{
- int rc;
const struct dmi_system_id *id;
id = dmi_first_match(apu_gpio_dmi_table);
--
2.20.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] x86: apuv2: remove unused variable
2019-03-04 20:19 Arnd Bergmann
@ 2019-03-05 0:04 ` Enrico Weigelt, metux IT consult
2019-03-05 13:47 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2019-03-05 0:04 UTC (permalink / raw)
To: Arnd Bergmann, Enrico Weigelt, metux IT consult, Darren Hart,
Andy Shevchenko
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, Linus Walleij,
platform-driver-x86, linux-kernel
On 04.03.19 21:19, Arnd Bergmann wrote:
> diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> index dcb084f6b892..c1ca931e1fab 100644
> --- a/drivers/platform/x86/pcengines-apuv2.c
> +++ b/drivers/platform/x86/pcengines-apuv2.c
> @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev(
>
> static int __init apu_board_init(void)
> {
> - int rc;
> const struct dmi_system_id *id;
>
> id = dmi_first_match(apu_gpio_dmi_table);
>
ACK.
Reviewed-By: Enrico Weigelt, metux IT consult <info@metux.net>
thx
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/3] x86: apuv2: remove unused variable
2019-03-05 0:04 ` Enrico Weigelt, metux IT consult
@ 2019-03-05 13:47 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2019-03-05 13:47 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: Arnd Bergmann, Enrico Weigelt, metux IT consult, Darren Hart,
Andy Shevchenko, Linus Walleij, open list:GPIO SUBSYSTEM,
Linus Walleij, Platform Driver, Linux Kernel Mailing List
On Tue, Mar 5, 2019 at 2:04 AM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 04.03.19 21:19, Arnd Bergmann wrote:
>
> > diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c
> > index dcb084f6b892..c1ca931e1fab 100644
> > --- a/drivers/platform/x86/pcengines-apuv2.c
> > +++ b/drivers/platform/x86/pcengines-apuv2.c
> > @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev(
> >
> > static int __init apu_board_init(void)
> > {
> > - int rc;
> > const struct dmi_system_id *id;
> >
> > id = dmi_first_match(apu_gpio_dmi_table);
> >
>
> ACK.
>
> Reviewed-By: Enrico Weigelt, metux IT consult <info@metux.net>
Patches from here presumably should go to v5.1-rc1 or, if Linus would
do it, through his tree.
Linus, I'm fine with what Randy and Arnd sent for fixing this driver.
>
>
> thx
> --mtx
>
> --
> Enrico Weigelt, metux IT consult
> Free software and Linux embedded engineering
> info@metux.net -- +49-151-27565287
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-03-08 12:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-04 20:09 [PATCH 1/3] x86: apuv2: remove unused variable Arnd Bergmann
2019-03-08 9:11 ` Linus Walleij
2019-03-08 10:42 ` Enrico Weigelt, metux IT consult
2019-03-08 12:14 ` Linus Walleij
2019-03-04 20:19 Arnd Bergmann
2019-03-05 0:04 ` Enrico Weigelt, metux IT consult
2019-03-05 13:47 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®