From: David Heidelberg <david@ixit.cz>
To: Andrew Lunn <andrew@lunn.ch>, Coia Prant <coiaprant@gmail.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 3/3] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port
Date: Thu, 22 Oct 2026 19:13:06 +0200 [thread overview]
Message-ID: <fbd174d9-261d-4fed-b26e-2990de7af2d0@ixit.cz> (raw)
In-Reply-To: <e7f68299-1c0d-4b0f-948b-4835086c0df8@lunn.ch>
On 22/10/2026 18:58, Andrew Lunn wrote:
>> + sgmii_phy: ethernet-phy@3 {
>> + compatible = "ethernet-phy-ieee802.3-c22";
>> + reg = <0x3>;
>> + max-speed = <1000>;
>
> Pointless. SGMII cannot do faster, so there is no need to limit it.
device-tree is a description. whatever the device can do should be there,
"Maximum PHY supported speed in Mbits / seconds." thus 1000 is correct value.
thus max-speed <1000>; LGTM
David
>
> Andrew
next prev parent reply other threads:[~2026-10-22 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 2:58 [PATCH v11 0/3] arm64: dts: rockchip: add RK3568 XPCS nodes and enable SGMII on Photonicat Coia Prant
2026-10-22 2:58 ` [PATCH v11 1/3] arm64: dts: rockchip: rk3568: add XPCS and fixed-clock nodes Coia Prant
2026-10-22 2:58 ` [PATCH v11 2/3] arm64: dts: rockchip: rk3568-photonicat: add RGMII PHY LEDs Coia Prant
2026-10-22 2:58 ` [PATCH v11 3/3] arm64: dts: rockchip: rk3568-photonicat: enable SGMII LAN port Coia Prant
2026-10-22 16:58 ` Andrew Lunn
2026-10-22 17:12 ` Coia Prant
2026-10-22 17:13 ` David Heidelberg [this message]
2026-10-22 18:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbd174d9-261d-4fed-b26e-2990de7af2d0@ixit.cz \
--to=david@ixit.cz \
--cc=andrew@lunn.ch \
--cc=coiaprant@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®