Re: [PATCH 1/3] x86/mce: Add CPU_SUP_* dependencies for Intel/Zhaoxin MCE features

[Dave Hansen <dave.hansen@intel.com>]

On 11/11/26 08:16, Vincent Mailhol wrote:
> On 11/11/2026 à 16:46, Dave Hansen wrote:
>> On 10/31/26 00:51, Vincent Mailhol wrote:
>>>  config X86_MCE_INTEL
>>>  	def_bool y
>>>  	prompt "Intel MCE features"
>>> -	depends on X86_MCE && X86_LOCAL_APIC
>>> +	depends on X86_MCE && X86_LOCAL_APIC && (CPU_SUP_INTEL || CPU_SUP_ZHAOXIN)
>> Is this to help end users? If so, it seems like it might also be nice to
>> improve the only human-visible part of this: the prompt text.
> Ack, I will change the prompt text to "Intel and Zhaoxin MCE features".
> 
> By the way, would it also make sense to make the prompt conditional?
> 
> 	prompt "Intel and Zhaoxin MCE features" if PROCESSOR_SELECT

Why?

$ git grep PROCESSOR_SELECT
arch/x86/Kconfig.cpu:menuconfig PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Intel processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Cyrix processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support AMD processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Hygon processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Centaur processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Transmeta processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Zhaoxin processors" if PROCESSOR_SELECT
arch/x86/Kconfig.cpu:   bool "Support Vortex processors" if PROCESSOR_SELECT

PROCESSOR_SELECT doesn't apply to *any* individual features today.