From: shuah <shuah@kernel.org>
To: Heidi Fahim <heidifahim@google.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, frowand.list@gmail.com,
shuah <shuah@kernel.org>
Subject: Re: [PATCH v2] kunit: run kunit_tool from any directory
Date: Wed, 19 Feb 2020 15:41:35 -0700 [thread overview]
Message-ID: <fc29461d-56c0-b23f-f8e8-23a88e9e471f@kernel.org> (raw)
In-Reply-To: <CAMVcs3uRj2uhFJXA+GEZmNjvNFF+3ODNmAON++scx26tnVhScA@mail.gmail.com>
On 2/19/20 3:38 PM, Heidi Fahim wrote:
> On Wed, Feb 19, 2020 at 2:18 PM shuah <shuah@kernel.org
> <mailto:shuah@kernel.org>> wrote:
>
> Hi Heidi,
>
> On 2/18/20 3:19 PM, Heidi Fahim wrote:
> > Implemented small fix so that the script changes work directories
> to the
> > root of the linux kernel source tree from which kunit.py is run. This
> > enables the user to run kunit from any working directory. Originally
> > considered using os.path.join but this is more error prone as we
> would
> > have to find all file path usages and modify them accordingly. Using
> > os.chdir ensures that the entire script is run within /linux.
> >
> > Signed-off-by: Heidi Fahim <heidifahim@google.com
> <mailto:heidifahim@google.com>>
> > Reviewed-by: Brendan Higgins <brendanhiggins@google.com
> <mailto:brendanhiggins@google.com>>
>
> Thanks for the patch. In the future please include changes from v1
> to v2.
>
> I am assuming this v2 addresses Frank's comments.
>
>
> Sorry about that! Yes the only change here was in the commit message
> addressing Frank's comment.
>
Great. I will pull this in for 5.6-rc4.
thanks,
-- Shuah
prev parent reply other threads:[~2020-02-19 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 22:19 Heidi Fahim
2020-02-19 22:18 ` shuah
[not found] ` <CAMVcs3uRj2uhFJXA+GEZmNjvNFF+3ODNmAON++scx26tnVhScA@mail.gmail.com>
2020-02-19 22:41 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc29461d-56c0-b23f-f8e8-23a88e9e471f@kernel.org \
--to=shuah@kernel.org \
--cc=brendanhiggins@google.com \
--cc=frowand.list@gmail.com \
--cc=heidifahim@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®