* [PATCH] bio-integrity: fix boolreturn.cocci warnings [not found] <201707050205.8pj7G22S%fengguang.wu@intel.com> @ 2017-07-04 18:14 ` kbuild test robot 2017-07-04 22:12 ` Jens Axboe 0 siblings, 1 reply; 2+ messages in thread From: kbuild test robot @ 2017-07-04 18:14 UTC (permalink / raw) To: Dmitry Monakhov Cc: kbuild-all, Jens Axboe, Martin K. Petersen, Christoph Hellwig, linux-block, linux-kernel block/bio-integrity.c:318:10-11: WARNING: return of 0/1 in function 'bio_integrity_prep' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: e23947bd76f0 ("bio-integrity: fold bio_integrity_enabled to bio_integrity_prep") CC: Dmitry Monakhov <dmonakhov@openvz.org> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- bio-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/block/bio-integrity.c +++ b/block/bio-integrity.c @@ -315,7 +315,7 @@ bool bio_integrity_prep(struct bio *bio) bytes, offset); if (ret == 0) - return 0; + return false; if (ret < bytes) break; ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] bio-integrity: fix boolreturn.cocci warnings 2017-07-04 18:14 ` [PATCH] bio-integrity: fix boolreturn.cocci warnings kbuild test robot @ 2017-07-04 22:12 ` Jens Axboe 0 siblings, 0 replies; 2+ messages in thread From: Jens Axboe @ 2017-07-04 22:12 UTC (permalink / raw) To: kbuild test robot, Dmitry Monakhov Cc: kbuild-all, Martin K. Petersen, Christoph Hellwig, linux-block, linux-kernel On 07/04/2017 12:14 PM, kbuild test robot wrote: > block/bio-integrity.c:318:10-11: WARNING: return of 0/1 in function 'bio_integrity_prep' with return type bool > > Return statements in functions returning bool should use > true/false instead of 1/0. > Generated by: scripts/coccinelle/misc/boolreturn.cocci Thanks, applied. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-04 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <201707050205.8pj7G22S%fengguang.wu@intel.com>
2017-07-04 18:14 ` [PATCH] bio-integrity: fix boolreturn.cocci warnings kbuild test robot
2017-07-04 22:12 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
Powered by JetHome