mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/panel: fix novatek-nt36536 dependencies
@ 2026-09-25 13:01 Arnd Bergmann
  2026-09-27 22:52 ` Neil Armstrong
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2026-09-25 13:01 UTC (permalink / raw)
  To: Neil Armstrong, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, Pengyu Luo
  Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov, David Heidelberg,
	Svyatoslav Ryhel, Julian Braha, Dario Binacchi, Teguh Sobirin,
	Marijn Suijten, dri-devel, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

The recently added driver requires access to DSC helper code
and fails to link without that:

ld.lld: error: undefined symbol: drm_dsc_pps_payload_pack
>>> referenced by panel-novatek-nt36536.c:109 (/home/arnd/arm-soc/drivers/gpu/drm/panel/panel-novatek-nt36536.c:109)
>>>               drivers/gpu/drm/panel/panel-novatek-nt36536.o:(novatek_prepare) in archive vmlinux.a

Add the usual Kconfig dependency.

Fixes: 75a5dbd1f4f7 ("drm/panel: Add Novatek NT36536 panel driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/panel/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 6874752a1901..8bf7911d2a0e 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -694,6 +694,8 @@ config DRM_PANEL_NOVATEK_NT36536
 	depends on OF
 	depends on DRM_MIPI_DSI
 	depends on BACKLIGHT_CLASS_DEVICE
+	select DRM_DISPLAY_DSC_HELPER
+	select DRM_DISPLAY_HELPER
 	select DRM_KMS_HELPER
 	help
 	  Say Y here if you want to enable support for Novatek NT36536-based
-- 
2.53.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm/panel: fix novatek-nt36536 dependencies
  2026-09-25 13:01 [PATCH] drm/panel: fix novatek-nt36536 dependencies Arnd Bergmann
@ 2026-09-27 22:52 ` Neil Armstrong
  0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2026-09-27 22:52 UTC (permalink / raw)
  To: Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, Pengyu Luo
  Cc: Arnd Bergmann, Jessica Zhang, Dmitry Baryshkov, David Heidelberg,
	Svyatoslav Ryhel, Julian Braha, Dario Binacchi, Teguh Sobirin,
	Marijn Suijten, dri-devel, linux-kernel

On 9/25/26 15:01, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The recently added driver requires access to DSC helper code
> and fails to link without that:
> 
> ld.lld: error: undefined symbol: drm_dsc_pps_payload_pack
>>>> referenced by panel-novatek-nt36536.c:109 (/home/arnd/arm-soc/drivers/gpu/drm/panel/panel-novatek-nt36536.c:109)
>>>>                drivers/gpu/drm/panel/panel-novatek-nt36536.o:(novatek_prepare) in archive vmlinux.a
> 
> Add the usual Kconfig dependency.
> 
> Fixes: 75a5dbd1f4f7 ("drm/panel: Add Novatek NT36536 panel driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/gpu/drm/panel/Kconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index 6874752a1901..8bf7911d2a0e 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -694,6 +694,8 @@ config DRM_PANEL_NOVATEK_NT36536
>   	depends on OF
>   	depends on DRM_MIPI_DSI
>   	depends on BACKLIGHT_CLASS_DEVICE
> +	select DRM_DISPLAY_DSC_HELPER
> +	select DRM_DISPLAY_HELPER
>   	select DRM_KMS_HELPER
>   	help
>   	  Say Y here if you want to enable support for Novatek NT36536-based

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-09-27 22:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-25 13:01 [PATCH] drm/panel: fix novatek-nt36536 dependencies Arnd Bergmann
2026-09-27 22:52 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®