mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: glymur-crd: Add pull-up for SD card detect
@ 2026-10-28 13:14 Monish Chunara
  2026-10-28 13:20 ` Konrad Dybcio
  2026-10-28 15:36 ` Abel Vesa
  0 siblings, 2 replies; 3+ messages in thread
From: Monish Chunara @ 2026-10-28 13:14 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, pradeep.pragallapati,
	nitin.rawat, mani, Monish Chunara

The SD card detect signal is active low and requires a defined high
level when no card is inserted. With the GPIO bias disabled, the
card-detect input can be left floating and result in spurious
interrupts.

Enable the internal pull-up on the SD card detect GPIO to keep the
signal at a defined level when the card is absent and avoid spurious
card-detect interrupts.

Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur-crd.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
index 58158b51fe29..a8f9425d8c77 100644
--- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
@@ -1110,7 +1110,7 @@ sdc2_card_det_n: sd-card-det-n-state {
 		pins = "gpio221";
 		function = "gpio";
 		drive-strength = <2>;
-		bias-disable;
+		bias-pull-up;
 	};
 
 	tpad_default: tpad-default-state {

---
base-commit: 151a134a4e6ec66f69db8750c66006f5207f7a9d
change-id: 20261028-gly_spu-96f0315a3d99

Best regards,
--  
Monish Chunara <monish.chunara@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Add pull-up for SD card detect
  2026-10-28 13:14 [PATCH] arm64: dts: qcom: glymur-crd: Add pull-up for SD card detect Monish Chunara
@ 2026-10-28 13:20 ` Konrad Dybcio
  2026-10-28 15:36 ` Abel Vesa
  1 sibling, 0 replies; 3+ messages in thread
From: Konrad Dybcio @ 2026-10-28 13:20 UTC (permalink / raw)
  To: Monish Chunara, Bjorn Andersson, Konrad Dybcio, Abel Vesa,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, pradeep.pragallapati,
	nitin.rawat, mani

On 10/28/26 2:14 PM, Monish Chunara wrote:
> The SD card detect signal is active low and requires a defined high
> level when no card is inserted. With the GPIO bias disabled, the
> card-detect input can be left floating and result in spurious
> interrupts.
> 
> Enable the internal pull-up on the SD card detect GPIO to keep the
> signal at a defined level when the card is absent and avoid spurious
> card-detect interrupts.
> 
> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> ---

Fixes: 51fe74e44c69 ("arm64: dts: qcom: glymur-crd: Enable SD card")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: glymur-crd: Add pull-up for SD card detect
  2026-10-28 13:14 [PATCH] arm64: dts: qcom: glymur-crd: Add pull-up for SD card detect Monish Chunara
  2026-10-28 13:20 ` Konrad Dybcio
@ 2026-10-28 15:36 ` Abel Vesa
  1 sibling, 0 replies; 3+ messages in thread
From: Abel Vesa @ 2026-10-28 15:36 UTC (permalink / raw)
  To: Monish Chunara
  Cc: Bjorn Andersson, Konrad Dybcio, Abel Vesa, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel, pradeep.pragallapati, nitin.rawat, mani

On 26-10-28 18:44:20, Monish Chunara wrote:
> The SD card detect signal is active low and requires a defined high
> level when no card is inserted. With the GPIO bias disabled, the
> card-detect input can be left floating and result in spurious
> interrupts.
> 
> Enable the internal pull-up on the SD card detect GPIO to keep the
> signal at a defined level when the card is absent and avoid spurious
> card-detect interrupts.
> 
> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>

Deserves a Fixes tag, doesn't it?

Anyway:

Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-28 15:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-28 13:14 [PATCH] arm64: dts: qcom: glymur-crd: Add pull-up for SD card detect Monish Chunara
2026-10-28 13:20 ` Konrad Dybcio
2026-10-28 15:36 ` Abel Vesa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®