* [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr
@ 2021-04-20 10:41 Colin King
2021-04-21 20:20 ` James Smart
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin King @ 2021-04-20 10:41 UTC (permalink / raw)
To: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The pointer tmp_hdr is being assigned a value that is never
read, the assignment is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/lpfc/lpfc_sli.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
index 06ccc0157bd8..9ead564dd0c0 100644
--- a/drivers/scsi/lpfc/lpfc_sli.c
+++ b/drivers/scsi/lpfc/lpfc_sli.c
@@ -17936,7 +17936,6 @@ lpfc_fc_frame_add(struct lpfc_vport *vport, struct hbq_dmabuf *dmabuf)
seq_dmabuf->time_stamp = jiffies;
lpfc_update_rcv_time_stamp(vport);
if (list_empty(&seq_dmabuf->dbuf.list)) {
- temp_hdr = dmabuf->hbuf.virt;
list_add_tail(&dmabuf->dbuf.list, &seq_dmabuf->dbuf.list);
return seq_dmabuf;
}
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr
2021-04-20 10:41 [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr Colin King
@ 2021-04-21 20:20 ` James Smart
2021-04-27 2:52 ` Martin K. Petersen
2021-05-11 3:25 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: James Smart @ 2021-04-21 20:20 UTC (permalink / raw)
To: Colin King, James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi
Cc: kernel-janitors, linux-kernel
On 4/20/2021 3:41 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer tmp_hdr is being assigned a value that is never
> read, the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Thanks
Reviewed-by: James Smart <jsmart2021@gmail.com>
-- james
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr
2021-04-20 10:41 [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr Colin King
2021-04-21 20:20 ` James Smart
@ 2021-04-27 2:52 ` Martin K. Petersen
2021-05-11 3:25 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-04-27 2:52 UTC (permalink / raw)
To: Colin King
Cc: James Smart, Dick Kennedy, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
Colin,
> The pointer tmp_hdr is being assigned a value that is never read, the
> assignment is redundant and can be removed.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr
2021-04-20 10:41 [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr Colin King
2021-04-21 20:20 ` James Smart
2021-04-27 2:52 ` Martin K. Petersen
@ 2021-05-11 3:25 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-05-11 3:25 UTC (permalink / raw)
To: James E . J . Bottomley, James Smart, linux-scsi, Dick Kennedy,
Colin King
Cc: Martin K . Petersen, linux-kernel, kernel-janitors
On Tue, 20 Apr 2021 11:41:23 +0100, Colin King wrote:
> The pointer tmp_hdr is being assigned a value that is never
> read, the assignment is redundant and can be removed.
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: lpfc: remove redundant assignment to pointer temp_hdr
https://git.kernel.org/mkp/scsi/c/52b259908114
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-11 3:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-20 10:41 [PATCH] scsi: lpfc: remove redundant assignment to pointer temp_hdr Colin King
2021-04-21 20:20 ` James Smart
2021-04-27 2:52 ` Martin K. Petersen
2021-05-11 3:25 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®