mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Lizhi Hou <lizhi.hou@amd.com>,
	ogabbay@kernel.org, quic_jhugo@quicinc.com,
	dri-devel@lists.freedesktop.org,
	maciej.falkowski@linux.intel.com
Cc: linux-kernel@vger.kernel.org, max.zhen@amd.com, sonal.santan@amd.com
Subject: Re: [PATCH V1] accel/amdxdna: Replace platform name strings
Date: Mon, 2 Feb 2026 15:40:05 -0600	[thread overview]
Message-ID: <fc6e4b08-27c7-42f4-bb3d-731aad19987f@amd.com> (raw)
In-Reply-To: <20260202212529.2681307-1-lizhi.hou@amd.com>

On 2/2/26 3:25 PM, Lizhi Hou wrote:
> Update platform name strings to be more accurate and user-friendly.
> 
> Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>

The same NPU is used in multiple products though isn't it?  So wouldn't 
this be confusing for example to show "Strix" NPU on a Gorgon product?

> ---
>   drivers/accel/amdxdna/npu1_regs.c | 2 +-
>   drivers/accel/amdxdna/npu4_regs.c | 2 +-
>   drivers/accel/amdxdna/npu5_regs.c | 2 +-
>   drivers/accel/amdxdna/npu6_regs.c | 2 +-
>   4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
> index 6f36a27b5a02..cee42c49cbb6 100644
> --- a/drivers/accel/amdxdna/npu1_regs.c
> +++ b/drivers/accel/amdxdna/npu1_regs.c
> @@ -117,7 +117,7 @@ const struct amdxdna_dev_info dev_npu1_info = {
>   	.dev_mem_buf_shift = 15, /* 32 KiB aligned */
>   	.dev_mem_base      = AIE2_DEVM_BASE,
>   	.dev_mem_size      = AIE2_DEVM_SIZE,
> -	.vbnv              = "RyzenAI-npu1",
> +	.vbnv              = "NPU Phoenix",
>   	.device_type       = AMDXDNA_DEV_TYPE_KMQ,
>   	.dev_priv          = &npu1_dev_priv,
>   	.ops               = &aie2_ops,
> diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
> index 3fc0420e8e3e..ed0382925b59 100644
> --- a/drivers/accel/amdxdna/npu4_regs.c
> +++ b/drivers/accel/amdxdna/npu4_regs.c
> @@ -144,7 +144,7 @@ const struct amdxdna_dev_info dev_npu4_info = {
>   	.dev_mem_buf_shift = 15, /* 32 KiB aligned */
>   	.dev_mem_base      = AIE2_DEVM_BASE,
>   	.dev_mem_size      = AIE2_DEVM_SIZE,
> -	.vbnv              = "RyzenAI-npu4",
> +	.vbnv              = "NPU Strix",
>   	.device_type       = AMDXDNA_DEV_TYPE_KMQ,
>   	.dev_priv          = &npu4_dev_priv,
>   	.ops               = &aie2_ops, /* NPU4 can share NPU1's callback */
> diff --git a/drivers/accel/amdxdna/npu5_regs.c b/drivers/accel/amdxdna/npu5_regs.c
> index c0a35cfd886c..8427e9f2b4ec 100644
> --- a/drivers/accel/amdxdna/npu5_regs.c
> +++ b/drivers/accel/amdxdna/npu5_regs.c
> @@ -108,7 +108,7 @@ const struct amdxdna_dev_info dev_npu5_info = {
>   	.dev_mem_buf_shift = 15, /* 32 KiB aligned */
>   	.dev_mem_base      = AIE2_DEVM_BASE,
>   	.dev_mem_size      = AIE2_DEVM_SIZE,
> -	.vbnv              = "RyzenAI-npu5",
> +	.vbnv              = "NPU Strix Halo",
>   	.device_type       = AMDXDNA_DEV_TYPE_KMQ,
>   	.dev_priv          = &npu5_dev_priv,
>   	.ops               = &aie2_ops,
> diff --git a/drivers/accel/amdxdna/npu6_regs.c b/drivers/accel/amdxdna/npu6_regs.c
> index 1fb07df99186..a960149b5408 100644
> --- a/drivers/accel/amdxdna/npu6_regs.c
> +++ b/drivers/accel/amdxdna/npu6_regs.c
> @@ -109,7 +109,7 @@ const struct amdxdna_dev_info dev_npu6_info = {
>   	.dev_mem_buf_shift = 15, /* 32 KiB aligned */
>   	.dev_mem_base      = AIE2_DEVM_BASE,
>   	.dev_mem_size      = AIE2_DEVM_SIZE,
> -	.vbnv              = "RyzenAI-npu6",
> +	.vbnv              = "NPU Krackan",
>   	.device_type       = AMDXDNA_DEV_TYPE_KMQ,
>   	.dev_priv          = &npu6_dev_priv,
>   	.ops               = &aie2_ops,


  reply	other threads:[~2026-02-02 21:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 21:25 Lizhi Hou
2026-02-02 21:40 ` Mario Limonciello [this message]
2026-02-02 21:56   ` Lizhi Hou
2026-02-03 18:53 ` Falkowski, Maciej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc6e4b08-27c7-42f4-bb3d-731aad19987f@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=maciej.falkowski@linux.intel.com \
    --cc=max.zhen@amd.com \
    --cc=ogabbay@kernel.org \
    --cc=quic_jhugo@quicinc.com \
    --cc=sonal.santan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®