* [PATCH V1] accel/amdxdna: Replace platform name strings
@ 2026-02-02 21:25 Lizhi Hou
2026-02-02 21:40 ` Mario Limonciello
2026-02-03 18:53 ` Falkowski, Maciej
0 siblings, 2 replies; 4+ messages in thread
From: Lizhi Hou @ 2026-02-02 21:25 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan, mario.limonciello
Update platform name strings to be more accurate and user-friendly.
Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/npu1_regs.c | 2 +-
drivers/accel/amdxdna/npu4_regs.c | 2 +-
drivers/accel/amdxdna/npu5_regs.c | 2 +-
drivers/accel/amdxdna/npu6_regs.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
index 6f36a27b5a02..cee42c49cbb6 100644
--- a/drivers/accel/amdxdna/npu1_regs.c
+++ b/drivers/accel/amdxdna/npu1_regs.c
@@ -117,7 +117,7 @@ const struct amdxdna_dev_info dev_npu1_info = {
.dev_mem_buf_shift = 15, /* 32 KiB aligned */
.dev_mem_base = AIE2_DEVM_BASE,
.dev_mem_size = AIE2_DEVM_SIZE,
- .vbnv = "RyzenAI-npu1",
+ .vbnv = "NPU Phoenix",
.device_type = AMDXDNA_DEV_TYPE_KMQ,
.dev_priv = &npu1_dev_priv,
.ops = &aie2_ops,
diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
index 3fc0420e8e3e..ed0382925b59 100644
--- a/drivers/accel/amdxdna/npu4_regs.c
+++ b/drivers/accel/amdxdna/npu4_regs.c
@@ -144,7 +144,7 @@ const struct amdxdna_dev_info dev_npu4_info = {
.dev_mem_buf_shift = 15, /* 32 KiB aligned */
.dev_mem_base = AIE2_DEVM_BASE,
.dev_mem_size = AIE2_DEVM_SIZE,
- .vbnv = "RyzenAI-npu4",
+ .vbnv = "NPU Strix",
.device_type = AMDXDNA_DEV_TYPE_KMQ,
.dev_priv = &npu4_dev_priv,
.ops = &aie2_ops, /* NPU4 can share NPU1's callback */
diff --git a/drivers/accel/amdxdna/npu5_regs.c b/drivers/accel/amdxdna/npu5_regs.c
index c0a35cfd886c..8427e9f2b4ec 100644
--- a/drivers/accel/amdxdna/npu5_regs.c
+++ b/drivers/accel/amdxdna/npu5_regs.c
@@ -108,7 +108,7 @@ const struct amdxdna_dev_info dev_npu5_info = {
.dev_mem_buf_shift = 15, /* 32 KiB aligned */
.dev_mem_base = AIE2_DEVM_BASE,
.dev_mem_size = AIE2_DEVM_SIZE,
- .vbnv = "RyzenAI-npu5",
+ .vbnv = "NPU Strix Halo",
.device_type = AMDXDNA_DEV_TYPE_KMQ,
.dev_priv = &npu5_dev_priv,
.ops = &aie2_ops,
diff --git a/drivers/accel/amdxdna/npu6_regs.c b/drivers/accel/amdxdna/npu6_regs.c
index 1fb07df99186..a960149b5408 100644
--- a/drivers/accel/amdxdna/npu6_regs.c
+++ b/drivers/accel/amdxdna/npu6_regs.c
@@ -109,7 +109,7 @@ const struct amdxdna_dev_info dev_npu6_info = {
.dev_mem_buf_shift = 15, /* 32 KiB aligned */
.dev_mem_base = AIE2_DEVM_BASE,
.dev_mem_size = AIE2_DEVM_SIZE,
- .vbnv = "RyzenAI-npu6",
+ .vbnv = "NPU Krackan",
.device_type = AMDXDNA_DEV_TYPE_KMQ,
.dev_priv = &npu6_dev_priv,
.ops = &aie2_ops,
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1] accel/amdxdna: Replace platform name strings
2026-02-02 21:25 [PATCH V1] accel/amdxdna: Replace platform name strings Lizhi Hou
@ 2026-02-02 21:40 ` Mario Limonciello
2026-02-02 21:56 ` Lizhi Hou
2026-02-03 18:53 ` Falkowski, Maciej
1 sibling, 1 reply; 4+ messages in thread
From: Mario Limonciello @ 2026-02-02 21:40 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan
On 2/2/26 3:25 PM, Lizhi Hou wrote:
> Update platform name strings to be more accurate and user-friendly.
>
> Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
The same NPU is used in multiple products though isn't it? So wouldn't
this be confusing for example to show "Strix" NPU on a Gorgon product?
> ---
> drivers/accel/amdxdna/npu1_regs.c | 2 +-
> drivers/accel/amdxdna/npu4_regs.c | 2 +-
> drivers/accel/amdxdna/npu5_regs.c | 2 +-
> drivers/accel/amdxdna/npu6_regs.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
> index 6f36a27b5a02..cee42c49cbb6 100644
> --- a/drivers/accel/amdxdna/npu1_regs.c
> +++ b/drivers/accel/amdxdna/npu1_regs.c
> @@ -117,7 +117,7 @@ const struct amdxdna_dev_info dev_npu1_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu1",
> + .vbnv = "NPU Phoenix",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu1_dev_priv,
> .ops = &aie2_ops,
> diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
> index 3fc0420e8e3e..ed0382925b59 100644
> --- a/drivers/accel/amdxdna/npu4_regs.c
> +++ b/drivers/accel/amdxdna/npu4_regs.c
> @@ -144,7 +144,7 @@ const struct amdxdna_dev_info dev_npu4_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu4",
> + .vbnv = "NPU Strix",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu4_dev_priv,
> .ops = &aie2_ops, /* NPU4 can share NPU1's callback */
> diff --git a/drivers/accel/amdxdna/npu5_regs.c b/drivers/accel/amdxdna/npu5_regs.c
> index c0a35cfd886c..8427e9f2b4ec 100644
> --- a/drivers/accel/amdxdna/npu5_regs.c
> +++ b/drivers/accel/amdxdna/npu5_regs.c
> @@ -108,7 +108,7 @@ const struct amdxdna_dev_info dev_npu5_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu5",
> + .vbnv = "NPU Strix Halo",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu5_dev_priv,
> .ops = &aie2_ops,
> diff --git a/drivers/accel/amdxdna/npu6_regs.c b/drivers/accel/amdxdna/npu6_regs.c
> index 1fb07df99186..a960149b5408 100644
> --- a/drivers/accel/amdxdna/npu6_regs.c
> +++ b/drivers/accel/amdxdna/npu6_regs.c
> @@ -109,7 +109,7 @@ const struct amdxdna_dev_info dev_npu6_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu6",
> + .vbnv = "NPU Krackan",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu6_dev_priv,
> .ops = &aie2_ops,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1] accel/amdxdna: Replace platform name strings
2026-02-02 21:40 ` Mario Limonciello
@ 2026-02-02 21:56 ` Lizhi Hou
0 siblings, 0 replies; 4+ messages in thread
From: Lizhi Hou @ 2026-02-02 21:56 UTC (permalink / raw)
To: Mario Limonciello, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan
On 2/2/26 13:40, Mario Limonciello wrote:
> On 2/2/26 3:25 PM, Lizhi Hou wrote:
>> Update platform name strings to be more accurate and user-friendly.
>>
>> Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI
>> Engine")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>
> The same NPU is used in multiple products though isn't it? So
> wouldn't this be confusing for example to show "Strix" NPU on a Gorgon
> product?
You are correct. To figuring out specific name, driver need to send out
a firmware command. It is a little beyond a bug fix and I plan to have
those implemented later.
Thanks,
Lizhi
>
>> ---
>> drivers/accel/amdxdna/npu1_regs.c | 2 +-
>> drivers/accel/amdxdna/npu4_regs.c | 2 +-
>> drivers/accel/amdxdna/npu5_regs.c | 2 +-
>> drivers/accel/amdxdna/npu6_regs.c | 2 +-
>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/accel/amdxdna/npu1_regs.c
>> b/drivers/accel/amdxdna/npu1_regs.c
>> index 6f36a27b5a02..cee42c49cbb6 100644
>> --- a/drivers/accel/amdxdna/npu1_regs.c
>> +++ b/drivers/accel/amdxdna/npu1_regs.c
>> @@ -117,7 +117,7 @@ const struct amdxdna_dev_info dev_npu1_info = {
>> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
>> .dev_mem_base = AIE2_DEVM_BASE,
>> .dev_mem_size = AIE2_DEVM_SIZE,
>> - .vbnv = "RyzenAI-npu1",
>> + .vbnv = "NPU Phoenix",
>> .device_type = AMDXDNA_DEV_TYPE_KMQ,
>> .dev_priv = &npu1_dev_priv,
>> .ops = &aie2_ops,
>> diff --git a/drivers/accel/amdxdna/npu4_regs.c
>> b/drivers/accel/amdxdna/npu4_regs.c
>> index 3fc0420e8e3e..ed0382925b59 100644
>> --- a/drivers/accel/amdxdna/npu4_regs.c
>> +++ b/drivers/accel/amdxdna/npu4_regs.c
>> @@ -144,7 +144,7 @@ const struct amdxdna_dev_info dev_npu4_info = {
>> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
>> .dev_mem_base = AIE2_DEVM_BASE,
>> .dev_mem_size = AIE2_DEVM_SIZE,
>> - .vbnv = "RyzenAI-npu4",
>> + .vbnv = "NPU Strix",
>> .device_type = AMDXDNA_DEV_TYPE_KMQ,
>> .dev_priv = &npu4_dev_priv,
>> .ops = &aie2_ops, /* NPU4 can share NPU1's
>> callback */
>> diff --git a/drivers/accel/amdxdna/npu5_regs.c
>> b/drivers/accel/amdxdna/npu5_regs.c
>> index c0a35cfd886c..8427e9f2b4ec 100644
>> --- a/drivers/accel/amdxdna/npu5_regs.c
>> +++ b/drivers/accel/amdxdna/npu5_regs.c
>> @@ -108,7 +108,7 @@ const struct amdxdna_dev_info dev_npu5_info = {
>> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
>> .dev_mem_base = AIE2_DEVM_BASE,
>> .dev_mem_size = AIE2_DEVM_SIZE,
>> - .vbnv = "RyzenAI-npu5",
>> + .vbnv = "NPU Strix Halo",
>> .device_type = AMDXDNA_DEV_TYPE_KMQ,
>> .dev_priv = &npu5_dev_priv,
>> .ops = &aie2_ops,
>> diff --git a/drivers/accel/amdxdna/npu6_regs.c
>> b/drivers/accel/amdxdna/npu6_regs.c
>> index 1fb07df99186..a960149b5408 100644
>> --- a/drivers/accel/amdxdna/npu6_regs.c
>> +++ b/drivers/accel/amdxdna/npu6_regs.c
>> @@ -109,7 +109,7 @@ const struct amdxdna_dev_info dev_npu6_info = {
>> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
>> .dev_mem_base = AIE2_DEVM_BASE,
>> .dev_mem_size = AIE2_DEVM_SIZE,
>> - .vbnv = "RyzenAI-npu6",
>> + .vbnv = "NPU Krackan",
>> .device_type = AMDXDNA_DEV_TYPE_KMQ,
>> .dev_priv = &npu6_dev_priv,
>> .ops = &aie2_ops,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V1] accel/amdxdna: Replace platform name strings
2026-02-02 21:25 [PATCH V1] accel/amdxdna: Replace platform name strings Lizhi Hou
2026-02-02 21:40 ` Mario Limonciello
@ 2026-02-03 18:53 ` Falkowski, Maciej
1 sibling, 0 replies; 4+ messages in thread
From: Falkowski, Maciej @ 2026-02-03 18:53 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 2/2/2026 10:25 PM, Lizhi Hou wrote:
> Update platform name strings to be more accurate and user-friendly.
>
> Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/npu1_regs.c | 2 +-
> drivers/accel/amdxdna/npu4_regs.c | 2 +-
> drivers/accel/amdxdna/npu5_regs.c | 2 +-
> drivers/accel/amdxdna/npu6_regs.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/accel/amdxdna/npu1_regs.c b/drivers/accel/amdxdna/npu1_regs.c
> index 6f36a27b5a02..cee42c49cbb6 100644
> --- a/drivers/accel/amdxdna/npu1_regs.c
> +++ b/drivers/accel/amdxdna/npu1_regs.c
> @@ -117,7 +117,7 @@ const struct amdxdna_dev_info dev_npu1_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu1",
> + .vbnv = "NPU Phoenix",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu1_dev_priv,
> .ops = &aie2_ops,
> diff --git a/drivers/accel/amdxdna/npu4_regs.c b/drivers/accel/amdxdna/npu4_regs.c
> index 3fc0420e8e3e..ed0382925b59 100644
> --- a/drivers/accel/amdxdna/npu4_regs.c
> +++ b/drivers/accel/amdxdna/npu4_regs.c
> @@ -144,7 +144,7 @@ const struct amdxdna_dev_info dev_npu4_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu4",
> + .vbnv = "NPU Strix",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu4_dev_priv,
> .ops = &aie2_ops, /* NPU4 can share NPU1's callback */
> diff --git a/drivers/accel/amdxdna/npu5_regs.c b/drivers/accel/amdxdna/npu5_regs.c
> index c0a35cfd886c..8427e9f2b4ec 100644
> --- a/drivers/accel/amdxdna/npu5_regs.c
> +++ b/drivers/accel/amdxdna/npu5_regs.c
> @@ -108,7 +108,7 @@ const struct amdxdna_dev_info dev_npu5_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu5",
> + .vbnv = "NPU Strix Halo",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu5_dev_priv,
> .ops = &aie2_ops,
> diff --git a/drivers/accel/amdxdna/npu6_regs.c b/drivers/accel/amdxdna/npu6_regs.c
> index 1fb07df99186..a960149b5408 100644
> --- a/drivers/accel/amdxdna/npu6_regs.c
> +++ b/drivers/accel/amdxdna/npu6_regs.c
> @@ -109,7 +109,7 @@ const struct amdxdna_dev_info dev_npu6_info = {
> .dev_mem_buf_shift = 15, /* 32 KiB aligned */
> .dev_mem_base = AIE2_DEVM_BASE,
> .dev_mem_size = AIE2_DEVM_SIZE,
> - .vbnv = "RyzenAI-npu6",
> + .vbnv = "NPU Krackan",
> .device_type = AMDXDNA_DEV_TYPE_KMQ,
> .dev_priv = &npu6_dev_priv,
> .ops = &aie2_ops,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-03 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-02 21:25 [PATCH V1] accel/amdxdna: Replace platform name strings Lizhi Hou
2026-02-02 21:40 ` Mario Limonciello
2026-02-02 21:56 ` Lizhi Hou
2026-02-03 18:53 ` Falkowski, Maciej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®