From: "Christian König" <christian.koenig@amd.com>
To: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 04/12] drm/amdgpu: add amdgpu_gtt_node_to_byte_offset helper
Date: Fri, 30 Jan 2026 13:49:31 +0100 [thread overview]
Message-ID: <fc8d0548-1352-40b3-85cd-271cb9c9bf47@amd.com> (raw)
In-Reply-To: <20260129153336.7473-5-pierre-eric.pelloux-prayer@amd.com>
On 1/29/26 16:33, Pierre-Eric Pelloux-Prayer wrote:
> Having a helper avoids code duplication.
>
> Signed-off-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h
> index 871388b86503..c43f352df953 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h
> @@ -220,6 +220,14 @@ static inline u64 amdgpu_compute_gart_address(struct amdgpu_gmc *gmc,
> return gmc->gart_start + entity->gart_window_offs[index];
> }
>
> +/**
> + * amdgpu_gtt_node_to_byte_offset() - Returns a byte offset of a gtt node
> + */
> +static inline u64 amdgpu_gtt_node_to_byte_offset(const struct drm_mm_node *gtt_node)
> +{
> + return gtt_node->start * (u64)PAGE_SIZE;
> +}
> +
> void amdgpu_ttm_tt_set_user_pages(struct ttm_tt *ttm, struct amdgpu_hmm_range *range);
> int amdgpu_ttm_tt_get_userptr(const struct ttm_buffer_object *tbo,
> uint64_t *user_addr);
next prev parent reply other threads:[~2026-01-30 12:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 15:33 [PATCH v7 00/12] drm/amdgpu: preparation patchs for the use all SDMA instances series Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 01/12] drm/amdgpu: remove gart_window_lock usage from gmc v12_1 Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 02/12] drm/amdgpu: statically assign gart windows to ttm entities Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 03/12] drm/amdgpu: add amdgpu_ttm_buffer_entity_fini func Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 04/12] drm/amdgpu: add amdgpu_gtt_node_to_byte_offset helper Pierre-Eric Pelloux-Prayer
2026-01-30 12:49 ` Christian König [this message]
2026-01-29 15:33 ` [PATCH v7 05/12] amdgpu/vce: use amdgpu_gtt_mgr_alloc_entries Pierre-Eric Pelloux-Prayer
2026-01-30 12:56 ` Christian König
2026-01-29 15:33 ` [PATCH v7 06/12] amdgpu/ttm: " Pierre-Eric Pelloux-Prayer
2026-01-30 14:24 ` Christian König
2026-01-29 15:33 ` [PATCH v7 07/12] amdgpu/gtt: remove AMDGPU_GTT_NUM_TRANSFER_WINDOWS Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 08/12] drm/amdgpu: add missing lock in amdgpu_benchmark_do_move Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 09/12] drm/amdgpu: check entity lock is held in amdgpu_ttm_job_submit Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 10/12] drm/amdgpu: double AMDGPU_GTT_MAX_TRANSFER_SIZE Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 11/12] drm/amdgpu: introduce amdgpu_sdma_set_vm_pte_scheds Pierre-Eric Pelloux-Prayer
2026-01-29 15:33 ` [PATCH v7 12/12] drm/amdgpu: move sched status check inside amdgpu_ttm_set_buffer_funcs_status Pierre-Eric Pelloux-Prayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc8d0548-1352-40b3-85cd-271cb9c9bf47@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®