From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>
Cc: Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Suresh Vankadara <svankada@qti.qualcomm.com>,
Vikram Sharma <vikram.sharma@oss.qualcomm.com>
Subject: Re: [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports
Date: Thu, 5 Nov 2026 08:33:49 +0100 [thread overview]
Message-ID: <fc9acaf2-f214-434e-bbe1-88e8e1af7683@kernel.org> (raw)
In-Reply-To: <c5af7192-c923-4fbc-bbfc-7f03e310fddb@oss.qualcomm.com>
On 05/11/2026 06:32, Nihal Kumar Gupta wrote:
>>
>> What is the problem exactly you are solving?
>>
>
> The problem is that CSIPHY4 is connected to CAMSS interface 4, so the
> graph should describe it as port@4, not port@2.
Nothing like this is explained in commit msg.
>
> The previous port@3 description only worked through the X1E80100 resource
> table indirection:
>
> port@3 -> csiphy_res[3] -> .csiphy.id = 4 -> CSID selects CSIPHY4
>
> New standalone PHY path:
> port@4 -> no csiphy_res[] lookup -> port number is id 4 -> CSID selects CSIPHY4
Then this breaks existing users, no? Anyway, what stops you from having
there proper mapping?
Did you find any existing practice of numbering ports logical numbering
in this device, but some other logic coming from datasheet? Where?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-05 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-02 8:50 [PATCH 0/2] media: qcom: camss: Use Glymur graph ports as CSIPHY IDs Nihal Kumar Gupta
2026-11-02 8:50 ` [PATCH 1/2] dt-bindings: media: qcom,glymur-camss: Use CSIPHY indices for ports Nihal Kumar Gupta
2026-11-04 13:52 ` Krzysztof Kozlowski
2026-11-04 16:00 ` Nihal Kumar Gupta
2026-11-04 16:12 ` Krzysztof Kozlowski
2026-11-05 5:32 ` Nihal Kumar Gupta
2026-11-05 7:33 ` Krzysztof Kozlowski [this message]
2026-11-05 9:18 ` Nihal Kumar Gupta
2026-11-05 9:23 ` Krzysztof Kozlowski
2026-11-05 9:53 ` Loic Poulain
2026-11-02 8:50 ` [PATCH 2/2] media: qcom: camss: Add Glymur specific resources Nihal Kumar Gupta
2026-11-04 13:54 ` Krzysztof Kozlowski
2026-11-04 16:01 ` Nihal Kumar Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc9acaf2-f214-434e-bbe1-88e8e1af7683@kernel.org \
--to=krzk@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=nihal.gupta@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=svankada@qti.qualcomm.com \
--cc=vikram.sharma@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®