[PATCH 0/2] remoteproc: qcom: Introduce DSP support for QCS8300

[PATCH 0/2] remoteproc: qcom: Introduce DSP support for QCS8300

[Jingyi Wang]

Add the bindings and driver changes for DSP support on the QCS8300
platform in order to enable the ADSP, CDSP and GPDSP remoteproc to
boot.

Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
Jingyi Wang (2):
  dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc
  remoteproc: qcom: pas: Add QCS8300 remoteproc support

 .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 ++++++++
 drivers/remoteproc/qcom_q6v5_pas.c            | 55 +++++++++++++++++++
 2 files changed, 77 insertions(+)

-- 
base-commit: 6f923748057a4f6aa187e0d5b22990d633a48d12
2.25.1

[PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

[Jingyi Wang]

Document the components used to boot the ADSP, CDSP and GPDSP on the
QCS8300 SoC.

Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
 .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
index 7fe401a06805..44b070a17ca0 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
@@ -16,6 +16,9 @@ description:
 properties:
   compatible:
     enum:
+      - qcom,qcs8300-adsp-pas
+      - qcom,qcs8300-cdsp-pas
+      - qcom,qcs8300-gpdsp-pas
       - qcom,sa8775p-adsp-pas
       - qcom,sa8775p-cdsp0-pas
       - qcom,sa8775p-cdsp1-pas
@@ -64,6 +67,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,qcs8300-adsp-pas
             - qcom,sa8775p-adsp-pas
     then:
       properties:
@@ -75,6 +79,23 @@ allOf:
           items:
             - const: lcx
             - const: lmx
+  - if:
+      properties:
+        compatible:
+          enum:
+            - qcom,qcs8300-cdsp-pas
+    then:
+      properties:
+        power-domains:
+          items:
+            - description: CX power domain
+            - description: MXC power domain
+            - description: NSP0 power domain
+        power-domain-names:
+          items:
+            - const: cx
+            - const: mxc
+            - const: nsp0
 
   - if:
       properties:
@@ -99,6 +120,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,qcs8300-gpdsp-pas
             - qcom,sa8775p-gpdsp0-pas
             - qcom,sa8775p-gpdsp1-pas
     then:
-- 
2.25.1

[PATCH 2/2] remoteproc: qcom: pas: Add QCS8300 remoteproc support

[Jingyi Wang]

Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300
platform.

Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
 drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index ef82835e98a4..368aa9cc0051 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = {
 	.ssctl_id = 0x14,
 };
 
+static const struct adsp_data qcs8300_adsp_resource = {
+	.crash_reason_smem = 423,
+	.firmware_name = "adsp.mdt",
+	.pas_id = 1,
+	.minidump_id = 5,
+	.auto_boot = true,
+	.proxy_pd_names = (char*[]){
+		"lcx",
+		"lmx",
+		NULL
+	},
+	.load_state = "adsp",
+	.ssr_name = "lpass",
+	.sysmon_name = "adsp",
+	.ssctl_id = 0x14,
+};
+
+static const struct adsp_data qcs8300_cdsp_resource = {
+	.crash_reason_smem = 601,
+	.firmware_name = "cdsp0.mdt",
+	.pas_id = 18,
+	.minidump_id = 7,
+	.auto_boot = true,
+	.proxy_pd_names = (char*[]){
+		"cx",
+		"mxc",
+		"nsp0",
+		NULL
+	},
+	.load_state = "cdsp",
+	.ssr_name = "cdsp",
+	.sysmon_name = "cdsp",
+	.ssctl_id = 0x17,
+};
+
+static const struct adsp_data qcs8300_gpdsp_resource = {
+	.crash_reason_smem = 640,
+	.firmware_name = "gpdsp0.mdt",
+	.pas_id = 39,
+	.minidump_id = 21,
+	.auto_boot = true,
+	.proxy_pd_names = (char*[]){
+		"cx",
+		"mxc",
+		NULL
+	},
+	.load_state = "gpdsp",
+	.ssr_name = "gpdsp",
+	.sysmon_name = "gpdsp",
+	.ssctl_id = 0x21,
+};
+
 static const struct adsp_data sm6350_adsp_resource = {
 	.crash_reason_smem = 423,
 	.firmware_name = "adsp.mdt",
@@ -1416,6 +1468,9 @@ static const struct of_device_id adsp_of_match[] = {
 	{ .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init },
 	{ .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init },
 	{ .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init },
+	{ .compatible = "qcom,qcs8300-adsp-pas", .data = &qcs8300_adsp_resource},
+	{ .compatible = "qcom,qcs8300-cdsp-pas", .data = &qcs8300_cdsp_resource},
+	{ .compatible = "qcom,qcs8300-gpdsp-pas", .data = &qcs8300_gpdsp_resource},
 	{ .compatible = "qcom,sa8775p-adsp-pas", .data = &sa8775p_adsp_resource},
 	{ .compatible = "qcom,sa8775p-cdsp0-pas", .data = &sa8775p_cdsp0_resource},
 	{ .compatible = "qcom,sa8775p-cdsp1-pas", .data = &sa8775p_cdsp1_resource},
-- 
2.25.1

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

[Krzysztof Kozlowski]

On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote:
> Document the components used to boot the ADSP, CDSP and GPDSP on the
> QCS8300 SoC.
> 
> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
>  .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
> index 7fe401a06805..44b070a17ca0 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
> @@ -16,6 +16,9 @@ description:
>  properties:
>    compatible:
>      enum:
> +      - qcom,qcs8300-adsp-pas
> +      - qcom,qcs8300-cdsp-pas
> +      - qcom,qcs8300-gpdsp-pas
>        - qcom,sa8775p-adsp-pas
>        - qcom,sa8775p-cdsp0-pas
>        - qcom,sa8775p-cdsp1-pas
> @@ -64,6 +67,7 @@ allOf:
>        properties:
>          compatible:
>            enum:
> +            - qcom,qcs8300-adsp-pas
>              - qcom,sa8775p-adsp-pas
>      then:
>        properties:
> @@ -75,6 +79,23 @@ allOf:
>            items:
>              - const: lcx
>              - const: lmx
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - qcom,qcs8300-cdsp-pas

This looks the same as sa8775p cdsp. Why new entry?

Best regards,
Krzysztof

Re: [PATCH 2/2] remoteproc: qcom: pas: Add QCS8300 remoteproc support

[Krzysztof Kozlowski]

On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote:
> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300
> platform.
> 
> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
>  drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index ef82835e98a4..368aa9cc0051 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = {
>  	.ssctl_id = 0x14,
>  };
>  
> +static const struct adsp_data qcs8300_adsp_resource = {
> +	.crash_reason_smem = 423,
> +	.firmware_name = "adsp.mdt",

Why this is mdt, not mbn?

Sorry, it is again some old driver :(

Best regards,
Krzysztof

Re: [PATCH 2/2] remoteproc: qcom: pas: Add QCS8300 remoteproc support

[Krzysztof Kozlowski]

On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote:
> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300
> platform.
> 
> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
>  drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index ef82835e98a4..368aa9cc0051 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = {
>  	.ssctl_id = 0x14,
>  };
>  
> +static const struct adsp_data qcs8300_adsp_resource = {
> +	.crash_reason_smem = 423,

You just duplicate stuff. This is EXACTLY the same as SA8775p.

NAK.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

[Jingyi Wang]

On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote:
>> Document the components used to boot the ADSP, CDSP and GPDSP on the
>> QCS8300 SoC.
>>
>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>>  .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++
>>  1 file changed, 22 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> index 7fe401a06805..44b070a17ca0 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>> @@ -16,6 +16,9 @@ description:
>>  properties:
>>    compatible:
>>      enum:
>> +      - qcom,qcs8300-adsp-pas
>> +      - qcom,qcs8300-cdsp-pas
>> +      - qcom,qcs8300-gpdsp-pas
>>        - qcom,sa8775p-adsp-pas
>>        - qcom,sa8775p-cdsp0-pas
>>        - qcom,sa8775p-cdsp1-pas
>> @@ -64,6 +67,7 @@ allOf:
>>        properties:
>>          compatible:
>>            enum:
>> +            - qcom,qcs8300-adsp-pas
>>              - qcom,sa8775p-adsp-pas
>>      then:
>>        properties:
>> @@ -75,6 +79,23 @@ allOf:
>>            items:
>>              - const: lcx
>>              - const: lmx
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          enum:
>> +            - qcom,qcs8300-cdsp-pas
> 
> This looks the same as sa8775p cdsp. Why new entry?
> 
There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0
> Best regards,
> Krzysztof
> 
Thanks,
Jingyi

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

[Krzysztof Kozlowski]

On 28/08/2024 09:28, Jingyi Wang wrote:
> 
> 
> On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote:
>> On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote:
>>> Document the components used to boot the ADSP, CDSP and GPDSP on the
>>> QCS8300 SoC.
>>>
>>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>>> ---
>>>  .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++
>>>  1 file changed, 22 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>>> index 7fe401a06805..44b070a17ca0 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>>> @@ -16,6 +16,9 @@ description:
>>>  properties:
>>>    compatible:
>>>      enum:
>>> +      - qcom,qcs8300-adsp-pas
>>> +      - qcom,qcs8300-cdsp-pas
>>> +      - qcom,qcs8300-gpdsp-pas
>>>        - qcom,sa8775p-adsp-pas
>>>        - qcom,sa8775p-cdsp0-pas
>>>        - qcom,sa8775p-cdsp1-pas
>>> @@ -64,6 +67,7 @@ allOf:
>>>        properties:
>>>          compatible:
>>>            enum:
>>> +            - qcom,qcs8300-adsp-pas
>>>              - qcom,sa8775p-adsp-pas
>>>      then:
>>>        properties:
>>> @@ -75,6 +79,23 @@ allOf:
>>>            items:
>>>              - const: lcx
>>>              - const: lmx
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          enum:
>>> +            - qcom,qcs8300-cdsp-pas
>>
>> This looks the same as sa8775p cdsp. Why new entry?
>>
> There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0

Please paste code where do you see the difference.

Best regards,
Krzysztof

Re: [PATCH 2/2] remoteproc: qcom: pas: Add QCS8300 remoteproc support

[Aiqun Yu (Maria)]

On 8/28/2024 3:24 PM, Krzysztof Kozlowski wrote:
> On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote:
>> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300
>> platform.
>>
>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>>  drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++
>>  1 file changed, 55 insertions(+)
>>
>> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
>> index ef82835e98a4..368aa9cc0051 100644
>> --- a/drivers/remoteproc/qcom_q6v5_pas.c
>> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
>> @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = {
>>  	.ssctl_id = 0x14,
>>  };
>>  
>> +static const struct adsp_data qcs8300_adsp_resource = {
>> +	.crash_reason_smem = 423,
> 
> You just duplicate stuff. This is EXACTLY the same as SA8775p.

Agreed with you. Offline checked with Jingyi, she will remove the
creation and use sa8775p_adsp_resource directly.

Will it be ok to put the second patchset here along with the qcs8300
base dt changes together?
> 
> NAK.
> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Aiqun(Maria) Yu

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,sa8775p-pas: Document QCS8300 remoteproc

[Jingyi Wang]

On 8/28/2024 5:07 PM, Krzysztof Kozlowski wrote:
> On 28/08/2024 09:28, Jingyi Wang wrote:
>>
>>
>> On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote:
>>> On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote:
>>>> Document the components used to boot the ADSP, CDSP and GPDSP on the
>>>> QCS8300 SoC.
>>>>
>>>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com>
>>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>>>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>>>> ---
>>>>  .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++
>>>>  1 file changed, 22 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>>>> index 7fe401a06805..44b070a17ca0 100644
>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml
>>>> @@ -16,6 +16,9 @@ description:
>>>>  properties:
>>>>    compatible:
>>>>      enum:
>>>> +      - qcom,qcs8300-adsp-pas
>>>> +      - qcom,qcs8300-cdsp-pas
>>>> +      - qcom,qcs8300-gpdsp-pas
>>>>        - qcom,sa8775p-adsp-pas
>>>>        - qcom,sa8775p-cdsp0-pas
>>>>        - qcom,sa8775p-cdsp1-pas
>>>> @@ -64,6 +67,7 @@ allOf:
>>>>        properties:
>>>>          compatible:
>>>>            enum:
>>>> +            - qcom,qcs8300-adsp-pas
>>>>              - qcom,sa8775p-adsp-pas
>>>>      then:
>>>>        properties:
>>>> @@ -75,6 +79,23 @@ allOf:
>>>>            items:
>>>>              - const: lcx
>>>>              - const: lmx
>>>> +  - if:
>>>> +      properties:
>>>> +        compatible:
>>>> +          enum:
>>>> +            - qcom,qcs8300-cdsp-pas
>>>
>>> This looks the same as sa8775p cdsp. Why new entry?
>>>
>> There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0
> 
> Please paste code where do you see the difference.
> 
> Best regards,
> Krzysztof
> 
sorry my mistake, I have checked that nsp0 is form the view of power domain, it
should be fine to use "nsp" to find the right power domain, will cleanup both
binding and driver patch.

Thanks,
Jingyi