Re: [PATCH v1 6/6] drm/mediatek: Add support for MT8195 Digital Parallel Interface

["CK Hu (胡俊光)" <ck.hu@mediatek.com>]

On Mon, 2024-11-25 at 17:55 +0100, AngeloGioacchino Del Regno wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> Il 22/11/24 08:23, CK Hu (胡俊光) ha scritto:
> > Hi, Angelo:
> > 
> > On Wed, 2024-11-20 at 13:44 +0100, AngeloGioacchino Del Regno wrote:
> > > External email : Please do not click links or open attachments until you have verified the sender or the content.
> > > 
> > > 
> > > Add support for the DPI block found in the MT8195 and MT8188 SoCs.
> > > Inside of the SoC, this block is directly connected to the HDMI IP.
> > 
> > In MT8173, DPI0 is directly connected to HDMI.
> > The first version of this driver is just for MT8173 DPI0.
> > Does MT8173 DPI0 need this modification?
> > Or this modification is just for MT8188 and MT8195, then the description should be more than 'directly connected'.
> > 
> 
> This is only for MT8188 and MT8195, and MT8173 does *not* need any modification.
> 
> Please, what would you like to see in the description of this commit?

This patch does four jobs.

1. Enable/disable tvd_clk for MT8195/MT8188 DPI.
2. Do not set pixel clock for MT8195/MT8188 DPI.
3. New DPI_INPUT_XXX and DPI_OUTPUT_XXX control for MT8195/MT8188 DPI.
4. Do not power on/off for MT8195/MT8188 DPI.

Maybe you should break into 4 patches and each one has different reason.

For #1 and #2, I've not reviewed the HDMI driver. Is the clock control influenced by new HDMI driver.
If it is software reason, maybe we can modify the new HDMI driver and make DPI driver consistent with MT8173.
If it is hardware reason. just describe the hardware reason.

For #4, I don't know why DPI do not control power by its self?
Even though other driver may control the same power, power manager has reference count,
so each driver could control the same power by its self.

Regards,
CK


> 
> Cheers,
> Angelo
> 
> > Regards,
> > CK
> > 
> > > 
> > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> > > ---
> 
>