From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Aaron Kling <webgeek1234@gmail.com>, Val Packett <val@packett.cool>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Teguh Sobirin <teguh@sobir.in>
Subject: Re: [PATCH v2 2/5] arm64: dts: qcom: Add AYN QCS8550 Common
Date: Mon, 23 Mar 2026 10:39:18 +0100 [thread overview]
Message-ID: <fd8c59b8-c35e-4add-a028-5f029a09fe4c@oss.qualcomm.com> (raw)
In-Reply-To: <CALHNRZ97zmk0BmctznXrrnyyk50XH506GrdWSU-mEeN3NVEBFQ@mail.gmail.com>
On 3/19/26 11:31 PM, Aaron Kling wrote:
> On Wed, Mar 11, 2026 at 7:49 PM Val Packett <val@packett.cool> wrote:
>>
>> On 3/11/26 2:44 PM, Aaron Kling wrote:
>>
>>> From: Teguh Sobirin <teguh@sobir.in>
>>>
>>> This adds a base dtb of everything common between the AYN QCS8550
>>> devices. It is intended to be extended by device specific overlays.
>>>
>>> Signed-off-by: Teguh Sobirin <teguh@sobir.in>
>>> Co-developed-by: Aaron Kling <webgeek1234@gmail.com>
>>> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
>>> ---
>>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>>> arch/arm64/boot/dts/qcom/qcs8550-ayntec-common.dts | 1777 ++++++++++++++++++++
>>> 2 files changed, 1778 insertions(+)
>>> […]
>>> +/ {
>>> + model = "AYN QCS8550 Common";
>>> + compatible = "ayntec,qcs8550-common", "qcom,qcs8550", "qcom,sm8550";
>>
>> Huh?.. All existing -common files are .dtsi includes without their own
>> model/compatible, and the compile-time "dtbo" support is only used for
>> EL2 where we want to apply the same thing to many many devices without
>> polluting the tree with extra glue files. I don't see why this should be
>> a "common device" with its own compatible string, and not just a dtsi.
>>
>>> […]
>>> +&gpu {
>>> + status = "okay";
>>> +
>>> + zap-shader {
>>> + firmware-name = "qcom/sm8550/a740_zap.mbn";
>>> + };
>>> +};
>>
>> Please use the &gpu_zap_shader label.
>>
>> And does the generic zap actually just work?
>>
>>> […]
>>> +&i2c0 {
>>> + clock-frequency = <400000>;
>>> + status = "okay";
>>> +};
>>> +
>>> +&i2c4 {
>>> + clock-frequency = <400000>;
>>> + status = "okay";
>>> +};
>>> +
>>> +&i2c12 {
>>> + clock-frequency = <400000>;
>>> + status = "okay";
>>> +};
>> If the individual devices actually use these busses, better to enable
>> them inside of their .dts as well I think?
>>> +&iris {
>>> + status = "okay";
>>> +};
>> Works with generic firmware?
>>> […]
>>> +&pcie0 {
>>> + wake-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>;
>>> + perst-gpios = <&tlmm 94 GPIO_ACTIVE_LOW>;
>> Current binding is to put these inside of the &pcieportN (renaming
>> 'perst' to 'reset' which I just noticed I failed to do for one of my own
>> files :D), see x1e78100-lenovo-thinkpad-t14s.dtsi for an example.
>
> I tried making this change, but the pcie port failed to probe. I also
> notice that all existing sm8550 devices still use the 'old' syntax.
There's a ""feature"" in the parsing code that will only let this work if
both 'phys' and 'xxx-gpios' are under the same node (i.e. both under PCIe
OR both under the root port), I think this may be changed by a single big
change later on
Konrad
next prev parent reply other threads:[~2026-03-23 9:39 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 17:44 [PATCH v2 0/5] arm64: dts: qcom: Support AYN QCS8550 Devices Aaron Kling via B4 Relay
2026-03-11 17:44 ` [PATCH v2 1/5] dt-bindings: arm: qcom: Add " Aaron Kling via B4 Relay
2026-03-13 8:35 ` Krzysztof Kozlowski
2026-03-11 17:44 ` [PATCH v2 2/5] arm64: dts: qcom: Add AYN QCS8550 Common Aaron Kling via B4 Relay
2026-03-12 0:48 ` Val Packett
2026-03-12 1:39 ` Aaron Kling
2026-03-13 3:19 ` Dmitry Baryshkov
2026-03-13 8:37 ` Krzysztof Kozlowski
2026-03-13 17:34 ` Aaron Kling
2026-03-13 17:39 ` Krzysztof Kozlowski
2026-03-13 17:48 ` Dmitry Baryshkov
2026-03-13 18:21 ` Aaron Kling
2026-03-13 18:54 ` Dmitry Baryshkov
2026-03-14 0:11 ` Val Packett
2026-03-14 1:50 ` Aaron Kling
2026-03-19 18:04 ` Aaron Kling
2026-03-19 22:31 ` Aaron Kling
2026-03-23 9:39 ` Konrad Dybcio [this message]
2026-03-19 11:40 ` Konrad Dybcio
2026-03-19 18:39 ` Aaron Kling
2026-03-23 10:03 ` Konrad Dybcio
2026-03-11 17:44 ` [PATCH v2 3/5] arm64: dts: qcom: Add AYN Odin 2 Mini Aaron Kling via B4 Relay
2026-03-13 8:39 ` Krzysztof Kozlowski
2026-03-13 8:42 ` Krzysztof Kozlowski
2026-03-11 17:44 ` [PATCH v2 4/5] arm64: dts: qcom: Add AYN Odin 2 Portal Aaron Kling via B4 Relay
2026-03-11 17:44 ` [PATCH v2 5/5] arm64: dts: qcom: Add AYN Thor Aaron Kling via B4 Relay
2026-03-19 11:32 ` Konrad Dybcio
2026-03-19 17:48 ` Aaron Kling
2026-03-23 9:38 ` Konrad Dybcio
2026-03-23 10:00 ` Teguh Sobirin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd8c59b8-c35e-4add-a028-5f029a09fe4c@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=teguh@sobir.in \
--cc=val@packett.cool \
--cc=webgeek1234@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®