From: Randy Dunlap <rdunlap@infradead.org>
To: Laurent Vivier <lvivier@redhat.com>, linux-kernel@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] vdpasim: fix "mac_pton" undefined error
Date: Fri, 13 Nov 2020 10:49:10 -0800 [thread overview]
Message-ID: <fdab06b3-039b-df4b-243e-9cb0e940cc15@infradead.org> (raw)
In-Reply-To: <20201113155706.599434-1-lvivier@redhat.com>
On 11/13/20 7:57 AM, Laurent Vivier wrote:
> ERROR: modpost: "mac_pton" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
>
> mac_pton() is defined in lib/net_utils.c and is not built if NET is not set.
>
> Select GENERIC_NET_UTILS as vdpasim doesn't depend on NET.
>
> Reported-by: kernel test robot <lkp@intel.com>
On Nov. 2, 2020:
Reported-by: Randy Dunlap <rdunlap@infradead.org>
https://lore.kernel.org/lkml/d3d50a94-cdc5-572b-e9ca-3ee5638d21ee@infradead.org/
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> drivers/vdpa/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vdpa/Kconfig b/drivers/vdpa/Kconfig
> index d7d32b656102..358f6048dd3c 100644
> --- a/drivers/vdpa/Kconfig
> +++ b/drivers/vdpa/Kconfig
> @@ -13,6 +13,7 @@ config VDPA_SIM
> depends on RUNTIME_TESTING_MENU && HAS_DMA
> select DMA_OPS
> select VHOST_RING
> + select GENERIC_NET_UTILS
> default n
> help
> vDPA networking device simulator which loop TX traffic back
>
Thanks for the patch.
--
~Randy
next prev parent reply other threads:[~2020-11-13 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 15:57 Laurent Vivier
2020-11-13 18:49 ` Randy Dunlap [this message]
2020-11-13 19:31 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdab06b3-039b-df4b-243e-9cb0e940cc15@infradead.org \
--to=rdunlap@infradead.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®