From: "Christian König" <christian.koenig@amd.com>
To: Ding Yihan <dingyihan@uniontech.com>, alexander.deucher@amd.com
Cc: airlied@gmail.com, simona@ffwll.ch,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Fix typos in amdgpu_vm_bo_update comments
Date: Wed, 7 Jan 2026 13:47:08 +0100 [thread overview]
Message-ID: <fde4b6ec-a7d6-40e1-96a6-a2f4b601d583@amd.com> (raw)
In-Reply-To: <20251223044120.1574243-1-dingyihan@uniontech.com>
On 12/23/25 05:41, Ding Yihan wrote:
> Fix spelling mistakes in the comment block within amdgpu_vm_bo_update().
> Specifically, correct "contians" to "contains" and "WIRTEABLE" to
> "WRITEABLE".
>
> Additionally, improve the grammar, capitalization, and punctuation of
> the comment for better readability.
>
> Signed-off-by: Ding Yihan <dingyihan@uniontech.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index c362d4dfb5bb..502d32728008 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -1352,8 +1352,8 @@ int amdgpu_vm_bo_update(struct amdgpu_device *adev, struct amdgpu_bo_va *bo_va,
> list_for_each_entry(mapping, &bo_va->invalids, list) {
> uint64_t update_flags = flags;
>
> - /* normally,bo_va->flags only contians READABLE and WIRTEABLE bit go here
> - * but in case of something, we filter the flags in first place
> + /* Normally,bo_va->flags only contains READABLE and WRITEABLE bits here.
> + * But in case of something, we filter the flags in first place.
> */
> if (!(mapping->flags & AMDGPU_VM_PAGE_READABLE))
> update_flags &= ~AMDGPU_PTE_READABLE;
prev parent reply other threads:[~2026-01-07 12:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-23 4:41 Ding Yihan
2026-01-07 12:47 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fde4b6ec-a7d6-40e1-96a6-a2f4b601d583@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dingyihan@uniontech.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®