mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: shuah <shuah@kernel.org>
To: torvalds@linux-foundation.org
Cc: shuah <shuah@kernel.org>, Kees Cook <keescook@chromium.org>,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [GIT PULL] kselftest update for Linux 4.20-rc7
Date: Thu, 13 Dec 2018 13:37:08 -0700	[thread overview]
Message-ID: <fe1c6815-c338-e264-cd77-7d92457acf4c@kernel.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

Hi Linus,

Please pull the following Kselftest update for Linux 4.20-rc7.

This Kselftest update for Linux 4.20-rc7 consists of a single fix for
seccomp test from Kees Cook.

diff is attached.

thanks,
-- Shuah

----------------------------------------------------------------
The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest 
tags/linux-kselftest-4.20-rc7

for you to fetch changes up to 2bd61abead58c82714a1f6fa6beb0fd0df6a6d13:

   selftests/seccomp: Remove SIGSTOP si_pid check (2018-12-11 17:57:30 
-0700)

----------------------------------------------------------------
linux-kselftest-4.20-rc7

This Kselftest update for Linux 4.20-rc7 consists of a single fix for
seccomp test from Kees Cook.

----------------------------------------------------------------
Kees Cook (1):
       selftests/seccomp: Remove SIGSTOP si_pid check

  tools/testing/selftests/seccomp/seccomp_bpf.c | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------

[-- Attachment #2: linux-kselftest-4.20-rc7.diff --]
[-- Type: text/x-patch, Size: 1039 bytes --]

diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
index e1473234968d..c9a2abf8be1b 100644
--- a/tools/testing/selftests/seccomp/seccomp_bpf.c
+++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
@@ -2731,9 +2731,14 @@ TEST(syscall_restart)
 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
 	ASSERT_EQ(true, WIFSTOPPED(status));
 	ASSERT_EQ(SIGSTOP, WSTOPSIG(status));
-	/* Verify signal delivery came from parent now. */
 	ASSERT_EQ(0, ptrace(PTRACE_GETSIGINFO, child_pid, NULL, &info));
-	EXPECT_EQ(getpid(), info.si_pid);
+	/*
+	 * There is no siginfo on SIGSTOP any more, so we can't verify
+	 * signal delivery came from parent now (getpid() == info.si_pid).
+	 * https://lkml.kernel.org/r/CAGXu5jJaZAOzP1qFz66tYrtbuywqb+UN2SOA1VLHpCCOiYvYeg@mail.gmail.com
+	 * At least verify the SIGSTOP via PTRACE_GETSIGINFO.
+	 */
+	EXPECT_EQ(SIGSTOP, info.si_signo);
 
 	/* Restart nanosleep with SIGCONT, which triggers restart_syscall. */
 	ASSERT_EQ(0, kill(child_pid, SIGCONT));

             reply	other threads:[~2018-12-13 20:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 20:37 shuah [this message]
2018-12-13 21:15 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe1c6815-c338-e264-cd77-7d92457acf4c@kernel.org \
    --to=shuah@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®