mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [GIT PULL] kselftest update for Linux 4.20-rc7
@ 2018-12-13 20:37 shuah
  2018-12-13 21:15 ` pr-tracker-bot
  0 siblings, 1 reply; 2+ messages in thread
From: shuah @ 2018-12-13 20:37 UTC (permalink / raw)
  To: torvalds; +Cc: shuah, Kees Cook, linux-kselftest, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1203 bytes --]

Hi Linus,

Please pull the following Kselftest update for Linux 4.20-rc7.

This Kselftest update for Linux 4.20-rc7 consists of a single fix for
seccomp test from Kees Cook.

diff is attached.

thanks,
-- Shuah

----------------------------------------------------------------
The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a:

   Linux 4.20-rc1 (2018-11-04 15:37:52 -0800)

are available in the Git repository at:

   git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest 
tags/linux-kselftest-4.20-rc7

for you to fetch changes up to 2bd61abead58c82714a1f6fa6beb0fd0df6a6d13:

   selftests/seccomp: Remove SIGSTOP si_pid check (2018-12-11 17:57:30 
-0700)

----------------------------------------------------------------
linux-kselftest-4.20-rc7

This Kselftest update for Linux 4.20-rc7 consists of a single fix for
seccomp test from Kees Cook.

----------------------------------------------------------------
Kees Cook (1):
       selftests/seccomp: Remove SIGSTOP si_pid check

  tools/testing/selftests/seccomp/seccomp_bpf.c | 9 +++++++--
  1 file changed, 7 insertions(+), 2 deletions(-)
----------------------------------------------------------------

[-- Attachment #2: linux-kselftest-4.20-rc7.diff --]
[-- Type: text/x-patch, Size: 1039 bytes --]

diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
index e1473234968d..c9a2abf8be1b 100644
--- a/tools/testing/selftests/seccomp/seccomp_bpf.c
+++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
@@ -2731,9 +2731,14 @@ TEST(syscall_restart)
 	ASSERT_EQ(child_pid, waitpid(child_pid, &status, 0));
 	ASSERT_EQ(true, WIFSTOPPED(status));
 	ASSERT_EQ(SIGSTOP, WSTOPSIG(status));
-	/* Verify signal delivery came from parent now. */
 	ASSERT_EQ(0, ptrace(PTRACE_GETSIGINFO, child_pid, NULL, &info));
-	EXPECT_EQ(getpid(), info.si_pid);
+	/*
+	 * There is no siginfo on SIGSTOP any more, so we can't verify
+	 * signal delivery came from parent now (getpid() == info.si_pid).
+	 * https://lkml.kernel.org/r/CAGXu5jJaZAOzP1qFz66tYrtbuywqb+UN2SOA1VLHpCCOiYvYeg@mail.gmail.com
+	 * At least verify the SIGSTOP via PTRACE_GETSIGINFO.
+	 */
+	EXPECT_EQ(SIGSTOP, info.si_signo);
 
 	/* Restart nanosleep with SIGCONT, which triggers restart_syscall. */
 	ASSERT_EQ(0, kill(child_pid, SIGCONT));

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] kselftest update for Linux 4.20-rc7
  2018-12-13 20:37 [GIT PULL] kselftest update for Linux 4.20-rc7 shuah
@ 2018-12-13 21:15 ` pr-tracker-bot
  0 siblings, 0 replies; 2+ messages in thread
From: pr-tracker-bot @ 2018-12-13 21:15 UTC (permalink / raw)
  To: shuah; +Cc: torvalds, shuah, Kees Cook, linux-kselftest, linux-kernel

The pull request you sent on Thu, 13 Dec 2018 13:37:08 -0700:

> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest tags/linux-kselftest-4.20-rc7

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/65e08c5e86311143f45c3e4389561af3107fc8f6

Thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-13 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 20:37 [GIT PULL] kselftest update for Linux 4.20-rc7 shuah
2018-12-13 21:15 ` pr-tracker-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®