* [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM
@ 2025-08-18 11:33 George Moussalem via B4 Relay
2025-08-18 11:33 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible George Moussalem via B4 Relay
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: George Moussalem via B4 Relay @ 2025-08-18 11:33 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sricharan Ramabadhran, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
George Moussalem, Dmitry Baryshkov, Krzysztof Kozlowski,
Konrad Dybcio
The tsens IP found in the IPQ5018 SoC should not use qcom,tsens-v1 as
fallback since it has no RPM and, as such, must deviate from the
standard v1 init routine as this version of tsens needs to be explicitly
reset and enabled in the driver.
Accordingly, update the tsens node in the IPQ5018 dts and remove the
fallback compatible.
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
Additional background: this was already incorporated in the patch series
which added support for IPQ5018 tsens initially. V9 was applied while
v13 had already been sent for review. In agreement with Bjorn Andersson,
I've submitted this new patch set to correct the issue.
I have taken the liberty to re-apply RB tags provided by Krzysztof,
Konrad, and Dmitry from:
https://lore.kernel.org/r/20250718-ipq5018-tsens-v14-0-28d8a2472418@outlook.com
---
George Moussalem (2):
dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible
arm64: dts: qcom: ipq5018: Remove tsens v1 fallback compatible
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 ++++++-
arch/arm64/boot/dts/qcom/ipq5018.dtsi | 2 +-
2 files changed, 7 insertions(+), 2 deletions(-)
---
base-commit: 3ac864c2d9bb8608ee236e89bf561811613abfce
change-id: 20250818-ipq5018-tsens-fix-f60d53e6eda7
Best regards,
--
George Moussalem <george.moussalem@outlook.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible
2025-08-18 11:33 [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM George Moussalem via B4 Relay
@ 2025-08-18 11:33 ` George Moussalem via B4 Relay
2025-10-27 14:59 ` Bjorn Andersson
2025-11-25 9:58 ` Daniel Lezcano
2025-08-18 11:33 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: Remove tsens v1 fallback compatible George Moussalem via B4 Relay
2026-01-05 14:07 ` (subset) [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM Bjorn Andersson
2 siblings, 2 replies; 7+ messages in thread
From: George Moussalem via B4 Relay @ 2025-08-18 11:33 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sricharan Ramabadhran, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
George Moussalem, Dmitry Baryshkov, Krzysztof Kozlowski
From: George Moussalem <george.moussalem@outlook.com>
The tsens IP found in the IPQ5018 SoC should not use qcom,tsens-v1 as
fallback since it has no RPM and, as such, must deviate from the
standard v1 init routine as this version of tsens needs to be explicitly
reset and enabled in the driver.
So let's make qcom,ipq5018-tsens a standalone compatible in the bindings.
Fixes: 77c6d28192ef ("dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible")
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index 94311ebd7652d42eb6f3ae0dba792872c90b623f..9f342e63bdb1d27bd12373fb4c7611964bfd8d4b 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -36,10 +36,15 @@ properties:
- qcom,msm8974-tsens
- const: qcom,tsens-v0_1
+ - description:
+ v1 of TSENS without RPM which requires to be explicitly reset
+ and enabled in the driver.
+ enum:
+ - qcom,ipq5018-tsens
+
- description: v1 of TSENS
items:
- enum:
- - qcom,ipq5018-tsens
- qcom,msm8937-tsens
- qcom,msm8956-tsens
- qcom,msm8976-tsens
--
2.50.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: ipq5018: Remove tsens v1 fallback compatible
2025-08-18 11:33 [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM George Moussalem via B4 Relay
2025-08-18 11:33 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible George Moussalem via B4 Relay
@ 2025-08-18 11:33 ` George Moussalem via B4 Relay
2026-01-05 14:07 ` (subset) [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM Bjorn Andersson
2 siblings, 0 replies; 7+ messages in thread
From: George Moussalem via B4 Relay @ 2025-08-18 11:33 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sricharan Ramabadhran, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
George Moussalem, Dmitry Baryshkov, Konrad Dybcio
From: George Moussalem <george.moussalem@outlook.com>
Remove qcom,tsens-v1 as fallback compatible since this IP has no RPM
and, as such, must use its own init routine available in the driver.
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: George Moussalem <george.moussalem@outlook.com>
---
arch/arm64/boot/dts/qcom/ipq5018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
index 4ddb56d63f8f9a963cb49bc20e0a78b2d3490344..db7051a659221d45949cda93472e52c49815531f 100644
--- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
@@ -340,7 +340,7 @@ prng: rng@e3000 {
};
tsens: thermal-sensor@4a9000 {
- compatible = "qcom,ipq5018-tsens", "qcom,tsens-v1";
+ compatible = "qcom,ipq5018-tsens";
reg = <0x004a9000 0x1000>,
<0x004a8000 0x1000>;
--
2.50.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible
2025-08-18 11:33 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible George Moussalem via B4 Relay
@ 2025-10-27 14:59 ` Bjorn Andersson
2025-11-25 9:58 ` Daniel Lezcano
1 sibling, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2025-10-27 14:59 UTC (permalink / raw)
To: george.moussalem
Cc: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sricharan Ramabadhran, Konrad Dybcio, linux-pm,
linux-arm-msm, devicetree, linux-kernel, Dmitry Baryshkov,
Krzysztof Kozlowski
On Mon, Aug 18, 2025 at 03:33:46PM +0400, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> The tsens IP found in the IPQ5018 SoC should not use qcom,tsens-v1 as
> fallback since it has no RPM and, as such, must deviate from the
> standard v1 init routine as this version of tsens needs to be explicitly
> reset and enabled in the driver.
>
> So let's make qcom,ipq5018-tsens a standalone compatible in the bindings.
>
> Fixes: 77c6d28192ef ("dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Regards,
Bjorn
> ---
> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 94311ebd7652d42eb6f3ae0dba792872c90b623f..9f342e63bdb1d27bd12373fb4c7611964bfd8d4b 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -36,10 +36,15 @@ properties:
> - qcom,msm8974-tsens
> - const: qcom,tsens-v0_1
>
> + - description:
> + v1 of TSENS without RPM which requires to be explicitly reset
> + and enabled in the driver.
> + enum:
> + - qcom,ipq5018-tsens
> +
> - description: v1 of TSENS
> items:
> - enum:
> - - qcom,ipq5018-tsens
> - qcom,msm8937-tsens
> - qcom,msm8956-tsens
> - qcom,msm8976-tsens
>
> --
> 2.50.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible
2025-08-18 11:33 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible George Moussalem via B4 Relay
2025-10-27 14:59 ` Bjorn Andersson
@ 2025-11-25 9:58 ` Daniel Lezcano
2025-11-26 6:41 ` George Moussalem
1 sibling, 1 reply; 7+ messages in thread
From: Daniel Lezcano @ 2025-11-25 9:58 UTC (permalink / raw)
To: george.moussalem, Amit Kucheria, Thara Gopinath,
Rafael J. Wysocki, Zhang Rui, Lukasz Luba, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Sricharan Ramabadhran,
Bjorn Andersson, Konrad Dybcio
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
Dmitry Baryshkov, Krzysztof Kozlowski
On 8/18/25 13:33, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@outlook.com>
>
> The tsens IP found in the IPQ5018 SoC should not use qcom,tsens-v1 as
> fallback since it has no RPM and, as such, must deviate from the
> standard v1 init routine as this version of tsens needs to be explicitly
> reset and enabled in the driver.
>
> So let's make qcom,ipq5018-tsens a standalone compatible in the bindings.
>
> Fixes: 77c6d28192ef ("dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible")
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
> ---
Applied patch 1/2
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible
2025-11-25 9:58 ` Daniel Lezcano
@ 2025-11-26 6:41 ` George Moussalem
0 siblings, 0 replies; 7+ messages in thread
From: George Moussalem @ 2025-11-26 6:41 UTC (permalink / raw)
To: Daniel Lezcano, Amit Kucheria, Thara Gopinath, Rafael J. Wysocki,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sricharan Ramabadhran, Bjorn Andersson,
Konrad Dybcio
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
Dmitry Baryshkov, Krzysztof Kozlowski
On 11/25/25 13:58, Daniel Lezcano wrote:
> On 8/18/25 13:33, George Moussalem via B4 Relay wrote:
>> From: George Moussalem <george.moussalem@outlook.com>
>>
>> The tsens IP found in the IPQ5018 SoC should not use qcom,tsens-v1 as
>> fallback since it has no RPM and, as such, must deviate from the
>> standard v1 init routine as this version of tsens needs to be explicitly
>> reset and enabled in the driver.
>>
>> So let's make qcom,ipq5018-tsens a standalone compatible in the bindings.
>>
>> Fixes: 77c6d28192ef ("dt-bindings: thermal: qcom-tsens: Add ipq5018 compatible")
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
>> ---
>
> Applied patch 1/2
Thank you, Daniel.
Can this also be backported to 6.18 as it's currently broke?
>
> Thanks
>
> -- Daniel
>
Best regards,
George
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM
2025-08-18 11:33 [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM George Moussalem via B4 Relay
2025-08-18 11:33 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible George Moussalem via B4 Relay
2025-08-18 11:33 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: Remove tsens v1 fallback compatible George Moussalem via B4 Relay
@ 2026-01-05 14:07 ` Bjorn Andersson
2 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2026-01-05 14:07 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Sricharan Ramabadhran, Konrad Dybcio,
George Moussalem
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
Dmitry Baryshkov, Konrad Dybcio, Krzysztof Kozlowski
On Mon, 18 Aug 2025 15:33:45 +0400, George Moussalem wrote:
> The tsens IP found in the IPQ5018 SoC should not use qcom,tsens-v1 as
> fallback since it has no RPM and, as such, must deviate from the
> standard v1 init routine as this version of tsens needs to be explicitly
> reset and enabled in the driver.
>
> Accordingly, update the tsens node in the IPQ5018 dts and remove the
> fallback compatible.
>
> [...]
Applied, thanks!
[2/2] arm64: dts: qcom: ipq5018: Remove tsens v1 fallback compatible
commit: 60fb18fbc234efb2d59472a889282dba2df3402a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-01-05 14:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-18 11:33 [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM George Moussalem via B4 Relay
2025-08-18 11:33 ` [PATCH 1/2] dt-bindings: thermal: qcom-tsens: make ipq5018 tsens standalone compatible George Moussalem via B4 Relay
2025-10-27 14:59 ` Bjorn Andersson
2025-11-25 9:58 ` Daniel Lezcano
2025-11-26 6:41 ` George Moussalem
2025-08-18 11:33 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: Remove tsens v1 fallback compatible George Moussalem via B4 Relay
2026-01-05 14:07 ` (subset) [PATCH 0/2] Make standalone compatible for IPQ5018 tsens v1 without RPM Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®