Re: [PATCH v3 06/14] gpu: nova-core: Add bindings required by GSP sequencer

[Joel Fernandes <joelagnelf@nvidia.com>]

On 11/11/2025 4:43 PM, Lyude Paul wrote:
> Doesn't this still need to be abstracted out?
> 
> vvvvvv

Yes, coming up in v4, already done.

Thanks.



> 
> On Thu, 2025-11-06 at 18:11 -0500, Joel Fernandes wrote:
>>  
>> +#[expect(unused)]
>> +pub(crate) use r570_144::{
>> +    // GSP sequencer run structure with information on how to run the sequencer.
>> +    rpc_run_cpu_sequencer_v17_00,
>> +
>> +    // GSP sequencer structures.
>> +    GSP_SEQUENCER_BUFFER_CMD,
>> +    GSP_SEQ_BUF_OPCODE,
>> +
>> +    // GSP sequencer core operation opcodes.
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_CORE_RESET,
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_CORE_RESUME,
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_CORE_START,
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_CORE_WAIT_FOR_HALT,
>> +
>> +    // GSP sequencer delay opcode and payload.
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_DELAY_US,
>> +
>> +    // GSP sequencer register opcodes.
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_REG_MODIFY,
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_REG_POLL,
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_REG_STORE,
>> +    GSP_SEQ_BUF_OPCODE_GSP_SEQ_BUF_OPCODE_REG_WRITE,
>> +
>> +    // GSP sequencer delay payload structure.
>> +    GSP_SEQ_BUF_PAYLOAD_DELAY_US,
>> +
>> +    // GSP sequencer register payload structures.
>> +    GSP_SEQ_BUF_PAYLOAD_REG_MODIFY,
>> +    GSP_SEQ_BUF_PAYLOAD_REG_POLL,
>> +    GSP_SEQ_BUF_PAYLOAD_REG_STORE,
>> +    GSP_SEQ_BUF_PAYLOAD_REG_WRITE, //
>> +};
>> +
>