mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] arm64: dts: qcom: Add EC support for Purwa IOT EVK
@ 2026-06-29 10:40 Anvesh Jain P
  2026-06-29 10:40 ` [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add " Anvesh Jain P
  2026-06-29 10:40 ` [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node Anvesh Jain P
  0 siblings, 2 replies; 8+ messages in thread
From: Anvesh Jain P @ 2026-06-29 10:40 UTC (permalink / raw)
  To: Sibi Sankar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, devicetree, linux-kernel, Anvesh Jain P

Add the embedded controller node to the Purwa IOT EVK board and document
its compatible. The EC provides fan control, temperature sensors and EC
state change notifications.

Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
---
Anvesh Jain P (2):
      dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add Purwa IOT EVK
      arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node

 .../bindings/embedded-controller/qcom,hamoa-crd-ec.yaml  |  1 +
 arch/arm64/boot/dts/qcom/purwa-iot-evk.dts               | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)
---
base-commit: 948efecf22e49aa4bf55bb73ec79a0ddcfd38571
change-id: 20260629-ec_support_for_purwa_evk-687780bec098

Best regards,
-- 
Anvesh Jain P <anvesh.p@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add Purwa IOT EVK
  2026-06-29 10:40 [PATCH 0/2] arm64: dts: qcom: Add EC support for Purwa IOT EVK Anvesh Jain P
@ 2026-06-29 10:40 ` Anvesh Jain P
  2026-06-30  7:19   ` Krzysztof Kozlowski
  2026-06-29 10:40 ` [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node Anvesh Jain P
  1 sibling, 1 reply; 8+ messages in thread
From: Anvesh Jain P @ 2026-06-29 10:40 UTC (permalink / raw)
  To: Sibi Sankar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, devicetree, linux-kernel, Anvesh Jain P

Document the qcom,purwa-iot-evk-ec compatible for the embedded controller
found on Purwa IOT EVK boards. Like the other reference designs, it uses
qcom,hamoa-crd-ec as its fallback compatible.

Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
---
 .../devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml
index ac5a08f8f76d..c07483aa5937 100644
--- a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml
+++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml
@@ -22,6 +22,7 @@ properties:
           - enum:
               - qcom,glymur-crd-ec
               - qcom,hamoa-iot-evk-ec
+              - qcom,purwa-iot-evk-ec
           - const: qcom,hamoa-crd-ec
       - enum:
           - qcom,hamoa-crd-ec

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node
  2026-06-29 10:40 [PATCH 0/2] arm64: dts: qcom: Add EC support for Purwa IOT EVK Anvesh Jain P
  2026-06-29 10:40 ` [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add " Anvesh Jain P
@ 2026-06-29 10:40 ` Anvesh Jain P
  2026-06-29 10:55   ` Dmitry Baryshkov
                     ` (2 more replies)
  1 sibling, 3 replies; 8+ messages in thread
From: Anvesh Jain P @ 2026-06-29 10:40 UTC (permalink / raw)
  To: Sibi Sankar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, devicetree, linux-kernel, Anvesh Jain P

Add embedded controller node for Purwa IOT EVK boards which adds fan
control, temperature sensors, access to EC internal state changes and
suspend entry/exit notifications to the EC.

Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
index ad503beec1d3..491ea7769cd7 100644
--- a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
+++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
@@ -837,6 +837,16 @@ eusb6_repeater: redriver@4f {
 		pinctrl-0 = <&eusb6_reset_n>;
 		pinctrl-names = "default";
 	};
+
+	embedded-controller@76 {
+		compatible = "qcom,purwa-iot-evk-ec", "qcom,hamoa-crd-ec";
+		reg = <0x76>;
+
+		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
+
+		pinctrl-0 = <&ec_int_n_default>;
+		pinctrl-names = "default";
+	};
 };
 
 &i2c7 {
@@ -1326,6 +1336,12 @@ right_tweeter: speaker@0,1 {
 };
 
 &tlmm {
+	ec_int_n_default: ec-int-n-state {
+		pins = "gpio66";
+		function = "gpio";
+		bias-disable;
+	};
+
 	edp_reg_en: edp-reg-en-state {
 		pins = "gpio70";
 		function = "gpio";

-- 
2.34.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node
  2026-06-29 10:40 ` [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node Anvesh Jain P
@ 2026-06-29 10:55   ` Dmitry Baryshkov
  2026-06-29 11:58   ` Konrad Dybcio
  2026-06-30 11:55   ` Yushan Li
  2 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2026-06-29 10:55 UTC (permalink / raw)
  To: Anvesh Jain P
  Cc: Sibi Sankar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio, linux-arm-msm, devicetree,
	linux-kernel

On Mon, Jun 29, 2026 at 04:10:18PM +0530, Anvesh Jain P wrote:
> Add embedded controller node for Purwa IOT EVK boards which adds fan
> control, temperature sensors, access to EC internal state changes and
> suspend entry/exit notifications to the EC.
> 
> Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node
  2026-06-29 10:40 ` [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node Anvesh Jain P
  2026-06-29 10:55   ` Dmitry Baryshkov
@ 2026-06-29 11:58   ` Konrad Dybcio
  2026-06-30 11:55   ` Yushan Li
  2 siblings, 0 replies; 8+ messages in thread
From: Konrad Dybcio @ 2026-06-29 11:58 UTC (permalink / raw)
  To: Anvesh Jain P, Sibi Sankar, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, devicetree, linux-kernel

On 6/29/26 12:40 PM, Anvesh Jain P wrote:
> Add embedded controller node for Purwa IOT EVK boards which adds fan
> control, temperature sensors, access to EC internal state changes and
> suspend entry/exit notifications to the EC.
> 
> Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add Purwa IOT EVK
  2026-06-29 10:40 ` [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add " Anvesh Jain P
@ 2026-06-30  7:19   ` Krzysztof Kozlowski
  2026-06-30 14:56     ` Anvesh Jain P
  0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2026-06-30  7:19 UTC (permalink / raw)
  To: Anvesh Jain P
  Cc: Sibi Sankar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio, linux-arm-msm, devicetree,
	linux-kernel

On Mon, Jun 29, 2026 at 04:10:17PM +0530, Anvesh Jain P wrote:
> Document the qcom,purwa-iot-evk-ec compatible for the embedded controller
> found on Purwa IOT EVK boards. Like the other reference designs, it uses

EC on an IoT device? This needs some explanation of hardware.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node
  2026-06-29 10:40 ` [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node Anvesh Jain P
  2026-06-29 10:55   ` Dmitry Baryshkov
  2026-06-29 11:58   ` Konrad Dybcio
@ 2026-06-30 11:55   ` Yushan Li
  2 siblings, 0 replies; 8+ messages in thread
From: Yushan Li @ 2026-06-30 11:55 UTC (permalink / raw)
  To: Anvesh Jain P, Sibi Sankar, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Bjorn Andersson, Konrad Dybcio
  Cc: linux-arm-msm, devicetree, linux-kernel



On 6/29/2026 6:40 PM, Anvesh Jain P wrote:
> Add embedded controller node for Purwa IOT EVK boards which adds fan
> control, temperature sensors, access to EC internal state changes and
> suspend entry/exit notifications to the EC.
> 
> Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/purwa-iot-evk.dts | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> index ad503beec1d3..491ea7769cd7 100644
> --- a/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/purwa-iot-evk.dts
> @@ -837,6 +837,16 @@ eusb6_repeater: redriver@4f {
>   		pinctrl-0 = <&eusb6_reset_n>;
>   		pinctrl-names = "default";
>   	};
> +
> +	embedded-controller@76 {
> +		compatible = "qcom,purwa-iot-evk-ec", "qcom,hamoa-crd-ec";
> +		reg = <0x76>;
> +
> +		interrupts-extended = <&tlmm 66 IRQ_TYPE_EDGE_FALLING>;
> +
> +		pinctrl-0 = <&ec_int_n_default>;
> +		pinctrl-names = "default";
> +	};
>   };
>   
>   &i2c7 {
> @@ -1326,6 +1336,12 @@ right_tweeter: speaker@0,1 {
>   };
>   
>   &tlmm {
> +	ec_int_n_default: ec-int-n-state {
> +		pins = "gpio66";
> +		function = "gpio";
> +		bias-disable;
> +	};
> +
>   	edp_reg_en: edp-reg-en-state {
>   		pins = "gpio70";
>   		function = "gpio";
> 
Tested-by: Yushan Li <yushan.li@oss.qualcomm.com>

-- 
Regards,
Yushan

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add Purwa IOT EVK
  2026-06-30  7:19   ` Krzysztof Kozlowski
@ 2026-06-30 14:56     ` Anvesh Jain P
  0 siblings, 0 replies; 8+ messages in thread
From: Anvesh Jain P @ 2026-06-30 14:56 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Sibi Sankar, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Bjorn Andersson, Konrad Dybcio, linux-arm-msm, devicetree,
	linux-kernel



On 6/30/2026 12:49 PM, Krzysztof Kozlowski wrote:
> On Mon, Jun 29, 2026 at 04:10:17PM +0530, Anvesh Jain P wrote:
>> Document the qcom,purwa-iot-evk-ec compatible for the embedded controller
>> found on Purwa IOT EVK boards. Like the other reference designs, it uses
> 
> EC on an IoT device? This needs some explanation of hardware.
> 
> Best regards,
> Krzysztof
> 

The "IOT EVK" boards are full Snapdragon reference/development kits, not
small sensor-class IoT devices. Like the CRD, the Purwa IOT EVK carries
an on-board embedded controller (on a separate MCU) that handles fan
control, temperature sensors and EC state-change/suspend notifications.
The existing hamoa-iot-evk board already documents the same EC via
qcom,hamoa-iot-evk-ec.

If needed I can expand the commit message to explain this.

-- 
Best Regards,
Anvesh


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2026-06-30 14:56 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-06-29 10:40 [PATCH 0/2] arm64: dts: qcom: Add EC support for Purwa IOT EVK Anvesh Jain P
2026-06-29 10:40 ` [PATCH 1/2] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add " Anvesh Jain P
2026-06-30  7:19   ` Krzysztof Kozlowski
2026-06-30 14:56     ` Anvesh Jain P
2026-06-29 10:40 ` [PATCH 2/2] arm64: dts: qcom: purwa-iot-evk: Add Embedded controller node Anvesh Jain P
2026-06-29 10:55   ` Dmitry Baryshkov
2026-06-29 11:58   ` Konrad Dybcio
2026-06-30 11:55   ` Yushan Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox