mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: simran singhal <singhalsimran0@gmail.com>, lars@metafoo.de
Cc: Michael.Hennerich@analog.com, knaack.h@gmx.de,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v1 10/10] staging: iio: gyro: Remove exceptional & on function name
Date: Sat, 11 Mar 2017 18:57:14 +0000	[thread overview]
Message-ID: <fe7cde0d-41a1-a20a-53bc-87f2639a3edf@kernel.org> (raw)
In-Reply-To: <563954e3-76f4-d563-1328-3525d15ffdff@kernel.org>

On 11/03/17 18:48, Jonathan Cameron wrote:
> On 11/03/17 14:26, simran singhal wrote:
>> Remove & from function pointers to conform to the style found elsewhere
>> in the file.  Done using the following semantic patch
>>
>> // <smpl>
>> @r@
>> identifier f;
>> @@
>>
>> f(...) { ... }
>> @@
>> identifier r.f;
>> @@
>>
>> - &f
>> + f
>> // </smpl>
>>
>> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> Again, I couldn't identify any other function pointers in this file
> so have amended the patch description to reflect that.
> 
> I also added a note that will hopefully prevent anyone seeing
> this patch deciding to send me the several hundred patches it
> 'might' - I haven't checked - take to clean up the whole subsystem.
> 
> Thanks for the whole series.
> 
> Applied to the togreg branhc of iio.git and pushed out as testing.
I spoke to soon. Something odd going on with kernel.org wrt to my
connection to it at least.   Will try to push out again later.

Jonathan
> 
> Jonathan
>> ---
>>  drivers/staging/iio/gyro/adis16060_core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/gyro/adis16060_core.c b/drivers/staging/iio/gyro/adis16060_core.c
>> index ab816a2..c9d46e7 100644
>> --- a/drivers/staging/iio/gyro/adis16060_core.c
>> +++ b/drivers/staging/iio/gyro/adis16060_core.c
>> @@ -117,7 +117,7 @@ static int adis16060_read_raw(struct iio_dev *indio_dev,
>>  }
>>  
>>  static const struct iio_info adis16060_info = {
>> -	.read_raw = &adis16060_read_raw,
>> +	.read_raw = adis16060_read_raw,
>>  	.driver_module = THIS_MODULE,
>>  };
>>  
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2017-03-11 18:57 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-11 14:26 [PATCH v1 00/10] staging: iio: Remove exceptional & on functions name simran singhal
2017-03-11 14:26 ` [PATCH v1 01/10] staging: iio: ad7192: Remove exceptional & on function name simran singhal
2017-03-11 18:36   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 02/10] staging: iio: ad7780: " simran singhal
2017-03-11 18:37   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 03/10] staging: iio: cdc: ad7746: " simran singhal
2017-03-11 18:39   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 04/10] staging: iio: cdc: ad7152: " simran singhal
2017-03-11 18:40   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 05/10] staging: iio: adis16240: " simran singhal
2017-03-11 18:40   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 06/10] staging: iio: adis16201: " simran singhal
2017-03-11 18:41   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 07/10] staging: iio: adis16209: " simran singhal
2017-03-11 18:41   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 08/10] staging: iio: adis16203: " simran singhal
2017-03-11 18:41   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 09/10] staging: iio: resolver: " simran singhal
2017-03-11 18:45   ` Jonathan Cameron
2017-03-11 14:26 ` [PATCH v1 10/10] staging: iio: gyro: " simran singhal
2017-03-11 18:48   ` Jonathan Cameron
2017-03-11 18:57     ` Jonathan Cameron [this message]
2017-03-11 18:35 ` [PATCH v1 00/10] staging: iio: Remove exceptional & on functions name Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe7cde0d-41a1-a20a-53bc-87f2639a3edf@kernel.org \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=singhalsimran0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®