mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
@ 2010-01-23  2:34 H. Peter Anvin
  0 siblings, 0 replies; 7+ messages in thread
From: H. Peter Anvin @ 2010-01-23  2:34 UTC (permalink / raw)
  To: Linus Torvalds, Andrew Morton
  Cc: Rafael J. Wysocki, Ozan Çağlayan, Yinghai Lu,
	linux-kernel, mingo, a.p.zijlstra, stable,
	Jaswinder Singh Rajput, Thomas Gleixner

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

Makes sense.  Will do.

"Linus Torvalds" <torvalds@linux-foundation.org> wrote:

>
>
>On Fri, 22 Jan 2010, Andrew Morton wrote:
>> 
>> We know that enabling this feature will cause some machines to hang,
>> and that this problem has existed for six months.
>> 
>> Would it not be better to fix that problem (perhaps just with the
>> revert) so that 2.6.33, 2.6.32.x and earlier can be fixed?  Then we can
>> nuke the feature in 2.6.34.
>
>Another way of looking at is "we know it's been broken for six months, and 
>clearly nobody really ever enabled it in any distro, and even getting a 
>bug report on it took forever. So why keep it around at all"?
>
>So I'd personally rather just remove it outright than deprecate it or even 
>try to fix it. Since clearly absolutely nobody depends on it.
>
>The usual reason for deprecating a feature is to give people time to move 
>away from it, but since clearly nobody uses it...
>
>		Linus

--
Sent from my mobile phone, pardon any lack of formatting.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
  2010-01-23  1:59           ` Linus Torvalds
@ 2010-01-23  5:22             ` Ingo Molnar
  0 siblings, 0 replies; 7+ messages in thread
From: Ingo Molnar @ 2010-01-23  5:22 UTC (permalink / raw)
  To: Linus Torvalds
  Cc: Andrew Morton, H. Peter Anvin, Rafael J. Wysocki,
	Ozan ??a??layan, Yinghai Lu, linux-kernel, a.p.zijlstra, stable,
	Jaswinder Singh Rajput, Thomas Gleixner


* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Fri, 22 Jan 2010, Andrew Morton wrote:
> > 
> > We know that enabling this feature will cause some machines to hang,
> > and that this problem has existed for six months.
> > 
> > Would it not be better to fix that problem (perhaps just with the
> > revert) so that 2.6.33, 2.6.32.x and earlier can be fixed?  Then we can
> > nuke the feature in 2.6.34.
> 
> Another way of looking at is "we know it's been broken for six months, and 
> clearly nobody really ever enabled it in any distro, and even getting a bug 
> report on it took forever. So why keep it around at all"?
> 
> So I'd personally rather just remove it outright than deprecate it or even 
> try to fix it. Since clearly absolutely nobody depends on it.
> 
> The usual reason for deprecating a feature is to give people time to move 
> away from it, but since clearly nobody uses it...

Excellent - that makes it all even simpler to handle.

	Ingo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
  2010-01-23  0:53         ` Andrew Morton
  2010-01-23  1:05           ` H. Peter Anvin
@ 2010-01-23  1:59           ` Linus Torvalds
  2010-01-23  5:22             ` Ingo Molnar
  1 sibling, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2010-01-23  1:59 UTC (permalink / raw)
  To: Andrew Morton
  Cc: H. Peter Anvin, Rafael J. Wysocki, Ozan Çağlayan,
	Yinghai Lu, linux-kernel, mingo, a.p.zijlstra, stable,
	Jaswinder Singh Rajput, Thomas Gleixner



On Fri, 22 Jan 2010, Andrew Morton wrote:
> 
> We know that enabling this feature will cause some machines to hang,
> and that this problem has existed for six months.
> 
> Would it not be better to fix that problem (perhaps just with the
> revert) so that 2.6.33, 2.6.32.x and earlier can be fixed?  Then we can
> nuke the feature in 2.6.34.

Another way of looking at is "we know it's been broken for six months, and 
clearly nobody really ever enabled it in any distro, and even getting a 
bug report on it took forever. So why keep it around at all"?

So I'd personally rather just remove it outright than deprecate it or even 
try to fix it. Since clearly absolutely nobody depends on it.

The usual reason for deprecating a feature is to give people time to move 
away from it, but since clearly nobody uses it...

		Linus

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
  2010-01-23  0:53         ` Andrew Morton
@ 2010-01-23  1:05           ` H. Peter Anvin
  2010-01-23  1:59           ` Linus Torvalds
  1 sibling, 0 replies; 7+ messages in thread
From: H. Peter Anvin @ 2010-01-23  1:05 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Rafael J. Wysocki, Ozan Çağlayan, Yinghai Lu,
	linux-kernel, mingo, a.p.zijlstra, stable, Linus Torvalds,
	Jaswinder Singh Rajput, Thomas Gleixner

On 01/22/2010 04:53 PM, Andrew Morton wrote:
> 
> Would it not be better to fix that problem (perhaps just with the
> revert) so that 2.6.33, 2.6.32.x and earlier can be fixed?  Then we can
> nuke the feature in 2.6.34.
> 
> Alternatively, we can nuke the feature from 2.6.33 and 2.6.32.x and
> earlier right now.  Where "nuke" might mean "make it difficult to
> enable".
> 
> Whatever.  Bottom line is that it'd be nice to do something to fix up
> 2.6.33 and earlier.
> 

I would be all for nuking the feature immediately.  The easiest way to
nuke the feature quickly is to make it a noninteractive Kconfig feature.

All in favor?

	-hpa

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
  2010-01-18  1:26       ` RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal H. Peter Anvin
  2010-01-18 21:28         ` Rafael J. Wysocki
@ 2010-01-23  0:53         ` Andrew Morton
  2010-01-23  1:05           ` H. Peter Anvin
  2010-01-23  1:59           ` Linus Torvalds
  1 sibling, 2 replies; 7+ messages in thread
From: Andrew Morton @ 2010-01-23  0:53 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Rafael J. Wysocki, Ozan Çağlayan, Yinghai Lu,
	linux-kernel, mingo, a.p.zijlstra, stable, Linus Torvalds,
	Jaswinder Singh Rajput, Thomas Gleixner

On Sun, 17 Jan 2010 17:26:53 -0800
"H. Peter Anvin" <hpa@zytor.com> wrote:

> CONFIG_X86_CPU_DEBUG really seems to be causing more problems than it
> ever solved.  This is an RFC for immediately deprecating it, and
> schedule it for removal in the 2.6.34 cycle.
> 
> If this was a high value feature, it would be different -- but it's not
> even close.
> 
> Posting this as an RFC just on the offchance someone actually depends on
> this.
> 

We know that enabling this feature will cause some machines to hang,
and that this problem has existed for six months.

Would it not be better to fix that problem (perhaps just with the
revert) so that 2.6.33, 2.6.32.x and earlier can be fixed?  Then we can
nuke the feature in 2.6.34.

Alternatively, we can nuke the feature from 2.6.33 and 2.6.32.x and
earlier right now.  Where "nuke" might mean "make it difficult to
enable".

Whatever.  Bottom line is that it'd be nice to do something to fix up
2.6.33 and earlier.


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
  2010-01-18  1:26       ` RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal H. Peter Anvin
@ 2010-01-18 21:28         ` Rafael J. Wysocki
  2010-01-23  0:53         ` Andrew Morton
  1 sibling, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2010-01-18 21:28 UTC (permalink / raw)
  To: H. Peter Anvin
  Cc: Ozan Çağlayan, Yinghai Lu, linux-kernel, mingo,
	a.p.zijlstra, stable, Linus Torvalds, Andrew Morton,
	Jaswinder Singh Rajput, Thomas Gleixner

On Monday 18 January 2010, H. Peter Anvin wrote:
> CONFIG_X86_CPU_DEBUG really seems to be causing more problems than it
> ever solved.  This is an RFC for immediately deprecating it, and
> schedule it for removal in the 2.6.34 cycle.
> 
> If this was a high value feature, it would be different -- but it's not
> even close.

ACK

^ permalink raw reply	[flat|nested] 7+ messages in thread

* RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal
  2010-01-17 13:44     ` Rafael J. Wysocki
@ 2010-01-18  1:26       ` H. Peter Anvin
  2010-01-18 21:28         ` Rafael J. Wysocki
  2010-01-23  0:53         ` Andrew Morton
  0 siblings, 2 replies; 7+ messages in thread
From: H. Peter Anvin @ 2010-01-18  1:26 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Ozan Çağlayan, Yinghai Lu, linux-kernel, mingo,
	a.p.zijlstra, stable, Linus Torvalds, Andrew Morton,
	Jaswinder Singh Rajput, Ingo Molnar, Thomas Gleixner

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

CONFIG_X86_CPU_DEBUG really seems to be causing more problems than it
ever solved.  This is an RFC for immediately deprecating it, and
schedule it for removal in the 2.6.34 cycle.

If this was a high value feature, it would be different -- but it's not
even close.

Posting this as an RFC just on the offchance someone actually depends on
this.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-x86-Mark-CONFIG_X86_CPU_DEBUG-for-rapid-deprecation.patch --]
[-- Type: text/x-patch; name="0001-x86-Mark-CONFIG_X86_CPU_DEBUG-for-rapid-deprecation.patch", Size: 2926 bytes --]

>From 0a7c8171aa6d0aed1eda3902f675eb9a259d4cde Mon Sep 17 00:00:00 2001
From: H. Peter Anvin <hpa@zytor.com>
Date: Sun, 17 Jan 2010 17:05:59 -0800
Subject: [PATCH] x86: Mark CONFIG_X86_CPU_DEBUG for rapid deprecation
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

The CONFIG_X86_CPU_DEBUG feature provides for a filesystem view of
some x86 CPU state in debugfs.  However, all this information is
already available to userspace via dedicated interfaces, and this
could just as easily be done in pure userspace.

It wouldn't be a problem, per se, except that this code has caused
boot failures in real-world scenarios when people have enabled it, see
for example kernel bugzilla 15075.

This is a good example of why this kind of functionality has no
business being in the kernel in the first place.

Mark this code deprecated and schedule it for rapid removal.

Reported-by: Ozan Çağlayan <ozan@pardus.org.tr>
Signed-Off-By: H. Peter Anvin <hpa@zytor.com>
LKML-Reference: <4B4F1DE7.307@pardus.org.tr>
Cc: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
---
 Documentation/feature-removal-schedule.txt |    9 +++++++++
 arch/x86/Kconfig                           |    9 ++++++++-
 2 files changed, 17 insertions(+), 1 deletions(-)

diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal-schedule.txt
index 870d190..49aabf1 100644
--- a/Documentation/feature-removal-schedule.txt
+++ b/Documentation/feature-removal-schedule.txt
@@ -493,3 +493,12 @@ Why:	These two features use non-standard interfaces. There are the
 Who:	Corentin Chary <corentin.chary@gmail.com>
 
 ----------------------------
+
+What:	Support for x86 debug information via debugfs (CONFIG_X86_CPU_DEBUG)
+When:	2.6.34
+Why:	This feature does not introduce any functionality that is not
+	available through pure userspace.  However, it has been known
+	to causeboot failures in some hardware configurations.
+
+Who:	H. Peter Anvin <hpa@zytor.com>
+
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 3b2a5ac..eb1751d 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -987,11 +987,18 @@ config X86_CPUID
 	  /dev/cpu/31/cpuid.
 
 config X86_CPU_DEBUG
-	tristate "/sys/kernel/debug/x86/cpu/* - CPU Debug support"
+	tristate "/sys/kernel/debug/x86/cpu/* - CPU Debug support (DEPRECATED)"
 	---help---
 	  If you select this option, this will provide various x86 CPUs
 	  information through debugfs.
 
+	  This feature is strongly deprecated.  It has been known to cause
+	  problems with some hardware configurations and does not
+	  provide any functionality that is not available through pure
+	  userspace means.  It will be removed in the near future.
+
+	  It is strongly recommended that you select N here.
+
 choice
 	prompt "High Memory Support"
 	default HIGHMEM4G if !X86_NUMAQ
-- 
1.6.2.5


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2010-01-23  5:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-01-23  2:34 RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal H. Peter Anvin
  -- strict thread matches above, loose matches on Subject: below --
2010-01-13 18:51 Boot hangs after "Freeing initrd memory" with 2.6.31.11 Ozan Çağlayan
2010-01-16 22:12 ` Rafael J. Wysocki
2010-01-17  9:22   ` Ozan Çağlayan
2010-01-17 13:44     ` Rafael J. Wysocki
2010-01-18  1:26       ` RFC: deprecate CONFIG_X86_CPU_DEBUG and schedule it for rapid removal H. Peter Anvin
2010-01-18 21:28         ` Rafael J. Wysocki
2010-01-23  0:53         ` Andrew Morton
2010-01-23  1:05           ` H. Peter Anvin
2010-01-23  1:59           ` Linus Torvalds
2010-01-23  5:22             ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®