* [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3
@ 2024-11-13 11:26 AngeloGioacchino Del Regno
2024-11-13 13:52 ` Steven Price
2024-11-28 11:38 ` Steven Price
0 siblings, 2 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-11-13 11:26 UTC (permalink / raw)
To: boris.brezillon
Cc: robh, steven.price, maarten.lankhorst, mripard, tzimmermann,
airlied, simona, dri-devel, linux-kernel, kernel,
AngeloGioacchino Del Regno
The MediaTek MT8188 SoC has a Mali-G57 MC3 GPU and, similarly to
MT8192, it has yet another special GPU ID.
Add the GPU ID to the list and treat it as a standard Mali-G57.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
index f5abde3866fb..174e190ba40f 100644
--- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
+++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
@@ -236,6 +236,10 @@ static const struct panfrost_model gpu_models[] = {
*/
GPU_MODEL(g57, 0x9003,
GPU_REV(g57, 0, 0)),
+
+ /* MediaTek MT8188 Mali-G57 MC3 */
+ GPU_MODEL(g57, 0x9093,
+ GPU_REV(g57, 0, 0)),
};
static void panfrost_gpu_init_features(struct panfrost_device *pfdev)
--
2.47.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3
2024-11-13 11:26 [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3 AngeloGioacchino Del Regno
@ 2024-11-13 13:52 ` Steven Price
2024-11-28 11:38 ` Steven Price
1 sibling, 0 replies; 3+ messages in thread
From: Steven Price @ 2024-11-13 13:52 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, boris.brezillon
Cc: robh, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, linux-kernel, kernel
On 13/11/2024 11:26, AngeloGioacchino Del Regno wrote:
> The MediaTek MT8188 SoC has a Mali-G57 MC3 GPU and, similarly to
> MT8192, it has yet another special GPU ID.
>
> Add the GPU ID to the list and treat it as a standard Mali-G57.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Looks reasonable to me - I wonder how many different MediaTek specials
there are out there ;)
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index f5abde3866fb..174e190ba40f 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -236,6 +236,10 @@ static const struct panfrost_model gpu_models[] = {
> */
> GPU_MODEL(g57, 0x9003,
> GPU_REV(g57, 0, 0)),
> +
> + /* MediaTek MT8188 Mali-G57 MC3 */
> + GPU_MODEL(g57, 0x9093,
> + GPU_REV(g57, 0, 0)),
> };
>
> static void panfrost_gpu_init_features(struct panfrost_device *pfdev)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3
2024-11-13 11:26 [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3 AngeloGioacchino Del Regno
2024-11-13 13:52 ` Steven Price
@ 2024-11-28 11:38 ` Steven Price
1 sibling, 0 replies; 3+ messages in thread
From: Steven Price @ 2024-11-28 11:38 UTC (permalink / raw)
To: AngeloGioacchino Del Regno, boris.brezillon
Cc: robh, maarten.lankhorst, mripard, tzimmermann, airlied, simona,
dri-devel, linux-kernel, kernel
On 13/11/2024 11:26, AngeloGioacchino Del Regno wrote:
> The MediaTek MT8188 SoC has a Mali-G57 MC3 GPU and, similarly to
> MT8192, it has yet another special GPU ID.
>
> Add the GPU ID to the list and treat it as a standard Mali-G57.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Pushed to drm-misc-next
Thanks,
Steve
> ---
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> index f5abde3866fb..174e190ba40f 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c
> @@ -236,6 +236,10 @@ static const struct panfrost_model gpu_models[] = {
> */
> GPU_MODEL(g57, 0x9003,
> GPU_REV(g57, 0, 0)),
> +
> + /* MediaTek MT8188 Mali-G57 MC3 */
> + GPU_MODEL(g57, 0x9093,
> + GPU_REV(g57, 0, 0)),
> };
>
> static void panfrost_gpu_init_features(struct panfrost_device *pfdev)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-28 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-13 11:26 [PATCH] drm/panfrost: Add GPU ID for MT8188 Mali-G57 MC3 AngeloGioacchino Del Regno
2024-11-13 13:52 ` Steven Price
2024-11-28 11:38 ` Steven Price
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®