* [PATCH] block: delete redundant function declarations
[not found] <CGME20240527022944epcas5p16011e653d1f770cd11bc760f39c17ad2@epcas5p1.samsung.com>
@ 2024-05-27 2:29 ` hexue
2024-05-27 5:39 ` Kanchan Joshi
0 siblings, 1 reply; 3+ messages in thread
From: hexue @ 2024-05-27 2:29 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, peiwei.li, ruyi.zhang, Xue He
From: Xue He <xue01.he@samsung.com>
It is used in block hybrid poll, the related function
definitions have been removed, but the function
declaration has not been delelted.
Signed-off-by: Xue He <xue01.he@samsung.com>
---
block/blk-stat.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-stat.h b/block/blk-stat.h
index 17e1eb4ec7e2..5d7f18ba436d 100644
--- a/block/blk-stat.h
+++ b/block/blk-stat.h
@@ -64,7 +64,6 @@ struct blk_stat_callback {
struct blk_queue_stats *blk_alloc_queue_stats(void);
void blk_free_queue_stats(struct blk_queue_stats *);
-bool blk_stats_alloc_enable(struct request_queue *q);
void blk_stat_add(struct request *rq, u64 now);
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: delete redundant function declarations
2024-05-27 2:29 ` [PATCH] block: delete redundant function declarations hexue
@ 2024-05-27 5:39 ` Kanchan Joshi
[not found] ` <CGME20240527082328epcas5p205a74058d8163a1c724ad800ba18e056@epcas5p2.samsung.com>
0 siblings, 1 reply; 3+ messages in thread
From: Kanchan Joshi @ 2024-05-27 5:39 UTC (permalink / raw)
To: hexue, axboe; +Cc: linux-block, linux-kernel, peiwei.li, ruyi.zhang
On 5/27/2024 7:59 AM, hexue wrote:
> From: Xue He <xue01.he@samsung.com>
>
> It is used in block hybrid poll, the related function
It -> blk_stats_alloc_enable
Also, you might want to mention the patch that removed it.
54bdd67d0f88 blk-mq: remove hybrid polling
> definitions have been removed, but the function
> declaration has not been delelted.
delelted -> deleted.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Re: [PATCH] block: delete redundant function declarations
[not found] ` <CGME20240527082328epcas5p205a74058d8163a1c724ad800ba18e056@epcas5p2.samsung.com>
@ 2024-05-27 8:23 ` hexue
0 siblings, 0 replies; 3+ messages in thread
From: hexue @ 2024-05-27 8:23 UTC (permalink / raw)
To: joshi.k, axboe; +Cc: linux-block, linux-kernel, peiwei.li, ruyi.zhang, xue01.he
On 5/27/2024 11:09 AM, Kanchan Joshi wrote:
>On 5/27/2024 7:59 AM, hexue wrote:
>> From: Xue He <xue01.he@samsung.com>
>>
>> It is used in block hybrid poll, the related function
>
>It -> blk_stats_alloc_enable
>
>Also, you might want to mention the patch that removed it.
>54bdd67d0f88 blk-mq: remove hybrid polling
>
>
>> definitions have been removed, but the function
>> declaration has not been delelted.
>delelted -> deleted.
Thanks, will modify these and submit v2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-27 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20240527022944epcas5p16011e653d1f770cd11bc760f39c17ad2@epcas5p1.samsung.com>
2024-05-27 2:29 ` [PATCH] block: delete redundant function declarations hexue
2024-05-27 5:39 ` Kanchan Joshi
[not found] ` <CGME20240527082328epcas5p205a74058d8163a1c724ad800ba18e056@epcas5p2.samsung.com>
2024-05-27 8:23 ` hexue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®