From: Logan Gunthorpe <logang@deltatee.com>
To: Jon Mason <jdmason@kudzu.us>
Cc: wesley.sheng@microchip.com,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
linux-pci@vger.kernel.org, linux-ntb@googlegroups.com,
linux-kernel <linux-kernel@vger.kernel.org>,
wesleyshenggit@sina.com
Subject: Re: [PATCH v2 0/3] ntb_hw_switchtec: Added support of >=4G memory windows
Date: Wed, 12 Dec 2018 17:01:33 -0700 [thread overview]
Message-ID: <ff7019a0-bac2-2de2-d06c-d54a82286b90@deltatee.com> (raw)
In-Reply-To: <CAPoiz9xesBdtgVg1UGF8LuD28tjMp6VpVuHVjdwcWJq93Phi3w@mail.gmail.com>
On 2018-12-12 4:57 p.m., Jon Mason wrote:
> On Wed, Dec 12, 2018 at 6:42 PM Logan Gunthorpe <logang@deltatee.com> wrote:
>>
>>
>>
>> On 2018-12-12 4:00 p.m., Jon Mason wrote:
>>> So, you based your patches on a series of patches not in the
>>> ntb/ntb-next branch? Please don't do this. I see nothing in these
>>> patches which requires that series, which makes this even more
>>> unnecessary. Since these are fairly trivial, I'm taking them and
>>> pushing to the ntb-next branch to give these more time to be tested
>>> (due to not being tested on the proper branch). I would really
>>> appreciate you testing the ntb-next branch as a sanity check.
>>
>> The NTB test tools don't work with switchtec hardware without that patch
>> set, so there's no way to test the changes without that branch.
>
> Then let's get those patches in. IIRC, I asked you to split up the
> patch series to be bugfixes and features (or at least reorder the
> series so I can split it up that way in my branches). Also, I think
> Serge had some comments that may/may not need to be addressed. Could
> you please reorder and resend (and Serge can comment as needed on the
> resend)?
I resent a while back and responded to all the feedback. Every patch in
that series fixes a bug. None of them add features.
Logan
next prev parent reply other threads:[~2018-12-13 0:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:30 Wesley Sheng
2018-12-06 13:30 ` [PATCH v2 1/3] ntb_hw_switchtec: debug print 64bit aligned crosslink BAR Numbers Wesley Sheng
2018-12-06 13:30 ` [PATCH v2 2/3] ntb_hw_switchtec: NT req id mapping table register entry number should be 512 Wesley Sheng
2018-12-06 13:30 ` [PATCH v2 3/3] ntb_hw_switchtec: Added support of >=4G memory windows Wesley Sheng
2018-12-12 23:00 ` [PATCH v2 0/3] " Jon Mason
2018-12-12 23:42 ` Logan Gunthorpe
2018-12-12 23:57 ` Jon Mason
2018-12-13 0:01 ` Logan Gunthorpe [this message]
2018-12-13 0:25 ` Jon Mason
2018-12-13 0:32 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff7019a0-bac2-2de2-d06c-d54a82286b90@deltatee.com \
--to=logang@deltatee.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=wesley.sheng@microchip.com \
--cc=wesleyshenggit@sina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®