mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2 0/7] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45
@ 2024-08-18 21:50 Jan Petrous (OSS)
  2024-08-19  6:03 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Petrous (OSS) @ 2024-08-18 21:50 UTC (permalink / raw)
  To: Jan Petrous (OSS),
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
	Jose Abreu, Maxime Coquelin, Vinod Koul, Andrew Lunn,
	Heiner Kallweit, Russell King, Richard Cochran,
	Giuseppe Cavallaro
  Cc: netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel,
	linux-arm-msm, dl-S32

The SoC series S32G2xx and S32G3xx feature one DWMAC instance,
the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII
interface over Pinctrl device or the output can be routed
to the embedded SerDes for SGMII connectivity.

The provided stmmac glue code implements only basic functionality,
interface support is restricted to RGMII only.

This patchset adds stmmac glue driver based on downstream NXP git [0].

[0] https://github.com/nxp-auto-linux/linux

v2:
- send to wider audience as first version missed many maintainers
- created rgmi_clk() helper as Russell suggested (see patch#4)
- address Andrew's, Russell's, Serge's and Simon's comments

Jan Petrous (OSS) (7):
  net: driver: stmmac: extend CSR calc support
  net: stmmac: Expand clock rate variables
  dt-bindings: net: Add DT bindings for DWMAC on NXP S32G/R SoCs
  net: phy: add helper for mapping RGMII link speed to clock rate
  net: stmmac: dwmac-s32cc: add basic NXP S32G/S32R glue driver
  MAINTAINERS: Add Jan Petrous as the NXP S32G/R DWMAC driver maintainer
  net: stmmac: dwmac-s32cc: Read PTP clock rate when ready

 .../bindings/net/nxp,s32cc-dwmac.yaml         | 127 +++++++++
 .../devicetree/bindings/net/snps,dwmac.yaml   |   1 +
 MAINTAINERS                                   |   7 +
 drivers/net/ethernet/stmicro/stmmac/Kconfig   |  12 +
 drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
 drivers/net/ethernet/stmicro/stmmac/common.h  |   2 +
 .../stmicro/stmmac/dwmac-qcom-ethqos.c        |   2 +-
 .../net/ethernet/stmicro/stmmac/dwmac-s32cc.c | 248 ++++++++++++++++++
 .../net/ethernet/stmicro/stmmac/dwmac4_core.c |   2 +-
 .../net/ethernet/stmicro/stmmac/stmmac_main.c |   6 +-
 .../ethernet/stmicro/stmmac/stmmac_platform.c |   2 +-
 include/linux/phy.h                           |  21 ++
 include/linux/stmmac.h                        |  10 +-
 13 files changed, 433 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml
 create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-s32cc.c

-- 
2.46.0






^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 0/7] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45
  2024-08-18 21:50 [PATCH v2 0/7] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45 Jan Petrous (OSS)
@ 2024-08-19  6:03 ` Krzysztof Kozlowski
  2024-10-06 18:24   ` Jan Petrous
  0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-19  6:03 UTC (permalink / raw)
  To: Jan Petrous (OSS),
	David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
	Jose Abreu, Maxime Coquelin, Vinod Koul, Andrew Lunn,
	Heiner Kallweit, Russell King, Richard Cochran,
	Giuseppe Cavallaro
  Cc: netdev, devicetree, linux-kernel, linux-stm32, linux-arm-kernel,
	linux-arm-msm, dl-S32

On 18/08/2024 23:50, Jan Petrous (OSS) wrote:
> The SoC series S32G2xx and S32G3xx feature one DWMAC instance,
> the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII
> interface over Pinctrl device or the output can be routed
> to the embedded SerDes for SGMII connectivity.
> 
> The provided stmmac glue code implements only basic functionality,
> interface support is restricted to RGMII only.
> 
> This patchset adds stmmac glue driver based on downstream NXP git [0].
> 
> [0] https://github.com/nxp-auto-linux/linux

All your threading is completely broken which makes it difficult to
apply and compare patchsets. Just try - use b4 diff on this...

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 0/7] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45
  2024-08-19  6:03 ` Krzysztof Kozlowski
@ 2024-10-06 18:24   ` Jan Petrous
  0 siblings, 0 replies; 3+ messages in thread
From: Jan Petrous @ 2024-10-06 18:24 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Alexandre Torgue,
	Jose Abreu, Maxime Coquelin, Vinod Koul, Andrew Lunn,
	Heiner Kallweit, Russell King, Richard Cochran,
	Giuseppe Cavallaro, netdev, devicetree, linux-kernel,
	linux-stm32, linux-arm-kernel, linux-arm-msm, dl-S32

On Mon, Aug 19, 2024 at 08:03:30AM +0200, Krzysztof Kozlowski wrote:
> On 18/08/2024 23:50, Jan Petrous (OSS) wrote:
> > The SoC series S32G2xx and S32G3xx feature one DWMAC instance,
> > the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII
> > interface over Pinctrl device or the output can be routed
> > to the embedded SerDes for SGMII connectivity.
> > 
> > The provided stmmac glue code implements only basic functionality,
> > interface support is restricted to RGMII only.
> > 
> > This patchset adds stmmac glue driver based on downstream NXP git [0].
> > 
> > [0] https://github.com/nxp-auto-linux/linux
> 
> All your threading is completely broken which makes it difficult to
> apply and compare patchsets. Just try - use b4 diff on this...
> 

Sorry for that. I had some difficulties with enabling SMTP traffic,
so I used Outlook what I see is totally unusable solution.

Now I have all b4/lei/msmtp/mutt tools installed and will use
it for v3.

BR.
/Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-10-06 18:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-18 21:50 [PATCH v2 0/7] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45 Jan Petrous (OSS)
2024-08-19  6:03 ` Krzysztof Kozlowski
2024-10-06 18:24   ` Jan Petrous

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®