mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@suse.de>,
	Mike Latimer <mlatimer@suse.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/pti: don't report XenPV as vulnerable
Date: Fri, 15 Jun 2018 08:10:42 +0200	[thread overview]
Message-ID: <ff9f4a24-6e69-cc7b-ba75-e82c9182a805@suse.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1806150801530.6203@cbobk.fhfr.pm>

On 15/06/18 08:04, Jiri Kosina wrote:
> On Fri, 15 Jun 2018, Juergen Gross wrote:
> 
>> wrong for 64-bit, too, in case the mitigation is disabled at hypervisor 
>> level.
> 
> If that is indeed possible (is it?), then the check we have in 
> pti_check_boottime_disable() is wrong as well.

No, it isn't. PTI for 32-bit kernels isn't paravirtualized, so it has to
be disabled.

> 
>> So the test should be done only for CONFIG_X86_64 
> 
> Fair enough.
> 
>> and the returned string should be e.g. "Mitigation: XEN".
> 
> Well, perhaps; it'd confuse all the scripts that are checking whether 
> system is fully secured or not by parsing sysfs files ... but that's 
> mostly their problem.

Right. And I suppose those scripts are fairly new. :-)


Juergen

  reply	other threads:[~2018-06-15  6:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 22:32 Jiri Kosina
2018-06-15  5:46 ` Juergen Gross
2018-06-15  6:04   ` Jiri Kosina
2018-06-15  6:10     ` Juergen Gross [this message]
2018-06-15  6:16       ` Jiri Kosina
2018-06-15  6:30         ` Juergen Gross
2018-06-15  6:39           ` Jiri Kosina
2018-06-15  7:00             ` Juergen Gross
2018-06-15 21:10               ` Jiri Kosina
2018-06-16  6:36                 ` Juergen Gross
2018-06-18  7:59                   ` [PATCH v2] " Jiri Kosina
2018-06-18  8:07                     ` Juergen Gross
2018-06-19  8:02                     ` [tip:x86/pti] x86/pti: Don't " tip-bot for Jiri Kosina
2018-06-21 12:24                     ` tip-bot for Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff9f4a24-6e69-cc7b-ba75-e82c9182a805@suse.com \
    --to=jgross@suse.com \
    --cc=bp@suse.de \
    --cc=jikos@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=mlatimer@suse.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome