mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Jiri Kosina <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: mlatimer@suse.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
	mingo@kernel.org, jgross@suse.com, tglx@linutronix.de,
	jkosina@suse.cz, bp@suse.de
Subject: [tip:x86/pti] x86/pti: Don't report XenPV as vulnerable
Date: Thu, 21 Jun 2018 05:24:47 -0700	[thread overview]
Message-ID: <tip-6cb2b08ff92460290979de4be91363e5d1b6cec1@git.kernel.org> (raw)
In-Reply-To: <nycvar.YFH.7.76.1806180959080.6203@cbobk.fhfr.pm>

Commit-ID:  6cb2b08ff92460290979de4be91363e5d1b6cec1
Gitweb:     https://git.kernel.org/tip/6cb2b08ff92460290979de4be91363e5d1b6cec1
Author:     Jiri Kosina <jkosina@suse.cz>
AuthorDate: Mon, 18 Jun 2018 09:59:54 +0200
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Thu, 21 Jun 2018 14:14:52 +0200

x86/pti: Don't report XenPV as vulnerable

Xen PV domain kernel is not by design affected by meltdown as it's
enforcing split CR3 itself. Let's not report such systems as "Vulnerable"
in sysfs (we're also already forcing PTI to off in X86_HYPER_XEN_PV cases);
the security of the system ultimately depends on presence of mitigation in
the Hypervisor, which can't be easily detected from DomU; let's report
that.

Reported-and-tested-by: Mike Latimer <mlatimer@suse.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Juergen Gross <jgross@suse.com>
Cc: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/nycvar.YFH.7.76.1806180959080.6203@cbobk.fhfr.pm
[ Merge the user-visible string into a single line. ]
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 arch/x86/kernel/cpu/bugs.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
index cd0fda1fff6d..404df26b7de8 100644
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -27,6 +27,7 @@
 #include <asm/pgtable.h>
 #include <asm/set_memory.h>
 #include <asm/intel-family.h>
+#include <asm/hypervisor.h>
 
 static void __init spectre_v2_select_mitigation(void);
 static void __init ssb_select_mitigation(void);
@@ -664,6 +665,9 @@ static ssize_t cpu_show_common(struct device *dev, struct device_attribute *attr
 		if (boot_cpu_has(X86_FEATURE_PTI))
 			return sprintf(buf, "Mitigation: PTI\n");
 
+		if (hypervisor_is_type(X86_HYPER_XEN_PV))
+			return sprintf(buf, "Unknown (XEN PV detected, hypervisor mitigation required)\n");
+
 		break;
 
 	case X86_BUG_SPECTRE_V1:

      parent reply	other threads:[~2018-06-21 12:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-14 22:32 [PATCH] x86/pti: don't " Jiri Kosina
2018-06-15  5:46 ` Juergen Gross
2018-06-15  6:04   ` Jiri Kosina
2018-06-15  6:10     ` Juergen Gross
2018-06-15  6:16       ` Jiri Kosina
2018-06-15  6:30         ` Juergen Gross
2018-06-15  6:39           ` Jiri Kosina
2018-06-15  7:00             ` Juergen Gross
2018-06-15 21:10               ` Jiri Kosina
2018-06-16  6:36                 ` Juergen Gross
2018-06-18  7:59                   ` [PATCH v2] " Jiri Kosina
2018-06-18  8:07                     ` Juergen Gross
2018-06-19  8:02                     ` [tip:x86/pti] x86/pti: Don't " tip-bot for Jiri Kosina
2018-06-21 12:24                     ` tip-bot for Jiri Kosina [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-6cb2b08ff92460290979de4be91363e5d1b6cec1@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mlatimer@suse.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome