mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hanjun Guo <guohanjun@huawei.com>
To: Breno Leitao <leitao@debian.org>, Rui Qi <qirui.001@bytedance.com>
Cc: <rafael@kernel.org>, <tony.luck@intel.com>, <bp@alien8.de>,
	<mchehab@kernel.org>, <xueshuai@linux.alibaba.com>,
	<lenb@kernel.org>, <pjw@kernel.org>, <palmer@dabbelt.com>,
	<aou@eecs.berkeley.edu>, <alex@ghiti.fr>,
	<jonathan.cameron@huawei.com>,
	<fabio.m.de.francesco@linux.intel.com>,
	<jason@os.amperecomputing.com>, <inux-acpi@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <inux-riscv@lists.infradead.org>
Subject: Re: [PATCH] ACPI: APEI: ghes: mark ghes_in_nmi_spool_from_list maybe unused
Date: Mon, 23 Mar 2026 16:14:39 +0800	[thread overview]
Message-ID: <ffdca519-cd0e-1389-a653-c493fbf424e0@huawei.com> (raw)
In-Reply-To: <abkhBlcKolrjfvV9@gmail.com>

On 2026/3/17 17:39, Breno Leitao wrote:
> On Tue, Mar 17, 2026 at 11:55:52AM +0800, Rui Qi wrote:
>> On 3/16/26 5:03 PM, Breno Leitao wrote:
>>
>>    If there is consensus that we should address this via conditional
>> compilation instead, I can follow up
>>    with another patch that wraps these helpers in something like #if
>> IS_ENABLED(CONFIG_ACPI_APEI_SEA) ||
>>    IS_ENABLED(CONFIG_HAVE_ACPI_APEI_NMI).
> 
> This approach would be worse, I would say. Your current approach seems
> cleaner, IMO.

Looks reasonable to me as well.

Thanks
Hanjun

  reply	other threads:[~2026-03-23  8:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  8:28 Rui Qi
2026-03-16  9:03 ` Breno Leitao
2026-03-17  3:55   ` Rui Qi
2026-03-17  9:39     ` Breno Leitao
2026-03-23  8:14       ` Hanjun Guo [this message]
2026-03-17  9:39 ` Breno Leitao
2026-03-23  8:15 ` Hanjun Guo
2026-04-07  1:31 ` Shuai Xue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffdca519-cd0e-1389-a653-c493fbf424e0@huawei.com \
    --to=guohanjun@huawei.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bp@alien8.de \
    --cc=fabio.m.de.francesco@linux.intel.com \
    --cc=inux-acpi@vger.kernel.org \
    --cc=inux-riscv@lists.infradead.org \
    --cc=jason@os.amperecomputing.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=leitao@debian.org \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=qirui.001@bytedance.com \
    --cc=rafael@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=xueshuai@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®