From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
linuxppc-dev@lists.ozlabs.org,
Michael Ellerman <mpe@ellerman.id.au>,
Christophe Leroy <chleroy@kernel.org>,
Anushree Mathur <anushree.mathur@linux.ibm.com>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 6/9] KVM: selftests: Limit the number of VM creates in hardware_disable_test
Date: Sat, 03 Oct 2026 11:31:23 +0530 [thread overview]
Message-ID: <ik3jjpak.ritesh.list@gmail.com> (raw)
In-Reply-To: <asAt1NhGFs5HNbvl@google.com>
Sean Christopherson <seanjc@google.com> writes:
> On Tue, Sep 22, 2026, Ritesh Harjani (IBM) wrote:
>> hardware_disable_test forks several VMs (NR_IERATIONS=512). This patch
>> limits that number to 4 when we know that we are running in constraint
>> host environment. The number 4 is just a safe minimum when
>> kvm_arch_vm_create_may_enomem() can be true.
>
> Please actually explain *why* this is necessary, and where the magic '4' comes.
> I assume there's some system-wide resource at play?
Yes, this is the similar issue of limited resources at L0 for nested-v2
case. This test actually forks and each child creates a VM. Here, the
parent queues the SIGKILL for the child, however it does not waitpid
before the next fork. That means the VM can still be eating the guest
management space at L0 for the nested-v2 guests (until the VM is
completely destroyed).
I agree the number 4 is a bit ugly here. It was just a safe limit. I was
able to spawn multiple VMs ofcourse - but for the sake of enabling this
test I went with some safe minimum.
BTW, since you suggested that in the initial enablement of the kvm PPC
selftests, we need not land this hardware_disable_test, so I will skip
this for now.
-ritesh
next prev parent reply other threads:[~2026-10-03 6:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 18:28 [PATCH v5 0/9] KVM: selftests: add powerpc support Ritesh Harjani (IBM)
2026-09-22 18:28 ` [PATCH v5 1/9] KVM: PPC: selftests: add support for powerpc Ritesh Harjani (IBM)
2026-10-02 22:12 ` Sean Christopherson
2026-09-22 18:28 ` [PATCH v5 2/9] KVM: selftests: Enable kvm_create_max_vcpus test " Ritesh Harjani (IBM)
2026-09-22 18:28 ` [PATCH v5 3/9] KVM: selftests: Don't limit LE dirty-bitmap bitops to s390x Ritesh Harjani (IBM)
2026-09-22 18:28 ` [PATCH v5 4/9] KVM: selftests: Split out a KVM_CREATE_VCPU helper that can fail Ritesh Harjani (IBM)
2026-09-22 18:28 ` [PATCH v5 5/9] KVM: selftests: Make kvm_create_max_vcpus tolerate ENOMEM Ritesh Harjani (IBM)
2026-10-02 22:16 ` Sean Christopherson
2026-10-03 5:45 ` Ritesh Harjani
2026-09-22 18:28 ` [PATCH v5 6/9] KVM: selftests: Limit the number of VM creates in hardware_disable_test Ritesh Harjani (IBM)
2026-10-02 22:19 ` Sean Christopherson
2026-10-03 6:01 ` Ritesh Harjani [this message]
2026-09-22 18:28 ` [PATCH v5 7/9] KVM: PPC: selftests: Make nested case on pseries LPARs as resource constrained Ritesh Harjani (IBM)
2026-09-22 18:28 ` [PATCH v5 8/9] KVM: PPC: selftests: Skip idle-page check when running nested on pseries LPAR Ritesh Harjani (IBM)
2026-09-22 18:28 ` [PATCH v5 9/9] KVM: selftests: Move memslot_perf_test off the 256M ELF load address Ritesh Harjani (IBM)
2026-10-02 22:28 ` Sean Christopherson
2026-09-29 1:35 ` [PATCH v5 0/9] KVM: selftests: add powerpc support Ritesh Harjani
2026-10-02 22:38 ` Sean Christopherson
2026-10-03 6:46 ` Ritesh Harjani
2026-10-05 2:39 ` Sean Christopherson
2026-09-29 5:49 ` Anushree Mathur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ik3jjpak.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=anushree.mathur@linux.ibm.com \
--cc=chleroy@kernel.org \
--cc=harshpb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sshegde@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®