From: Andreas Schwab <schwab@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
Chris Wright <chrisw@sous-sol.org>,
Jody McIntyre <scjody@modernduck.com>,
Ben Collins <bcollins@ubuntu.com>,
linux-kernel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net
Subject: Re: [stable] [PATCH] sbp2: fix check of return value of hpsb_allocate_and_register_addrspace
Date: Sat, 03 Jun 2006 11:31:27 +0200 [thread overview]
Message-ID: <jemzcu7fgw.fsf@sykes.suse.de> (raw)
In-Reply-To: <44815283.7080306@tls.msk.ru> (Michael Tokarev's message of "Sat, 03 Jun 2006 13:12:35 +0400")
Michael Tokarev <mjt@tls.msk.ru> writes:
> Stefan Richter wrote:
>> Chris Wright wrote:
>>> * Stefan Richter (stefanr@s5r6.in-berlin.de) wrote:
>> ....
>>>> +++ linux-2.6.17-rc5/drivers/ieee1394/sbp2.c 2006-06-03
>>>> 01:54:23.000000000 +0200
>>>> @@ -845,7 +845,7 @@ static struct scsi_id_instance_data *sbp
>>>> &sbp2_highlevel, ud->ne->host, &sbp2_ops,
>>>> sizeof(struct sbp2_status_block), sizeof(quadlet_t),
>>>> 0x010000000000ULL, CSR1212_ALL_SPACE_END);
>>>> - if (!scsi_id->status_fifo_addr) {
>>>> + if (scsi_id->status_fifo_addr == ~0ULL) {
>
> Umm. Can this ~0ULL constant be #define'd to something?
> It's way too simple to mis-read it as NULL (or ~NULL whatever).
How about writing it as -1?
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-06-03 9:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-03 0:00 Stefan Richter
2006-06-03 1:35 ` [stable] " Chris Wright
2006-06-03 8:37 ` Stefan Richter
2006-06-03 9:12 ` Michael Tokarev
2006-06-03 9:31 ` Andreas Schwab [this message]
2006-06-03 9:43 ` Andrew Morton
2006-06-03 10:42 ` Stefan Richter
2006-06-03 11:05 ` [PATCH 1/2] sbp2: fix deregistration of status fifo address space Stefan Richter
2006-06-03 11:08 ` [PATCH 2/2] ieee1394: add preprocessor constant for invalid csr address Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jemzcu7fgw.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=bcollins@ubuntu.com \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=mjt@tls.msk.ru \
--cc=scjody@modernduck.com \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®