From: Andreas Schwab <schwab@suse.de>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Nathan Scott <nathans@sgi.com>,
linux-xfs@oss.sgi.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Parenthesize macros in xfs
Date: Sun, 26 Mar 2006 16:23:12 +0200 [thread overview]
Message-ID: <jewtehl1yn.fsf@sykes.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0603261124320.22145@yvahk01.tjqt.qr> (Jan Engelhardt's message of "Sun, 26 Mar 2006 11:26:41 +0200 (MEST)")
Jan Engelhardt <jengelh@linux01.gwdg.de> writes:
>>>>> + swapfunc(a, b, es, swaptype) \
>>>>> +} while(0)
>>>> ^^
>>>>Missing semicolon.
>>>
>>> It was missing before too. ;)
>>
>>No, previously it was provided at the call site.
>
> Bad habit IMO. It does not hurt to provide it in both the macro and
> the call site, GCC can handle empty instructions.
There is no way to provide the missing semicolon at the call site.
swapfunc can't provide it either, since it's not a macro.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2006-03-26 14:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 21:09 Jan Engelhardt
2006-03-20 21:23 ` Nathan Scott
2006-03-20 21:39 ` Jan Engelhardt
2006-03-20 21:46 ` Nathan Scott
2006-03-25 21:35 ` Jan Engelhardt
2006-03-25 22:38 ` Andreas Schwab
2006-03-25 23:23 ` Jan Engelhardt
2006-03-25 23:45 ` Andreas Schwab
2006-03-26 9:26 ` Jan Engelhardt
2006-03-26 12:19 ` Måns Rullgård
2006-03-26 12:30 ` Kyle Moffett
2006-03-26 14:23 ` Andreas Schwab [this message]
2006-03-25 23:26 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jewtehl1yn.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@oss.sgi.com \
--cc=nathans@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®