From: "Måns Rullgård" <mru@inprovide.com>
To: linux-kernel@vger.kernel.org
Subject: Re: Parenthesize macros in xfs
Date: Sun, 26 Mar 2006 13:19:14 +0100 [thread overview]
Message-ID: <yw1x3bh5xut9.fsf@agrajag.inprovide.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0603261124320.22145@yvahk01.tjqt.qr>
Jan Engelhardt <jengelh@linux01.gwdg.de> writes:
>>>>> + swapfunc(a, b, es, swaptype) \
>>>>> +} while(0)
>>>> ^^
>>>>Missing semicolon.
>>>
>>> It was missing before too. ;)
>>
>>No, previously it was provided at the call site.
>
> Bad habit IMO. It does not hurt to provide it in both the macro and
> the call site, GCC can handle empty instructions.
A double semicolon can cause all sorts of hard to debug problems.
Consider this:
#define foo() bar();
/* ... */
if(x)
foo();
else
baz();
This will expand to syntactically invalid code because of the extra
semicolon.
--
Måns Rullgård
mru@inprovide.com
next prev parent reply other threads:[~2006-03-26 12:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 21:09 Jan Engelhardt
2006-03-20 21:23 ` Nathan Scott
2006-03-20 21:39 ` Jan Engelhardt
2006-03-20 21:46 ` Nathan Scott
2006-03-25 21:35 ` Jan Engelhardt
2006-03-25 22:38 ` Andreas Schwab
2006-03-25 23:23 ` Jan Engelhardt
2006-03-25 23:45 ` Andreas Schwab
2006-03-26 9:26 ` Jan Engelhardt
2006-03-26 12:19 ` Måns Rullgård [this message]
2006-03-26 12:30 ` Kyle Moffett
2006-03-26 14:23 ` Andreas Schwab
2006-03-25 23:26 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1x3bh5xut9.fsf@agrajag.inprovide.com \
--to=mru@inprovide.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®