Can't compile 2.5.2-pre11: error in fbdev

Can't compile 2.5.2-pre11: error in fbdev

[Sebastian Krause]

When I try to compile 2.5.2-pre11, I get the following error:

ld -m elf_i386  -r -o sounddrivers.o soundcore.o sound.o sb.o sb_lib.o uart401.o
make[3]: Leaving directory `/usr/src/v2.5/linux/drivers/sound'
make[2]: Leaving directory `/usr/src/v2.5/linux/drivers/sound'
make -C video
make[2]: Entering directory `/usr/src/v2.5/linux/drivers/video'
make -C riva
make[3]: Entering directory `/usr/src/v2.5/linux/drivers/video/riva'
make all_targets
make[4]: Entering directory `/usr/src/v2.5/linux/drivers/video/riva'
gcc -D__KERNEL__ -I/usr/src/v2.5/linux/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686 -malign-functions=4     -c -o fbdev.o fbdev.c
fbdev.c: In function `riva_set_fbinfo':
fbdev.c:1814: incompatible types in assignment
make[4]: *** [fbdev.o] Error 1
make[4]: Leaving directory `/usr/src/v2.5/linux/drivers/video/riva'
make[3]: *** [first_rule] Error 2
make[3]: Leaving directory `/usr/src/v2.5/linux/drivers/video/riva'
make[2]: *** [_subdir_riva] Error 2
make[2]: Leaving directory `/usr/src/v2.5/linux/drivers/video'
make[1]: *** [_subdir_video] Error 2
make[1]: Leaving directory `/usr/src/v2.5/linux/drivers'
make: *** [_dir_drivers] Error 2

I'm using gcc 2.95.4 under Debian Woody. 2.4.17 works without any
problems. What do I make wrong?

Sebastian

Re: Can't compile 2.5.2-pre11: error in fbdev

[Greg KH]

On Sat, Jan 12, 2002 at 09:17:50PM +0100, Sebastian Krause wrote:
> When I try to compile 2.5.2-pre11, I get the following error:

This patch fixes it for me:


diff -Nru a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c
--- a/drivers/video/riva/fbdev.c	Sat Jan 12 13:06:34 2002
+++ b/drivers/video/riva/fbdev.c	Sat Jan 12 13:06:34 2002
@@ -1811,7 +1811,7 @@
 	info = &rinfo->info;
 
 	strcpy(info->modename, rinfo->drvr_name);
-	info->node = -1;
+	info->node = NODEV;
 	info->flags = FBINFO_FLAG_DEFAULT;
 	info->fbops = &riva_fb_ops;