mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done
@ 2012-11-12  8:01 Tushar Behera
  2013-03-25 10:53 ` Marek Szyprowski
  0 siblings, 1 reply; 2+ messages in thread
From: Tushar Behera @ 2012-11-12  8:01 UTC (permalink / raw)
  To: linux-kernel, linux-media; +Cc: mchehab, patches

In vb2_buffer_done, it would be better the print the value of 'state'
(current state of buffer) than to print 'vb->state' which is always
VB2_BUF_STATE_ACTIVE.

Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
 drivers/media/v4l2-core/videobuf2-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index 432df11..91980d13 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -798,7 +798,7 @@ void vb2_buffer_done(struct vb2_buffer *vb, enum vb2_buffer_state state)
 		return;
 
 	dprintk(4, "Done processing on buffer %d, state: %d\n",
-			vb->v4l2_buf.index, vb->state);
+			vb->v4l2_buf.index, state);
 
 	/* Add the buffer to the done buffers list */
 	spin_lock_irqsave(&q->done_lock, flags);
-- 
1.7.4.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done
  2012-11-12  8:01 [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done Tushar Behera
@ 2013-03-25 10:53 ` Marek Szyprowski
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Szyprowski @ 2013-03-25 10:53 UTC (permalink / raw)
  To: linux-kernel

Hello,

Tushar Behera <tushar.behera <at> linaro.org> writes:

> In vb2_buffer_done, it would be better the print the value of 'state'
> (current state of buffer) than to print 'vb->state' which is always
> VB2_BUF_STATE_ACTIVE.
> 
> Signed-off-by: Tushar Behera <tushar.behera <at> linaro.org>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>  drivers/media/v4l2-core/videobuf2-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-03-25 10:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-12  8:01 [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done Tushar Behera
2013-03-25 10:53 ` Marek Szyprowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®