From: ebiederm@xmission.com (Eric W. Biederman)
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] fix handling of st_nlink on procfs root
Date: Wed, 15 Feb 2006 10:35:08 -0700 [thread overview]
Message-ID: <m11wy4ttir.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20060215103911.GL27946@ftp.linux.org.uk> (Al Viro's message of "Wed, 15 Feb 2006 10:39:11 +0000")
Al Viro <viro@ftp.linux.org.uk> writes:
> On Wed, Feb 15, 2006 at 02:20:17AM -0700, Eric W. Biederman wrote:
>> And it is actually wrong. It fails to take into account the static
>> /proc entries.
>> > + stat->nlink = proc_root.nlink + nr_processes();
>
> The hell it does. See ^^^^^^^^^^^^^^ this.
Right. Sorry. I had a similar issue and when I check your patch for the
same problem somehow I thought proc_root was a struct inode and not a
struct proc_dir_entry.
Eric
prev parent reply other threads:[~2006-02-15 17:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-08 20:31 Al Viro
2006-02-09 1:04 ` Eric W. Biederman
2006-02-09 2:17 ` Al Viro
2006-02-09 3:14 ` Eric W. Biederman
2006-02-15 9:20 ` Eric W. Biederman
2006-02-15 10:39 ` Al Viro
2006-02-15 17:35 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m11wy4ttir.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®