From: ebiederm@xmission.com (Eric W. Biederman)
To: Cal Peake <cp@absolutedigital.net>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] kill extraneous printk in kernel_restart()
Date: Fri, 18 Aug 2006 21:41:05 -0600 [thread overview]
Message-ID: <m13bbtwfxq.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0608181650001.30597@lancer.cnet.absolutedigital.net> (Cal Peake's message of "Fri, 18 Aug 2006 17:02:12 -0400 (EDT)")
Cal Peake <cp@absolutedigital.net> writes:
> Hi,
>
> Is there a reason for printing a single dot and newline in
> kernel_restart()? If not, below is a one-liner to kill it.
Hmm. This looks like a thinko from my original patch.
Signed-off-By: Eric W. Biederman <ebiederm@xmission.com>
> --
>
> Get rid of an extraneous printk in kernel_restart().
>
> Signed-off-by: Cal Peake <cp@absolutedigital.net>
>
> --- linux-2.6.18-rc4/kernel/sys.c~orig 2006-08-07 22:00:27.000000000 -0400
> +++ linux-2.6.18-rc4/kernel/sys.c 2006-08-18 16:52:52.000000000 -0400
> @@ -611,7 +611,6 @@ void kernel_restart(char *cmd)
> } else {
> printk(KERN_EMERG "Restarting system with command '%s'.\n", cmd);
> }
> - printk(".\n");
> machine_restart(cmd);
> }
> EXPORT_SYMBOL_GPL(kernel_restart);
prev parent reply other threads:[~2006-08-19 3:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 21:02 Cal Peake
2006-08-19 3:41 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m13bbtwfxq.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@osdl.org \
--cc=cp@absolutedigital.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome